Router::handle() - Code Metrics - Inspection of "router: modular uri bugs fixes" - o2system/kernel - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( c64b7f...c8c077 )

by Steeven
created 2019-09-02 08:26 UTC
Router::handle() F

↳ Parent: Router
Complexity

Conditions	16
Paths	340
Size

Total Lines	88
Code Lines	58
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	1	Features	0
Metric	Value
cc	16
eloc	58
c	1
b	1
f	0
nc	340
nop	1
dl	0
loc	88
rs	2.9833
How to fix Long Method Complexity

<?php
/**
 * This file is part of the O2System Framework package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author         Steeve Andrian Salim
 * @copyright      Copyright (c) Steeve Andrian Salim
 */

// ------------------------------------------------------------------------

namespace O2System\Kernel\Http;

// ------------------------------------------------------------------------

/**
 * Class Router
 * @package O2System\Kernel\Http
 */
class Router
{
    /**
     * Router::$uri
     *
     * @var Message\Uri
     */
    protected $uri;

    /**
     * Router::$addresses
     *
     * @var Router\Addresses
     */
    protected $addresses;

    // ------------------------------------------------------------------------

    /**
     * Router::getUri
     *
     * Gets routed Uri.
     *
     * @return Message\Uri
     */
    public function getUri()
    {
        return $this->uri;
    }

    // ------------------------------------------------------------------------

    /**
     * Router::getAddresses
     *
     * @return \O2System\Kernel\Http\Router\Addresses
     */
    public function getAddresses()
    {
        return $this->addresses;
    }

    // ------------------------------------------------------------------------

    /**
     * Router::setAddresses
     *
     * Sets router addresses.
     *
     * @param \O2System\Kernel\Http\Router\Addresses $addresses
     *
     * @return static
     */
    public function setAddresses(Router\Addresses $addresses)
    {
        $this->addresses = $addresses;

        return $this;
    }

    // ------------------------------------------------------------------------

    /**
     * Router::handle
     *
     * @param \O2System\Kernel\Http\Message\Uri|null $uri
     *
     * @return bool
     * @throws \ReflectionException
     * @throws \O2System\Spl\Exceptions\RuntimeException
     */
    public function handle(Message\Uri $uri = null)
    {
        $this->uri = is_null($uri) ? server_request()->getUri() : $uri;
        $uriSegments = $this->uri->segments->getArrayCopy();
        $uriString = $this->uri->segments->__toString();

        if (count($uriSegments)) {
            if (strpos(end($uriSegments), '.json') !== false) {
                output()->setContentType('application/json');
                output()->/** @scrutinizer ignore-call */ setContentType('application/json');
                $endSegment = str_replace('.json', '', end($uriSegments));
                array_pop($uriSegments);
                array_push($uriSegments, $endSegment);
                $this->uri = $this->uri->withSegments(new Message\Uri\Segments($uriSegments));
                $uriString = $this->uri->segments->__toString();
            } elseif (strpos(end($uriSegments), '.xml') !== false) {
                output()->setContentType('application/xml');
                $endSegment = str_replace('.xml', '', end($uriSegments));
                array_pop($uriSegments);
                array_push($uriSegments, $endSegment);
                $this->uri = $this->uri->withSegments(new Message\Uri\Segments($uriSegments));
                $uriString = $this->uri->segments->__toString();
            }
        } else {
            $uriPath = urldecode(
                parse_url($_SERVER[ 'REQUEST_URI' ], PHP_URL_PATH)
            );

            $uriPathParts = explode('public/', $uriPath);
            $uriPath = end($uriPathParts);

            if ($uriPath !== '/') {
                $uriString = $uriPath;
                $uriSegments = array_filter(explode('/', $uriString));

                $this->uri = $this->uri->withSegments(new Message\Uri\Segments($uriSegments));
                $this->uri = $this->uri->withSegments(new Message\Uri\Segments(/** @scrutinizer ignore-type */ $uriSegments));
                $uriString = $this->uri->segments->__toString();
            }
        }

        // Try to translate from uri string
        if (false !== ($action = $this->addresses->getTranslation($uriString))) {
            if ( ! $action->isValidHttpMethod(server_request()->getMethod()) && ! $action->isAnyHttpMethod()) {
                output()->sendError(405);
            } else {
                if (false !== ($parseSegments = $action->getParseUriString($uriString))) {
                    $uriSegments = $parseSegments;
                } else {
                    $uriSegments = [];
                }

                $this->uri = $this->uri->withSegments(new Message\Uri\Segments($uriSegments));
                $this->uri = $this->uri->withSegments(new Message\Uri\Segments(/** @scrutinizer ignore-type */ $uriSegments));

                $this->parseAction($action, $uriSegments);
                $this->parseAction(/** @scrutinizer ignore-type */ $action, $uriSegments);

                if (services()->has('controller')) {
                    return true;
                }
            }
        }

        // Try to get route from controller & page
        if ($uriTotalSegments = count($uriSegments)) {
            $namespaces = [
                'App\Controllers\\',
                'App\Http\Controllers\\',
                'O2System\Reactor\Http\Controllers\\',
            ];

            for ($i = 0; $i <= $uriTotalSegments; $i++) {
                $uriRoutedSegments = array_slice($uriSegments, 0, ($uriTotalSegments - $i));

                foreach ($namespaces as $namespace) {

                    $controllerClassName = $namespace . implode('\\',
                            array_map('studlycase', $uriRoutedSegments));

                    if (class_exists($controllerClassName)) {
                        $uriSegments = array_diff($uriSegments, $uriRoutedSegments);
                        $this->setController(new Router\DataStructures\Controller($controllerClassName),
                            $uriSegments);
                        break;
                    }
                }

                // break the loop if the controller has been set
                if (services()->has('controller')) {
                    return true;
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                }
            }
        }

        // Let's the app do the rest when there is no controller found
        // the app should redirect to PAGE 404
    }

    // ------------------------------------------------------------------------

    /**
     * Router::parseAction
     *
     * @param \O2System\Kernel\Http\Router\DataStructures\Action $action
     * @param array                                              $uriSegments
     *
     * @throws \O2System\Spl\Exceptions\RuntimeException
     * @throws \ReflectionException
     */
    protected function parseAction(Router\DataStructures\Action $action, array $uriSegments = [])
    {
        $closure = $action->getClosure();
        if (empty($closure)) {
            output()->sendError(204);
        }

        if ($closure instanceof Controller) {
            $uriSegments = empty($uriSegments)
                ? $action->getClosureParameters()
                : $uriSegments;
            $this->setController(
                (new Router\DataStructures\Controller($closure))
                (new Router\DataStructures\Controller(/** @scrutinizer ignore-type */ $closure))
                    ->setRequestMethod('index'),
                $uriSegments
            );
        } elseif ($closure instanceof Router\DataStructures\Controller) {
            $this->setController($closure, $action->getClosureParameters());
        } elseif (is_array($closure)) {
            $this->uri = (new Message\Uri())
                ->withSegments(new Message\Uri\Segments(''))
                ->withQuery('');
            $this->handle($this->uri->addSegments($closure));
        } else {
            if (class_exists($closure)) {
                $this->setController(
                    (new Router\DataStructures\Controller($closure))
                        ->setRequestMethod('index'),
                    $uriSegments
                );
            } elseif (preg_match("/([a-zA-Z0-9\\\]+)(@)([a-zA-Z0-9\\\]+)/", $closure, $matches)) {
                $this->setController(
                    (new Router\DataStructures\Controller($matches[ 1 ]))
                        ->setRequestMethod($matches[ 3 ]),
                    $uriSegments
                );
            } elseif (is_string($closure) && $closure !== '') {
                if (is_json($closure)) {
                    output()->setContentType('application/json');
                    output()->send($closure);
                    output()->/** @scrutinizer ignore-call */ send($closure);
                } else {
                    output()->send($closure);
                }
            } elseif (is_array($closure) || is_object($closure)) {
                output()->send($closure);
            } elseif (is_numeric($closure)) {
                output()->sendError($closure);
            } else {
                output()->sendError(204);
                exit(EXIT_ERROR);

            }
        }
    }

    // ------------------------------------------------------------------------

    /**
     * Router::setController
     *
     * @param \O2System\Kernel\Http\Router\DataStructures\Controller $controller
     * @param array                                                  $uriSegments
     *
     * @throws \ReflectionException
     */
    protected function setController(
        Router\DataStructures\Controller $controller,
        array $uriSegments = []
    ) {
        if ( ! $controller->isValid()) {
            output()->sendError(400);
        }

        // Add Controller PSR4 Namespace
        loader()->addNamespace($controller->getNamespaceName(), $controller->getFileInfo()->getPath());
        loader()->addNamespace($controller->getNamespaceName(), $controller->getFileInfo()->getPath());

        $controllerMethod = $controller->getRequestMethod();
        $controllerMethod = empty($controllerMethod) ? reset($uriSegments) : $controllerMethod;
        $controllerMethod = camelcase($controllerMethod);

        // Set default controller method to index
        if ( ! $controller->hasMethod($controllerMethod) &&
            ! $controller->hasMethod('route')
        ) {
            $controllerMethod = 'index';
        }

        // has route method, controller method set to index as default
        if (empty($controllerMethod)) {
            $controllerMethod = 'index';
        }

        if (camelcase(reset($uriSegments)) === $controllerMethod) {
            array_shift($uriSegments);
        }

        $controllerMethodParams = $uriSegments;

        if ($controller->hasMethod('route')) {
            $controller->setRequestMethod('route');
            $controller->setRequestMethodArgs([
                $controllerMethod,
                $controllerMethodParams,
            ]);
        } elseif ($controller->hasMethod($controllerMethod)) {
            $method = $controller->getMethod($controllerMethod);

            // Method doesn't need any parameters
            if ($method->getNumberOfParameters() == 0) {
                // But there is parameters requested
                if (count($controllerMethodParams)) {
                    output()->sendError(404);
                } else {
                    $controller->setRequestMethod($controllerMethod);
                }
            } else {
                $parameters = [];

                if (count($controllerMethodParams)) {
                    if (is_numeric(key($controllerMethodParams))) {
                        $parameters = $controllerMethodParams;
                    } else {
                        foreach ($method->getParameters() as $index => $parameter) {
                            if (isset($uriSegments[ $parameter->name ])) {
                                $parameters[ $index ] = $controllerMethodParams[ $parameter->name ];
                            } else {
                                $parameters[ $index ] = null;
                            }
                        }
                    }
                }

                $controller->setRequestMethod($controllerMethod);
                $controller->setRequestMethodArgs($parameters);
            }
        }

        // Set Controller
        services()->add($controller, 'controller');
    }
}
o2system / kernel

GitHub Access Token became invalid

Push — master ( c64b7f...c8c077 )

Router::handle() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
