o2system /
kernel
| Conditions | 15 |
| Paths | 120 |
| Total Lines | 46 |
| Code Lines | 31 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 34 | public function load($className, $offset = null) |
||
| 35 | { |
||
| 36 | if (is_string($className)) { |
||
|
introduced
by
|
|||
| 37 | $className = str_replace([ |
||
| 38 | 'O2System\Framework\\', |
||
| 39 | 'O2System\Reactor\\', |
||
| 40 | 'O2System\Kernel\\', |
||
| 41 | 'App\\', |
||
| 42 | ], '', |
||
| 43 | ltrim($className, '\\') |
||
| 44 | ); |
||
| 45 | |||
| 46 | if (class_exists($className)) { |
||
| 47 | $service = new SplServiceRegistry($className); |
||
| 48 | } else { |
||
| 49 | if (is_object(kernel()->modules)) { |
||
| 50 | if ($module = kernel()->modules->top()) { |
||
| 51 | if (class_exists($serviceClassName = $module->getNamespace() . $className)) { |
||
| 52 | $service = new SplServiceRegistry($serviceClassName); |
||
| 53 | } |
||
| 54 | } |
||
| 55 | } |
||
| 56 | |||
| 57 | if (empty($service)) { |
||
| 58 | if (class_exists($serviceClassName = 'App\\' . $className)) { |
||
| 59 | $service = new SplServiceRegistry($serviceClassName); |
||
| 60 | } elseif (class_exists($serviceClassName = 'O2System\Framework\\' . $className)) { |
||
| 61 | $service = new SplServiceRegistry($serviceClassName); |
||
| 62 | } elseif (class_exists($serviceClassName = 'O2System\Reactor\\' . $className)) { |
||
| 63 | $service = new SplServiceRegistry($serviceClassName); |
||
| 64 | } elseif (class_exists($serviceClassName = 'O2System\Kernel\\' . $className)) { |
||
| 65 | $service = new SplServiceRegistry($serviceClassName); |
||
| 66 | } elseif(class_exists($className)) { |
||
| 67 | $service = new SplServiceRegistry($serviceClassName); |
||
| 68 | } |
||
| 69 | } |
||
| 70 | } |
||
| 71 | } |
||
| 72 | |||
| 73 | if (isset($service)) { |
||
| 74 | if ($service instanceof SplServiceRegistry) { |
||
| 75 | if (profiler() !== false) { |
||
| 76 | profiler()->watch('Load New Service: ' . $service->getClassName()); |
||
| 77 | } |
||
| 78 | |||
| 79 | $this->register($service, $offset); |
||
| 80 | } |
||
| 129 | } |
Loading history...
