src/Views/assets/js/print-out.js - Code Metrics - Inspection of "toolbar z-index bugs fixing" - o2system/gear - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 86eabc...c09291 )

by Steeven

created 2019-10-02 16:40 UTC

src/Views/assets/js/print-out.js A

↳ Parent: Project

Complexity

Total Complexity	12
Complexity/F	2.4

Size

Lines of Code	50
Function Count	5

Duplication

Duplicated Lines	12
Ratio	24 %

Importance

Changes

Metric	Value
eloc	35
c	0
b	0
f	0
dl	12
loc	50
rs	10
wmc	12
mnd	7
bc	7
fnc	5
bpm	1.4
cpm	2.4
noi	3

4 Functions

Rating	Name	Size	Complexity
A	print-out.js ➔ gearCopySelectionText	9	2
A	print-out.js ➔ gearSelectCode	11	3
A	print-out.js ➔ gearGetSelectionText	7	5
A	print-out.js ➔ gearCopyCode	7	2

How to fix Duplicated Code

/*
 * This file is part of the O2System Framework package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author         Steeve Andrian Salim
 * @copyright      Copyright (c) Steeve Andrian Salim
 */
// ------------------------------------------------------------------------
(function () {

    var pre = document.getElementsByTagName('pre'),
        preLen = pre.length;
    for (var i = 0; i < preLen; i++) {
        pre[i].innerHTML = '<span class="line-number"></span>' + pre[i].innerHTML + '<span class="clear-both"></span>';
        var linesNum = pre[i].innerHTML.split(/\n/).length;
        for (var number = 0; number < linesNum; number++) {
            var lineNumber = pre[i].getElementsByTagName('span')[0];
            lineNumber.innerHTML += '<span>' + (number + 1) + '</span>';
        }
    }
})();

function gearGetSelectionText() {
    var selectedText = ""
    if (window.getSelection) { // all modern browsers and IE9+
        selectedText = window.getSelection().toString()
    }
    return selectedText;
}

function gearCopySelectionText() {
    var isCopied // var to check whether execCommand successfully executed
    try {
        isCopied = document.execCommand("copy") // run command to copy selected text to clipboard
    } catch (e) {
        isCopied = false
    }
    return isCopied;
}

function gearSelectCode() {
    if (document.selection) {
        var range = document.body.createTextRange();
        range.moveToElementText(document.getElementById('gear-code-container'));
        range.select();
    } else if (window.getSelection) {
        var range = document.createRange();

        range.selectNode(document.getElementById('gear-code-container'));
        window.getSelection().addRange(range);
    }
}

function gearCopyCode() {
    var selected = gearGetSelectionText() // call gearGetSelectionText() to see what was selected
    if (selected.length > 0) { // if selected text length is greater than 0
        var isCopied = gearCopySelectionText() // copy user selected text to clipboard

        alert('Copied to clipboard');

    }
}

1		/*
2		* This file is part of the O2System Framework package.
3		*
4		* For the full copyright and license information, please view the LICENSE
5		* file that was distributed with this source code.
6		*
7		* @author Steeve Andrian Salim
8		* @copyright Copyright (c) Steeve Andrian Salim
9		*/
10		// ------------------------------------------------------------------------
11	View Code Duplication	(function () {
		0 ignored issues – show Duplication introduced 2019-01-16 12:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
12		var pre = document.getElementsByTagName('pre'),
13		preLen = pre.length;
14		for (var i = 0; i < preLen; i++) {
15		pre[i].innerHTML = '<span class="line-number"></span>' + pre[i].innerHTML + '<span class="clear-both"></span>';
16		var linesNum = pre[i].innerHTML.split(/\n/).length;
17		for (var number = 0; number < linesNum; number++) {
18		var lineNumber = pre[i].getElementsByTagName('span')[0];
19		lineNumber.innerHTML += '<span>' + (number + 1) + '</span>';
20		}
21		}
22		})();
23
24		function gearGetSelectionText() {
25		var selectedText = ""
26		if (window.getSelection) { // all modern browsers and IE9+
27		selectedText = window.getSelection().toString()
28		}
29		return selectedText;
30		}
31
32		function gearCopySelectionText() {
33		var isCopied // var to check whether execCommand successfully executed
34		try {
35		isCopied = document.execCommand("copy") // run command to copy selected text to clipboard
36		} catch (e) {
37		isCopied = false
38		}
39		return isCopied;
40		}
41
42		function gearSelectCode() {
43		if (document.selection) {
44		var range = document.body.createTextRange();
45		range.moveToElementText(document.getElementById('gear-code-container'));
46		range.select();
47		} else if (window.getSelection) {
48		var range = document.createRange();
		0 ignored issues – show Comprehensibility Naming Best Practice introduced 2019-01-16 12:18 UTC by Report Bug Copy Issue Report The variable `range` already seems to be declared on line `44`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history...
49		range.selectNode(document.getElementById('gear-code-container'));
50		window.getSelection().addRange(range);
51		}
52		}
53
54		function gearCopyCode() {
55		var selected = gearGetSelectionText() // call gearGetSelectionText() to see what was selected
56		if (selected.length > 0) { // if selected text length is greater than 0
57		var isCopied = gearCopySelectionText() // copy user selected text to clipboard
		0 ignored issues – show Unused Code introduced 2019-01-16 12:18 UTC by Report Bug Copy Issue Report The variable `isCopied` seems to be never used. Consider removing it. Loading history...
58		alert('Copied to clipboard');
		0 ignored issues – show Debugging Code Best Practice introduced 2019-01-16 12:18 UTC by Report Bug Copy Issue Report The `alert` UI element is often considered obtrusive and is generally only used as a temporary measure. Consider replacing it with another UI element. Loading history...
59		}
60		}

o2system / gear

GitHub Access Token became invalid

Push — master ( 86eabc...c09291 )

src/Views/assets/js/print-out.js A

Complexity

Size

Duplication

Importance

4 Functions

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like