o2system /
framework
| Total Complexity | 60 |
| Total Lines | 401 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like Assets often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Assets, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class Assets |
||
| 24 | { |
||
| 25 | /** |
||
| 26 | * Assets::$head |
||
| 27 | * |
||
| 28 | * @var \O2System\Framework\Http\Presenter\Assets\Positions\Head |
||
| 29 | */ |
||
| 30 | protected $head; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * Assets::$body |
||
| 34 | * |
||
| 35 | * @var \O2System\Framework\Http\Presenter\Assets\Positions\Body |
||
| 36 | */ |
||
| 37 | protected $body; |
||
| 38 | |||
| 39 | // ------------------------------------------------------------------------ |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Assets::__construct |
||
| 43 | */ |
||
| 44 | public function __construct() |
||
| 45 | { |
||
| 46 | loader()->addPublicDir('assets', 'assets'); |
||
| 47 | |||
| 48 | $this->head = new Assets\Positions\Head(); |
||
| 49 | $this->body = new Assets\Positions\Body(); |
||
| 50 | } |
||
| 51 | |||
| 52 | // ------------------------------------------------------------------------ |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Assets::__get |
||
| 56 | * |
||
| 57 | * @param string $property |
||
| 58 | * |
||
| 59 | * @return \O2System\Framework\Http\Presenter\Assets\Positions\Body|\O2System\Framework\Http\Presenter\Assets\Positions\Head|null |
||
| 60 | */ |
||
| 61 | public function __get($property) |
||
| 62 | { |
||
| 63 | return isset($this->{$property}) ? $this->{$property} : null; |
||
| 64 | } |
||
| 65 | |||
| 66 | // ------------------------------------------------------------------------ |
||
| 67 | |||
| 68 | /** |
||
| 69 | * Assets::autoload |
||
| 70 | * |
||
| 71 | * @param array $assets |
||
| 72 | * |
||
| 73 | * @return void |
||
| 74 | */ |
||
| 75 | public function autoload($assets) |
||
| 76 | { |
||
| 77 | foreach ($assets as $position => $collections) { |
||
| 78 | if (property_exists($this, $position)) { |
||
| 79 | |||
| 80 | if ($collections instanceof \ArrayObject) { |
||
| 81 | $collections = $collections->getArrayCopy(); |
||
| 82 | } |
||
| 83 | |||
| 84 | $this->{$position}->loadCollections($collections); |
||
| 85 | } elseif ($position === 'packages') { |
||
| 86 | $this->loadPackages($collections); |
||
| 87 | } elseif ($position === 'css') { |
||
| 88 | $this->loadCss($collections); |
||
| 89 | } elseif ($position === 'js') { |
||
| 90 | $this->loadJs($collections); |
||
| 91 | } |
||
| 92 | } |
||
| 93 | } |
||
| 94 | |||
| 95 | // ------------------------------------------------------------------------ |
||
| 96 | |||
| 97 | /** |
||
| 98 | * Assets::loadPackages |
||
| 99 | * |
||
| 100 | * @param array $packages |
||
| 101 | * |
||
| 102 | * @return void |
||
| 103 | */ |
||
| 104 | public function loadPackages($packages) |
||
| 105 | { |
||
| 106 | foreach ($packages as $package => $files) { |
||
| 107 | if (is_string($files)) { |
||
| 108 | $this->loadPackage($files); |
||
| 109 | } elseif (is_array($files)) { |
||
| 110 | $this->loadPackage($package, $files); |
||
| 111 | } elseif (is_object($files)) { |
||
| 112 | $this->loadPackage($package, get_object_vars($files)); |
||
| 113 | } |
||
| 114 | } |
||
| 115 | } |
||
| 116 | |||
| 117 | // ------------------------------------------------------------------------ |
||
| 118 | |||
| 119 | /** |
||
| 120 | * Assets::loadPackage |
||
| 121 | * |
||
| 122 | * @param string $package |
||
| 123 | * @param array $subPackages |
||
| 124 | * |
||
| 125 | * @return void |
||
| 126 | */ |
||
| 127 | public function loadPackage($package, $subPackages = []) |
||
| 208 | } |
||
| 209 | } |
||
| 210 | |||
| 211 | // ------------------------------------------------------------------------ |
||
| 212 | |||
| 213 | /** |
||
| 214 | * Assets::loadCss |
||
| 215 | * |
||
| 216 | * @param array $files |
||
| 217 | * |
||
| 218 | * @return void |
||
| 219 | */ |
||
| 220 | public function loadCss($files) |
||
| 221 | { |
||
| 222 | $files = is_string($files) ? [$files] : $files; |
||
|
introduced
by
|
|||
| 223 | $this->head->loadCollections(['css' => $files]); |
||
| 224 | } |
||
| 225 | |||
| 226 | // ------------------------------------------------------------------------ |
||
| 227 | |||
| 228 | /** |
||
| 229 | * Assets::loadJs |
||
| 230 | * |
||
| 231 | * @param string|array $files |
||
| 232 | * @param string $position |
||
| 233 | * |
||
| 234 | * @return void |
||
| 235 | */ |
||
| 236 | public function loadJs($files, $position = 'body') |
||
| 237 | { |
||
| 238 | $files = is_string($files) ? [$files] : $files; |
||
| 239 | $this->{$position}->loadCollections(['js' => $files]); |
||
| 240 | } |
||
| 241 | |||
| 242 | // ------------------------------------------------------------------------ |
||
| 243 | |||
| 244 | /** |
||
| 245 | * Assets::loadFiles |
||
| 246 | * |
||
| 247 | * @param array $assets |
||
| 248 | * |
||
| 249 | * @return void |
||
| 250 | */ |
||
| 251 | public function loadFiles($assets) |
||
| 252 | { |
||
| 253 | foreach ($assets as $type => $item) { |
||
| 254 | $addMethod = 'load' . ucfirst($type); |
||
| 255 | |||
| 256 | if (method_exists($this, $addMethod)) { |
||
| 257 | call_user_func_array([&$this, $addMethod], [$item]); |
||
| 258 | } |
||
| 259 | } |
||
| 260 | } |
||
| 261 | |||
| 262 | // ------------------------------------------------------------------------ |
||
| 263 | |||
| 264 | /** |
||
| 265 | * Assets::theme |
||
| 266 | * |
||
| 267 | * @param string $path |
||
| 268 | * |
||
| 269 | * @return string |
||
| 270 | */ |
||
| 271 | public function theme($path) |
||
| 272 | { |
||
| 273 | $path = str_replace(['\\', '/'], DIRECTORY_SEPARATOR, $path); |
||
| 274 | |||
| 275 | if (is_file($filePath = PATH_THEME . $path)) { |
||
| 276 | return path_to_url($filePath); |
||
| 277 | } |
||
| 278 | } |
||
| 279 | |||
| 280 | // ------------------------------------------------------------------------ |
||
| 281 | |||
| 282 | /** |
||
| 283 | * Assets::file |
||
| 284 | * |
||
| 285 | * @param string $file |
||
| 286 | * |
||
| 287 | * @return string |
||
| 288 | */ |
||
| 289 | public function file($file) |
||
| 297 | } |
||
| 298 | } |
||
| 299 | } |
||
| 300 | |||
| 301 | // ------------------------------------------------------------------------ |
||
| 302 | |||
| 303 | /** |
||
| 304 | * Assets::image |
||
| 305 | * |
||
| 306 | * @param string $image |
||
| 307 | * |
||
| 308 | * @return string |
||
| 309 | */ |
||
| 310 | public function image($image) |
||
| 311 | { |
||
| 312 | $filePaths = loader()->getPublicDirs(true); |
||
| 313 | $image = str_replace(['\\', '/'], DIRECTORY_SEPARATOR, $image); |
||
| 314 | |||
| 315 | foreach ($filePaths as $filePath) { |
||
| 316 | $filePath .= 'img' . DIRECTORY_SEPARATOR; |
||
| 317 | |||
| 318 | if (is_file($filePath . $image)) { |
||
| 319 | return path_to_url($filePath . $image); |
||
| 320 | break; |
||
| 321 | } |
||
| 322 | |||
| 323 | unset($filePath); |
||
| 324 | } |
||
| 325 | } |
||
| 326 | |||
| 327 | // ------------------------------------------------------------------------ |
||
| 328 | |||
| 329 | /** |
||
| 330 | * Assets::media |
||
| 331 | * |
||
| 332 | * @param string $media |
||
| 333 | * |
||
| 334 | * @return string |
||
| 335 | */ |
||
| 336 | public function media($media) |
||
| 337 | { |
||
| 338 | $filePaths = loader()->getPublicDirs(true); |
||
| 339 | $media = str_replace(['\\', '/'], DIRECTORY_SEPARATOR, $media); |
||
| 340 | |||
| 341 | foreach ($filePaths as $filePath) { |
||
| 342 | $filePath .= 'media' . DIRECTORY_SEPARATOR; |
||
| 343 | |||
| 344 | if (is_file($filePath . $media)) { |
||
| 345 | return path_to_url($filePath . $media); |
||
| 346 | break; |
||
| 347 | } |
||
| 348 | |||
| 349 | unset($filePath); |
||
| 350 | } |
||
| 351 | } |
||
| 352 | |||
| 353 | // ------------------------------------------------------------------------ |
||
| 354 | |||
| 355 | /** |
||
| 356 | * Assets::parseSourceCode |
||
| 357 | * |
||
| 358 | * @param string $sourceCode |
||
| 359 | * |
||
| 360 | * @return string |
||
| 361 | */ |
||
| 362 | public function parseSourceCode($sourceCode) |
||
| 424 | } |
||
| 425 | } |
||
| 426 |
Loading history...