O2System\Framework\Http\Controllers\Images

Complexity

Total Complexity

36

Size/Duplication

Total Lines	302
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
F	route()	0	93	20
A	original()	0	12	2
A	__construct()	0	4	1
B	scale()	0	41	6
B	resize()	0	42	7

<?php
/**
 * This file is part of the O2System Framework package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author         Steeve Andrian Salim
 * @copyright      Copyright (c) Steeve Andrian Salim
 */

// ------------------------------------------------------------------------

namespace O2System\Framework\Http\Controllers;

// ------------------------------------------------------------------------

use O2System\Cache\Item;
use O2System\Framework\Http\Controller;
use O2System\Image\Manipulation;

/**
 * Class Images
 *
 * @package O2System\Framework\Http\Controllers
 */
class Images extends Controller
{
    /**
     * Images::$inherited
     *
     * Controller inherited flag.
     *
     * @var bool
     */
    static public $inherited = true;

    /**
     * Images::$storagePath
     *
     * @var string
     */
    public $storagePath;

    /**
     * Images::$imageNotFoundFilename
     *
     * @var string
     */
    public $imageNotFoundFilename = 'not-found.jpg';

    /**
     * Images::$imageFilePath
     *
     * @var string
     */
    public $imageFilePath = null;

    /**
     * Images::$imageFileMime
     *
     * @var string
     */
    public $imageFileMime = null;

    /**
     * Images::$imageSize
     *
     * @var array
     */
    public $imageSize = [
        'width'  => null,
        'height' => null,
    ];

    /**
     * Images::$imageScale
     *
     * @var string
     */
    public $imageScale = null;

    /**
     * Images::$imageQuality
     *
     * @var int
     */
    public $imageQuality = null;

    /**
     * Images::$imageCrop
     *
     * @var bool
     */
    public $imageCrop = false;

    // ------------------------------------------------------------------------

    /**
     * Images::__construct
     */
    public function __construct()
    {
        $this->storagePath = PATH_STORAGE . 'images' . DIRECTORY_SEPARATOR;
        $this->imageNotFoundFilename = $this->storagePath . 'not-found.jpg';
    }

    // ------------------------------------------------------------------------

    /**
     * Images::route
     */
    public function route()
    {
        $segments = server_request()->getUri()->segments->getArrayCopy();

        if (false !== ($key = array_search('images', $segments))) {
            $segments = array_slice($segments, $key);

It seems like $key can also be of type string; however, parameter $offset of array_slice() does only seem to accept integer, maybe add an additional type check?

        } else {
            array_shift($segments);
        }

        $this->imageFilePath = $this->imageNotFoundFilename;

        $this->imageSize[ 'width' ] = $this->input->get('width');

The property input does not exist on O2System\Framework\Http\Controllers\Images. Since you implemented __get, consider adding a @property annotation.

        $this->imageSize[ 'height' ] = $this->input->get('height');
        $this->imageScale = $this->input->get('scale');
        $this->imageQuality = $this->input->get('quality');
        $this->imageCrop = $this->input->get('crop');

        if (false !== ($key = array_search('crop', $segments))) {
            $this->imageCrop = true;
            unset($segments[ $key ]);
            $segments = array_values($segments);
        }

        if (count($segments) == 1) {
            $this->imageFilePath = $this->storagePath . end($segments);
        } elseif (count($segments) >= 2) {
            if (preg_match("/(\d+)(x)(\d+)/", $segments[ count($segments) - 2 ], $matches)) {
                $this->imageSize[ 'width' ] = $matches[ 1 ];
                $this->imageSize[ 'height' ] = $matches[ 3 ];

                if (count($segments) == 2) {
                    $this->imageFilePath = $this->storagePath . end($segments);
                } else {
                    $this->imageFilePath = $this->storagePath . implode(DIRECTORY_SEPARATOR,
                            array_slice($segments, 0,
                                count($segments) - 2)) . DIRECTORY_SEPARATOR . end($segments);
                }
            } elseif (preg_match("/(\d+)(p)/", $segments[ count($segments) - 2 ],
                    $matches) or is_numeric($segments[ count($segments) - 2 ])
            ) {
                $this->imageScale = isset($matches[ 1 ]) ? $matches[ 1 ] : $segments[ count($segments) - 2 ];
                if (count($segments) == 2) {
                    $this->imageFilePath = $this->storagePath . end($segments);
                } else {
                    $this->imageFilePath = $this->storagePath . implode(DIRECTORY_SEPARATOR,
                            array_slice($segments, 0,
                                count($segments) - 2)) . DIRECTORY_SEPARATOR . end($segments);
                }
            } else {
                $this->imageFilePath = $this->storagePath . implode(DIRECTORY_SEPARATOR, $segments);
            }
        }

        $imageFilePath = $this->imageFilePath;
        $extensions[ 0 ] = pathinfo($imageFilePath, PATHINFO_EXTENSION);

$extensions was never initialized. Although not strictly required by PHP, it is generally a good practice to add $extensions = array(); before regardless.

        for ($i = 0; $i < 2; $i++) {
            $extension = pathinfo($imageFilePath, PATHINFO_EXTENSION);

            if ($extension !== '') {
                $extensions[ $i ] = $extension;
                $imageFilePath = str_replace('.' . $extensions[ $i ], '', $imageFilePath);
            }
        }

        $mimes = [
            'gif'  => 'image/gif',
            'jpg'  => 'image/jpeg',
            'png'  => 'image/png',
            'webp' => 'image/webp',
        ];

        if (count($extensions) == 2) {
            $this->imageFilePath = $imageFilePath . '.' . $extensions[ 1 ];
        }

        if (array_key_exists($extension = reset($extensions), $mimes)) {
            $this->imageFileMime = $mimes[ $extension ];
        } elseif (array_key_exists($extension = pathinfo($this->imageFilePath, PATHINFO_EXTENSION), $mimes)) {
            $this->imageFileMime = $mimes[ $extension ];
        }

        if ( ! is_file($this->imageFilePath)) {
            $this->imageFilePath = $this->imageNotFoundFilename;
        }

        if ( ! empty($this->imageScale)) {
            $this->scale();
        } elseif ( ! empty($this->imageSize[ 'width' ]) || ! empty($this->imageSize[ 'height' ])) {
            $this->resize();
        } else {
            $this->original();
        }
    }

    // ------------------------------------------------------------------------

    /**
     * Images::scale
     *
     * @throws \O2System\Spl\Exceptions\Runtime\FileNotFoundException
     */
    protected function scale()
    {
        $config = config('image', true);

        if ( ! empty($this->imageQuality)) {
            $config->offsetSet('quality', intval($this->imageQuality));
        }

        if ($config->cached === true) {

The property cached does not exist on O2System\Framework\Containers\Config. Since you implemented __get, consider adding a @property annotation.

            if ($this->imageFilePath !== $this->imageNotFoundFilename) {
                $cacheImageKey = 'image-' . $this->imageScale . '-' . str_replace($this->storagePath, '',
                        $this->imageFilePath);

                if (cache()->hasItemPool('images')) {
                    $cacheItemPool = cache()->getItemPool('images');

                    if ($cacheItemPool->hasItem($cacheImageKey)) {
                        $cacheImageString = $cacheItemPool->getItem($cacheImageKey)->get();

                        $manipulation = new Manipulation($config);

It seems like $config can also be of type O2System\Framework\Containers\Config; however, parameter $config of O2System\Image\Manipulation::__construct() does only seem to accept O2System\Image\DataStructures\Config|null, maybe add an additional type check?

                        $manipulation->setImageFile($this->imageFilePath);
                        $manipulation->setImageString($cacheImageString);
                        $manipulation->displayImage(intval($this->imageQuality), $this->imageFileMime);
                    } else {
                        $manipulation = new Manipulation($config);
                        $manipulation->setImageFile($this->imageFilePath);
                        $manipulation->scaleImage($this->imageScale);

$this->imageScale of type string is incompatible with the type integer expected by parameter $newScale of O2System\Image\Manipulation::scaleImage().

                        $cacheItemPool->save(new Item($cacheImageKey, $manipulation->getBlobImage(), false));

false of type false is incompatible with the type DateInterval|integer expected by parameter $expiresAfter of O2System\Cache\Item::__construct().

                        $manipulation->displayImage(intval($this->imageQuality), $this->imageFileMime);
                        exit(EXIT_SUCCESS);

Using exit here is not recommended.

                    }
                }
            }
        }

        $manipulation = new Manipulation($config);
        $manipulation->setImageFile($this->imageFilePath);
        $manipulation->scaleImage($this->imageScale);
        $manipulation->displayImage(intval($this->imageQuality), $this->imageFileMime);
        exit(EXIT_SUCCESS);

Using exit here is not recommended.

    }

    // ------------------------------------------------------------------------

    /**
     * Images::resize
     *
     * @throws \O2System\Spl\Exceptions\Runtime\FileNotFoundException
     */
    protected function resize()
    {
        $config = config('image', true);

        if ( ! empty($this->imageQuality)) {
            $config->offsetSet('quality', intval($this->imageQuality));
        }

        if ($config->cached === true) {

The property cached does not exist on O2System\Framework\Containers\Config. Since you implemented __get, consider adding a @property annotation.

            if ($this->imageFilePath !== $this->imageNotFoundFilename) {
                $cacheImageKey = 'image-' . ($this->input->get('crop') ? 'crop-' : '') . implode('x',

The property input does not exist on O2System\Framework\Http\Controllers\Images. Since you implemented __get, consider adding a @property annotation.

                        $this->imageSize) . '-' . str_replace($this->storagePath, '', $this->imageFilePath);

                if (cache()->hasItemPool('images')) {
                    $cacheItemPool = cache()->getItemPool('images');

                    if ($cacheItemPool->hasItem($cacheImageKey)) {
                        $cacheImageString = $cacheItemPool->getItem($cacheImageKey)->get();

                        $manipulation = new Manipulation($config);

It seems like $config can also be of type O2System\Framework\Containers\Config; however, parameter $config of O2System\Image\Manipulation::__construct() does only seem to accept O2System\Image\DataStructures\Config|null, maybe add an additional type check?

                        $manipulation->setImageFile($this->imageFilePath);
                        $manipulation->setImageString($cacheImageString);
                        $manipulation->displayImage(intval($this->imageQuality), $this->imageFileMime);
                    } else {
                        $manipulation = new Manipulation($config);
                        $manipulation->setImageFile($this->imageFilePath);
                        $manipulation->resizeImage($this->imageSize[ 'width' ], $this->imageSize[ 'height' ],
                            (bool)$this->imageCrop);
                        $cacheItemPool->save(new Item($cacheImageKey, $manipulation->getBlobImage(), false));

false of type false is incompatible with the type DateInterval|integer expected by parameter $expiresAfter of O2System\Cache\Item::__construct().

                        $manipulation->displayImage(intval($this->imageQuality), $this->imageFileMime);
                        exit(EXIT_SUCCESS);

Using exit here is not recommended.

                    }
                }
            }
        }

        $manipulation = new Manipulation($config);
        $manipulation->setImageFile($this->imageFilePath);
        $manipulation->resizeImage($this->imageSize[ 'width' ], $this->imageSize[ 'height' ], (bool)$this->imageCrop);
        $manipulation->displayImage(intval($this->imageQuality), $this->imageFileMime);
        exit(EXIT_SUCCESS);

Using exit here is not recommended.

    }

    // ------------------------------------------------------------------------

    /**
     * Images::original
     *
     * @throws \O2System\Spl\Exceptions\Runtime\FileNotFoundException
     */
    protected function original()
    {
        $config = config('image', true);

        if ( ! empty($this->imageQuality)) {
            $config->offsetSet('quality', intval($this->imageQuality));
        }

        $manipulation = new Manipulation($config);

It seems like $config can also be of type O2System\Framework\Containers\Config; however, parameter $config of O2System\Image\Manipulation::__construct() does only seem to accept O2System\Image\DataStructures\Config|null, maybe add an additional type check?

        $manipulation->setImageFile($this->imageFilePath);
        $manipulation->displayImage(intval($this->imageQuality), $this->imageFileMime);
        exit(EXIT_SUCCESS);

Using exit here is not recommended.

    }
}