O2System\Filesystem\Handlers\Downloader::download()

Complexity

Conditions	16
Paths	36

Size

Total Lines	124
Code Lines	66

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function download($filename = null)
    {
        $filename = isset($filename) ? $filename : $this->fileinfo[ 'basename' ];

        if ($this->partialRequest) {
            if ($this->resumeable) {
                // Turn on resume capability
                output()
                    ->sendHeaderStatus(206, 'Partial Content', '1.0')

The method sendHeaderStatus() does not exist on O2System\Kernel\Cli\Output.

                    ->sendHeader('Status', '206 Partial Content')

The method sendHeader() does not exist on O2System\Kernel\Cli\Output.

                    ->sendHeader('Accept-Ranges', 'bytes');

                output()->sendHeader('Content-range',
                    'bytes ' . $this->seekStart . '-' . $this->seekEnd . '/' . $this->filesize);
            } else {
                // Turn off resume capability
                $this->seekStart = 0;
                $this->seekEnd = $this->filesize - 1;
                $this->seekFileSize = $this->filesize;
            }
        }

        // Common Download Headers content type, content disposition, content length and last modified
        output()
            ->sendHeader('Content-Type', $this->filemime)
            ->sendHeader('Content-Disposition', 'attachment; filename=' . $filename)
            ->sendHeader('Content-Length', $this->seekFileSize)
            ->sendHeader('Last-Modified', date('D, d M Y H:i:s \G\M\T', $this->lastModified));
        // End Headers Stage

        // Work On Download Speed Limit
        if ($this->speedLimit) {
            // how many buffers ticks per second
            $bufferTicks = 10;    //10
            // how long one buffering tick takes by micro second
            $bufferMicroTime = 150; // 100
            // Calculate sleep micro time after each tick
            $sleepMicroTime = round((1000000 - ($bufferTicks * $bufferMicroTime)) / $bufferTicks);
            // Calculate required buffer per one tick, make sure it is integer so round the result
            $this->bufferSize = round($this->speedLimit * 1024 / $bufferTicks);
        }
        // Immediatly Before Downloading
        // clean any output buffer
        @ob_end_clean();

It seems like you do not handle an error condition for ob_end_clean(). This can introduce security issues, and is generally not recommended.

        // get oignore_user_abort value, then change it to yes
        $oldUserAbortSetting = ignore_user_abort();
        ignore_user_abort(true);
        // set script execution time to be unlimited
        @set_time_limit(0);

It seems like you do not handle an error condition for set_time_limit(). This can introduce security issues, and is generally not recommended.

        // Download According Download Mode
        if ($this->mode === self::MODE_FILESTREAM) {
            // Download Data by fopen
            $downloadFileBytes = $this->seekFileSize;
            $downloaded = 0;
            // goto the position of the first byte to download
            fseek($this->filedata, $this->seekStart);

$this->filedata of type string is incompatible with the type resource expected by parameter $handle of fseek().

            while ($downloadFileBytes > 0 && ! (connection_aborted() || connection_status() == 1)) {
                // still Downloading
                if ($downloadFileBytes > $this->bufferSize) {
                    // send buffer size
                    echo fread($this->filedata, $this->bufferSize); // this also will seek to after last read byte

$this->filedata of type string is incompatible with the type resource expected by parameter $handle of fread().

                    $downloaded += $this->bufferSize;    // updated downloaded
                    $downloadFileBytes -= $this->bufferSize;    // update remaining bytes
                } else {
                    // send required size
                    // this will happens when we reaches the end of the file normally we wll download remaining bytes
                    echo fread($this->filedata, $downloadFileBytes);    // this also will seek to last reat

                    $downloaded += $downloadFileBytes;    // Add to downloaded


                    $downloadFileBytes = 0;    // Here last bytes have been written
                }
                // send to buffer
                flush();
                // Check For Download Limit
                if ($this->speedLimit) {
                    usleep($sleepMicroTime);

The variable $sleepMicroTime does not seem to be defined for all execution paths leading up to this point.

                }


            }
            // all bytes have been sent to user
            // Close File
            fclose($this->filedata);

$this->filedata of type string is incompatible with the type resource expected by parameter $handle of fclose().

        } elseif ($this->mode === self::MODE_DATASTREAM) {
            // Download Data String
            $downloadFileBytes = $this->seekFileSize;

            $downloaded = 0;
            $offset = $this->seekStart;
            while ($downloadFileBytes > 0 && ( ! connection_aborted())) {
                if ($downloadFileBytes > $this->bufferSize) {
                    // Download by buffer
                    echo mb_strcut($this->filedata, $offset, $this->bufferSize);
                    $downloadFileBytes -= $this->bufferSize;
                    $downloaded += $this->bufferSize;
                    $offset += $this->bufferSize;
                } else {
                    // download last bytes
                    echo mb_strcut($this->filedata, $offset, $downloadFileBytes);
                    $downloaded += $downloadFileBytes;
                    $offset += $downloadFileBytes;
                    $downloadFileBytes = 0;
                }
                // Send Data to Buffer
                flush();
                // Check Limit
                if ($this->speedLimit) {
                    usleep($sleepMicroTime);
                }

            }
        }

        // Set Downloaded Bytes
        $this->downloadedFileSize = $downloaded;

The variable $downloaded does not seem to be defined for all execution paths leading up to this point.

        ignore_user_abort($oldUserAbortSetting); // Restore old user abort settings

$oldUserAbortSetting of type integer is incompatible with the type boolean expected by parameter $value of ignore_user_abort().

        set_time_limit(ini_get('max_execution_time')); // Restore Default script max execution Time

ini_get('max_execution_time') of type string is incompatible with the type integer expected by parameter $seconds of set_time_limit().

        exit;

Using exit here is not recommended.

    }
}