GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.

MailProtocol::sending()   B
last analyzed

Complexity

Conditions 10
Paths 64

Size

Total Lines 49
Code Lines 23

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 10
eloc 23
nc 64
nop 1
dl 0
loc 49
rs 7.6666
c 0
b 0
f 0

How to fix   Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
/**
3
 * This file is part of the O2System Framework package.
4
 *
5
 * For the full copyright and license information, please view the LICENSE
6
 * file that was distributed with this source code.
7
 *
8
 * @author         Steeve Andrian Salim
9
 * @copyright      Copyright (c) Steeve Andrian Salim
10
 */
11
12
// ------------------------------------------------------------------------
13
14
namespace O2System\Email\Protocols;
15
16
// ------------------------------------------------------------------------
17
18
use O2System\Email\Address;
19
use O2System\Email\Message;
20
use PHPMailer\PHPMailer\PHPMailer;
21
22
/**
23
 * Class MailProtocol
24
 *
25
 * @package O2System\Email\Protocols
26
 */
27
class MailProtocol extends Abstracts\AbstractProtocol
28
{
29
    /**
30
     * MailProtocol::sending
31
     *
32
     * Protocol message sending process.
33
     *
34
     * @param Message $message
35
     *
36
     * @return bool
37
     * @throws \PHPMailer\PHPMailer\Exception
38
     */
39
    protected function sending(Message $message)
40
    {
41
        $phpMailer = new PHPMailer();
42
        $phpMailer->isMail();
43
44
        // Set from
45
        if (false !== ($from = $message->getFrom())) {
0 ignored issues
show
introduced by
The condition false !== $from = $message->getFrom() is always true.
Loading history...
46
            $phpMailer->setFrom($from->getEmail(), $from->getName());
0 ignored issues
show
Bug introduced by
It seems like $from->getEmail() can also be of type false; however, parameter $address of PHPMailer\PHPMailer\PHPMailer::setFrom() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

46
            $phpMailer->setFrom(/** @scrutinizer ignore-type */ $from->getEmail(), $from->getName());
Loading history...
Bug introduced by
It seems like $from->getName() can also be of type false; however, parameter $name of PHPMailer\PHPMailer\PHPMailer::setFrom() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

46
            $phpMailer->setFrom($from->getEmail(), /** @scrutinizer ignore-type */ $from->getName());
Loading history...
47
        }
48
49
        // Set recipient
50
        if (false !== ($to = $message->getTo())) {
51
            foreach ($to as $address) {
52
                if ($address instanceof Address) {
53
                    $phpMailer->addAddress($address->getEmail(), $address->getName());
0 ignored issues
show
Bug introduced by
It seems like $address->getEmail() can also be of type false; however, parameter $address of PHPMailer\PHPMailer\PHPMailer::addAddress() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

53
                    $phpMailer->addAddress(/** @scrutinizer ignore-type */ $address->getEmail(), $address->getName());
Loading history...
Bug introduced by
It seems like $address->getName() can also be of type false; however, parameter $name of PHPMailer\PHPMailer\PHPMailer::addAddress() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

53
                    $phpMailer->addAddress($address->getEmail(), /** @scrutinizer ignore-type */ $address->getName());
Loading history...
54
                }
55
            }
56
        }
57
58
        // Set reply-to
59
        if (false !== ($replyTo = $message->getReplyTo())) {
0 ignored issues
show
introduced by
The condition false !== $replyTo = $message->getReplyTo() is always true.
Loading history...
60
            $phpMailer->addReplyTo($replyTo->getEmail(), $replyTo->getName());
0 ignored issues
show
Bug introduced by
It seems like $replyTo->getEmail() can also be of type false; however, parameter $address of PHPMailer\PHPMailer\PHPMailer::addReplyTo() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

60
            $phpMailer->addReplyTo(/** @scrutinizer ignore-type */ $replyTo->getEmail(), $replyTo->getName());
Loading history...
Bug introduced by
It seems like $replyTo->getName() can also be of type false; however, parameter $name of PHPMailer\PHPMailer\PHPMailer::addReplyTo() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

60
            $phpMailer->addReplyTo($replyTo->getEmail(), /** @scrutinizer ignore-type */ $replyTo->getName());
Loading history...
61
        }
62
63
        // Set content-type
64
        if ($message->getContentType() === 'html') {
65
            $phpMailer->isHTML(true);
66
        }
67
68
        // Set subject, body & alt-body
69
        $phpMailer->Subject = $message->getSubject();
70
        $phpMailer->Body = $message->getBody();
71
        $phpMailer->AltBody = $message->getAltBody();
72
73
        if (false !== ($attachments = $message->getAttachments())) {
74
            foreach ($attachments as $filename => $attachment) {
75
                $phpMailer->addAttachment($attachment, $filename);
76
            }
77
        }
78
79
        if ( ! $phpMailer->send()) {
80
            $this->addErrors([
81
                $phpMailer->ErrorInfo,
82
            ]);
83
84
            return false;
85
        }
86
87
        return true;
88
    }
89
}