View GitHub Repository craft-webperf

Schedule Inspection
Subscribe
Passed
Branch — v1 (eb0178)
by Andrew
08:09
created

src/assetbundles/webperf/src/js/dashboard.js   A

↳ Parent: Project

Complexity

Total Complexity 2
Complexity/F 2

Size

Lines of Code 32
Function Count 1

Duplication

Duplicated Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
wmc 2
eloc 24
c 0
b 0
f 0
dl 0
loc 32
rs 10
mnd 1
bc 1
fnc 1
bpm 1
cpm 2
noi 4
1 
import VueEvents from 'vue-events';
2 
import Confetti from '@/vue/common/Confetti.vue';
3 
import RadialBarChart from '@/vue/charts/common/RadialBarChart.vue';
4 
import SimpleBarChart from '@/vue/charts/common/SimpleBarChart.vue';
5 
import DashboardFileList from '@/vue/charts/dashboard/DashboardFileList.vue';
6 
import SampleRangePicker from '@/vue/common/SampleRangePicker.vue';
7 
import SamplePaneFooter from '@/vue/common/SamplePaneFooter.vue';
8 
import RecommendationsList from '@/vue/common/RecommendationsList.vue';
9 

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
Vue.use(VueEvents);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The variable Vue seems to be never declared. If this is a global, consider adding a /** global: Vue */ comment.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This checks looks for references to variables that have not been declared. This is most
likey a typographical error or a variable has been renamed.


To learn more about declaring variables in Javascript, see the
MDN.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
// Create our vue instance

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
const vm = new Vue({

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                                                                        
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
The opening parenthesis of a multi-line function call should be the last content on the line.
                                            

                    
                                                    

                     Loading history...
                

                    


    




                                                                                            




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
The constant vm seems to be never used. Consider removing it.
                                                                                                

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    el: "#cp-nav-content",

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    components: {

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
        'confetti': Confetti,

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
        'radial-bar-chart': RadialBarChart,

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
        'simple-bar-chart': SimpleBarChart,

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
        'dashboard-file-list': DashboardFileList,

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
        'sample-range-picker': SampleRangePicker,

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
        'sample-pane-footer': SamplePaneFooter,

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
        'recommendations-list': RecommendationsList,

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
    },

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
    data: {

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
    },

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
    mounted() {

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
    },

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
});

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
For multi-line function calls, the closing parenthesis should be on a new line.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
If a function call spawns multiple lines, the coding standard suggests to move
the closing parenthesis to a new line:


someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
// Accept HMR as per: https://webpack.js.org/api/hot-module-replacement#accept

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
if (module.hot) {

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
    module.hot.accept();

            


            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    33