View GitHub Repository craft-webperf

Schedule Inspection
Subscribe
Passed
Branch — v1 (eb0178)
by Andrew
08:09
created

src/assetbundles/webperf/src/js/alerts.js   A

↳ Parent: Project

Complexity

Total Complexity 2
Complexity/F 2

Size

Lines of Code 18
Function Count 1

Duplication

Duplicated Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
wmc 2
eloc 10
c 0
b 0
f 0
dl 0
loc 18
rs 10
mnd 1
bc 1
fnc 1
bpm 1
cpm 2
noi 4
1 
import VeeValidate from 'vee-validate';
2 

            


            
                                                        
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
Vue.use(VeeValidate);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The variable Vue seems to be never declared. If this is a global, consider adding a /** global: Vue */ comment.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This checks looks for references to variables that have not been declared. This is most
likey a typographical error or a variable has been renamed.


To learn more about declaring variables in Javascript, see the
MDN.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
// Create our vue instance

            


            
                                                        
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
const vm = new Vue({

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                                                                        
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
The opening parenthesis of a multi-line function call should be the last content on the line.
                                            

                    
                                                    

                     Loading history...
                

                    


    




                                                                                            




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
The constant vm seems to be never used. Consider removing it.
                                                                                                

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
    el: "#cp-nav-content",

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
    components: {

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    },

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
    data: {

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
    },

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
    mounted() {

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
    },

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
});

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
For multi-line function calls, the closing parenthesis should be on a new line.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
If a function call spawns multiple lines, the coding standard suggests to move
the closing parenthesis to a new line:


someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
// Accept HMR as per: https://webpack.js.org/api/hot-module-replacement#accept

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
if (module.hot) {

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
    module.hot.accept();

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    19