src/web/assets/src/js/performance-index.js - Code Metrics - Inspection of "feat: Refactor to use Vite" - nystudio107/craft-webperf - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 31af39...1ae34d )

by Andrew

created 2022-01-02 07:20 UTC

src/web/assets/src/js/performance-index.js A

↳ Parent: Project

Complexity

Total Complexity	4
Complexity/F	1

Size

Lines of Code	27
Function Count	4

Duplication

Duplicated Lines	27
Ratio	100 %

Importance

Changes

Metric	Value
wmc	4
eloc	19
c	0
b	0
f	0
dl	27
loc	27
rs	10
mnd	0
bc	0
fnc	4
bpm	0
cpm	1
noi	5

How to fix Duplicated Code

import VueEvents from 'vue-events';

import PerformanceIndexTable from '@/vue/tables/performance/PerformanceIndexTable.vue';
import SampleRangePicker from '@/vue/common/SampleRangePicker.vue';
import PerformanceDetailAreaChart from '@/vue/charts/performance/PerformanceDetailAreaChart.vue';
import RecommendationsList from '@/vue/common/RecommendationsList.vue';

Vue.use(VueEvents);

// Create our vue instance
const vm = new Vue({

    el: "#cp-nav-content",
    components: {
        'performance-index-table': PerformanceIndexTable,
        'sample-range-picker': SampleRangePicker,
        'performance-detail-area-chart': PerformanceDetailAreaChart,
        'recommendations-list': RecommendationsList,
    },
    data: {
    },
    methods: {
        onTableRefresh(vuetable) {
            Vue.nextTick(() => vuetable.refresh());

        }
    },
    mounted() {
        this.$events.$on('refresh-table', eventData => this.onTableRefresh(eventData));
    },
});
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.


1	View Code Duplication	import VueEvents from 'vue-events';
		0 ignored issues – show Duplication introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
2		import PerformanceIndexTable from '@/vue/tables/performance/PerformanceIndexTable.vue';
3		import SampleRangePicker from '@/vue/common/SampleRangePicker.vue';
4		import PerformanceDetailAreaChart from '@/vue/charts/performance/PerformanceDetailAreaChart.vue';
5		import RecommendationsList from '@/vue/common/RecommendationsList.vue';
6
7		Vue.use(VueEvents);
		0 ignored issues – show Bug introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report The variable `Vue` seems to be never declared. If this is a global, consider adding a `/** global: Vue */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
8		// Create our vue instance
9		const vm = new Vue({
		0 ignored issues – show Unused Code introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report The constant `vm` seems to be never used. Consider removing it. Loading history... Coding Style introduced 2019-02-01 02:14 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
10		el: "#cp-nav-content",
11		components: {
12		'performance-index-table': PerformanceIndexTable,
13		'sample-range-picker': SampleRangePicker,
14		'performance-detail-area-chart': PerformanceDetailAreaChart,
15		'recommendations-list': RecommendationsList,
16		},
17		data: {
18		},
19		methods: {
20		onTableRefresh(vuetable) {
21		Vue.nextTick(() => vuetable.refresh());
		0 ignored issues – show Bug introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report The variable `Vue` seems to be never declared. If this is a global, consider adding a `/** global: Vue */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
22		}
23		},
24		mounted() {
25		this.$events.$on('refresh-table', eventData => this.onTableRefresh(eventData));
26		},
27		});
		0 ignored issues – show Coding Style introduced 2019-02-01 02:14 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
28

nystudio107 / craft-webperf

Push — develop ( 31af39...1ae34d )

src/web/assets/src/js/performance-index.js A

Complexity

Size

Duplication

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like