src/web/assets/src/js/performance-detail.js - Code Metrics - Inspection of "feat: Refactor to use Vite" - nystudio107/craft-webperf - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 31af39...1ae34d )

by Andrew

created 2022-01-02 07:20 UTC

src/web/assets/src/js/performance-detail.js A

↳ Parent: Project

Complexity

Total Complexity	4
Complexity/F	1

Size

Lines of Code	33
Function Count	4

Duplication

Duplicated Lines	33
Ratio	100 %

Importance

Changes

Metric	Value
wmc	4
eloc	25
c	0
b	0
f	0
dl	33
loc	33
rs	10
mnd	0
bc	0
fnc	4
bpm	0
cpm	1
noi	5

How to fix Duplicated Code

import VueEvents from 'vue-events';

import PerformanceDetailAreaChart from '@/vue/charts/performance/PerformanceDetailAreaChart.vue';
import PerformanceDetailTable from '@/vue/tables/performance/PerformanceDetailTable.vue';
import RadialBarChart from '@/vue/charts/common/RadialBarChart.vue';
import SimpleBarChart from '@/vue/charts/common/SimpleBarChart.vue';
import SampleRangePicker from '@/vue/common/SampleRangePicker.vue';
import SamplePaneFooter from '@/vue/common/SamplePaneFooter.vue';
import RecommendationsList from '@/vue/common/RecommendationsList.vue';

Vue.use(VueEvents);

// Create our vue instance
const vm = new Vue({

    el: "#cp-nav-content",
    components: {
        'performance-detail-area-chart': PerformanceDetailAreaChart,
        'performance-detail-table': PerformanceDetailTable,
        'radial-bar-chart': RadialBarChart,
        'simple-bar-chart': SimpleBarChart,
        'sample-range-picker': SampleRangePicker,
        'sample-pane-footer': SamplePaneFooter,
        'recommendations-list': RecommendationsList,
    },
    data: {
    },
    methods: {
        onTableRefresh(vuetable) {
            Vue.nextTick(() => vuetable.refresh());

        }
    },
    mounted() {
        this.$events.$on('refresh-table', eventData => this.onTableRefresh(eventData));
    },
});
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.


1	View Code Duplication	import VueEvents from 'vue-events';
		0 ignored issues – show Duplication introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
2		import PerformanceDetailAreaChart from '@/vue/charts/performance/PerformanceDetailAreaChart.vue';
3		import PerformanceDetailTable from '@/vue/tables/performance/PerformanceDetailTable.vue';
4		import RadialBarChart from '@/vue/charts/common/RadialBarChart.vue';
5		import SimpleBarChart from '@/vue/charts/common/SimpleBarChart.vue';
6		import SampleRangePicker from '@/vue/common/SampleRangePicker.vue';
7		import SamplePaneFooter from '@/vue/common/SamplePaneFooter.vue';
8		import RecommendationsList from '@/vue/common/RecommendationsList.vue';
9
10		Vue.use(VueEvents);
		0 ignored issues – show Bug introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report The variable `Vue` seems to be never declared. If this is a global, consider adding a `/** global: Vue */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
11		// Create our vue instance
12		const vm = new Vue({
		0 ignored issues – show Coding Style introduced 2019-01-19 05:19 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history... Unused Code introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report The constant `vm` seems to be never used. Consider removing it. Loading history...
13		el: "#cp-nav-content",
14		components: {
15		'performance-detail-area-chart': PerformanceDetailAreaChart,
16		'performance-detail-table': PerformanceDetailTable,
17		'radial-bar-chart': RadialBarChart,
18		'simple-bar-chart': SimpleBarChart,
19		'sample-range-picker': SampleRangePicker,
20		'sample-pane-footer': SamplePaneFooter,
21		'recommendations-list': RecommendationsList,
22		},
23		data: {
24		},
25		methods: {
26		onTableRefresh(vuetable) {
27		Vue.nextTick(() => vuetable.refresh());
		0 ignored issues – show Bug introduced 2021-07-17 15:47 UTC by Report Bug Copy Issue Report The variable `Vue` seems to be never declared. If this is a global, consider adding a `/** global: Vue */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
28		}
29		},
30		mounted() {
31		this.$events.$on('refresh-table', eventData => this.onTableRefresh(eventData));
32		},
33		});
		0 ignored issues – show Coding Style introduced 2019-01-19 05:19 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
34

nystudio107 / craft-webperf

Push — develop ( 31af39...1ae34d )

src/web/assets/src/js/performance-detail.js A

Complexity

Size

Duplication

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like