nystudio107\webperf\controllers\ChartsController::actionDashboardSlowestPages()

Complexity

Conditions	9
Paths	72

Size

Total Lines	63
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function actionDashboardSlowestPages(
        string $range = 'day',
        string $column = 'pageLoad',
        int $limit = 3,
        int $siteId = 0
    ): Response {
        PermissionHelper::controllerPermissionCheck('webperf:dashboard');
        $data = [];
        $days = 1;
        switch ($range) {
            case 'day':

Line indented incorrectly; expected 8 spaces, found 12

                $days = 1;
                break;
            case 'week':

Line indented incorrectly; expected 8 spaces, found 12

                $days = 7;
                break;
            case 'month':

Line indented incorrectly; expected 8 spaces, found 12

                $days = 30;
                break;
        }
        // Different dbs do it different ways
        $stats = null;
        $db = Craft::$app->getDb();
        if ($db->getIsMysql()) {
            // Query the db
            $query = (new Query())
                ->from('{{%webperf_data_samples}}')
                ->select([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    '*',
                    'AVG('.$column.') AS avg',
                ])

For multi-line function calls, the closing parenthesis should be on a new line.

                ->where("dateUpdated >= ( CURDATE() - INTERVAL '{$days}' DAY )");
            if ((int)$siteId !== 0) {
                $query->andWhere(['siteId' => $siteId]);
            }
            $query
                ->orderBy('avg DESC')
                ->groupBy('url')
                ->limit($limit);
            $stats = $query->all();
        }
        if ($db->getIsPgsql()) {
            // Query the db
            $query = (new Query())
                ->from('{{%webperf_data_samples}}')
                ->select([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'AVG("'.$column.'") AS avg',
                ])

For multi-line function calls, the closing parenthesis should be on a new line.

                ->where("\"dateUpdated\" >= ( CURRENT_TIMESTAMP - INTERVAL '{$days} days' )");
            if ((int)$siteId !== 0) {
                $query->andWhere(['siteId' => $siteId]);
            }
            $stats = $query->all();
        }
        if ($stats) {
            $data = ArrayHelper::getColumn($stats, 'avg');

The assignment to $data is dead and can be removed.

        }

        Craft::debug('Slowest Pages: '.print_r($stats, true), __METHOD__);

        $data = [];

        return $this->asJson($data);
    }