nystudio107\webperf\controllers\ChartsController::actionPagesAreaChart()

Complexity

Conditions	9
Paths	192

Size

Total Lines	123
Code Lines	88

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function actionPagesAreaChart(
        string $start,
        string $end,
        $pageUrl = '',
        int $siteId = 0
    ): Response {
        PermissionHelper::controllerPermissionCheck('webperf:dashboard');
        $data = [];
        // Add a day since YYYY-MM-DD is really YYYY-MM-DD 00:00:00
        $end = date('Y-m-d', strtotime($end.'+1 day'));
        $pageUrl = urldecode($pageUrl);
        $dateStart = new \DateTime($start);
        $dateEnd = new \DateTime($end);
        $interval = date_diff($dateStart, $dateEnd);
        $dateFormat = "'%Y-%m-%d %H'";
        if ($interval->days > 30) {
            $dateFormat = "'%Y-%m-%d'";
        }
            // Different dbs do it different ways
        $stats = null;

The assignment to $stats is dead and can be removed.

        $db = Craft::$app->getDb();
        if ($db->getIsPgsql()) {
            $dateFormat = "'yyyy-mm-dd HH:MM'";
            if ($interval->days > 30) {
                $dateFormat = "'yyyy-mm-dd'";
            }
        }
        // Query the db
        $query = (new Query())
            ->from('{{%webperf_data_samples}}')
            ->select([

The opening parenthesis of a multi-line function call should be the last content on the line.

                'AVG([[pageLoad]]) AS [[pageLoad]]',
                'AVG([[domInteractive]]) AS [[domInteractive]]',
                'AVG([[firstContentfulPaint]]) AS [[firstContentfulPaint]]',
                'AVG([[firstPaint]]) AS [[firstPaint]]',
                'AVG([[firstByte]]) AS [[firstByte]]',
                'AVG([[connect]]) AS [[connect]]',
                'AVG([[dns]]) AS [[dns]]',
                'AVG([[craftTotalMs]]) AS [[craftTotalMs]]',
                'AVG([[craftTwigMs]]) AS [[craftTwigMs]]',
                'AVG([[craftDbMs]]) AS [[craftDbMs]]',
            ])

For multi-line function calls, the closing parenthesis should be on a new line.

            ->where(['between', 'dateCreated', $start, $end])

Space after closing parenthesis of function call prohibited

            ;
        if ((int)$siteId !== 0) {
            $query->andWhere(['siteId' => $siteId]);
        }
        if ($pageUrl !== '') {
            $query->andWhere(['url' => $pageUrl]);
        }
        if ($db->getIsMysql()) {
            $query
                ->addSelect([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'DATE_FORMAT([[dateCreated]], '.$dateFormat.') AS [[sampleDate]]',
                ])

For multi-line function calls, the closing parenthesis should be on a new line.

                ->groupBy('sampleDate')

Space after closing parenthesis of function call prohibited

            ;
        }
        if ($db->getIsPgsql()) {
            $query
                ->addSelect([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'to_char([[dateCreated]], '.$dateFormat.') AS [[sampleDate]]',
                ])

For multi-line function calls, the closing parenthesis should be on a new line.

                ->groupBy(['to_char([[dateCreated]], '.$dateFormat.')'])

Space after closing parenthesis of function call prohibited

            ;
        }
        $stats = $query
            ->all();
        // Massage the data
        if ($stats) {
            $data[] = [
                'name' => 'Database Queries',
                'data' => ArrayHelper::getColumn($stats, 'craftDbMs'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'Twig Rendering',
                'data' => ArrayHelper::getColumn($stats, 'craftTwigMs'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'Craft Rendering',
                'data' => ArrayHelper::getColumn($stats, 'craftTotalMs'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'DNS Lookup',
                'data' => ArrayHelper::getColumn($stats, 'dns'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'Connect',
                'data' => ArrayHelper::getColumn($stats, 'connect'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'First Byte',
                'data' => ArrayHelper::getColumn($stats, 'firstByte'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'First Paint',
                'data' => ArrayHelper::getColumn($stats, 'firstPaint'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'First Contentful Paint',
                'data' => ArrayHelper::getColumn($stats, 'firstContentfulPaint'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'DOM Interactive',
                'data' => ArrayHelper::getColumn($stats, 'domInteractive'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
            $data[] = [
                'name' => 'Page Load',
                'data' => ArrayHelper::getColumn($stats, 'pageLoad'),
                'labels' => ArrayHelper::getColumn($stats, 'sampleDate'),
            ];
        }

        return $this->asJson($data);
    }