nystudio107\webperf\controllers\ChartsController::actionDashboardSlowestPages()

Complexity

Conditions	5
Paths	4

Size

Total Lines	50
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function actionDashboardSlowestPages(
        string $start,
        string $end,
        string $column = 'pageLoad',
        int $limit = 3,
        int $siteId = 0
    ): Response {
        PermissionHelper::controllerPermissionCheck('webperf:dashboard');
        $data = [];
        // Add a day since YYYY-MM-DD is really YYYY-MM-DD 00:00:00
        $end = date('Y-m-d', strtotime($end.'+1 day'));
        // Different dbs do it different ways
        $stats = null;

The assignment to $stats is dead and can be removed.

        $db = Craft::$app->getDb();

The assignment to $db is dead and can be removed.

        // Query the db
        $query = (new Query())
            ->from('{{%webperf_data_samples}}')
            ->select([

The opening parenthesis of a multi-line function call should be the last content on the line.

                '[[url]]',
                'MIN([[title]]) AS title',
                'COUNT([[url]]) AS cnt',
                'AVG([['.$column.']]) AS avg',
            ])

For multi-line function calls, the closing parenthesis should be on a new line.

            ->where(['between', 'dateCreated', $start, $end])
            ->andWhere(['not', [$column => null]]);
        if ((int)$siteId !== 0) {
            $query->andWhere(['siteId' => $siteId]);
        }
        $query
            ->orderBy('avg DESC')
            ->groupBy('url')
            ->limit($limit);
        $stats = $query->all();
        // Massage the data
        if ($stats) {
            foreach ($stats as &$stat) {
                $stat['cnt'] = (int)$stat['cnt'];
                $stat['detailPageUrl'] = UrlHelper::cpUrl('webperf/page-detail', [

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'pageUrl' => $stat['url'],
                    'siteId' => $siteId,
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                // Decode any emojis in the title
                if (!empty($stat['title'])) {
                    $stat['title'] = html_entity_decode($stat['title'], ENT_NOQUOTES, 'UTF-8');
                }
            }
            $data = $stats;
        }

        return $this->asJson($data);
    }