nystudio107\webperf\controllers\TablesController::actionPagesIndex()

Complexity

Conditions	19
Paths	63

Size

Total Lines	142
Code Lines	96

Duplication

Lines	0
Ratio	0 %

Importance

Changes	13
Bugs	0	Features	0

<?php
    public function actionPagesIndex(
        string $start = '',
        string $end = '',
        string $sort = 'pageLoad|DESC',
        int $page = 1,
        int $per_page = 20,
        $filter = '',
        $siteId = 0
    ): Response {
        PermissionHelper::controllerPermissionCheck('webperf:performance');
        $data = [];
        $sortField = 'pageLoad';
        $sortType = 'DESC';
        // Add a day since YYYY-MM-DD is really YYYY-MM-DD 00:00:00
        $end = date('Y-m-d', strtotime($end.'+1 day'));
        // Figure out the sorting type
        if ($sort !== '') {
            if (strpos($sort, '|') === false) {
                $sortField = $sort;
            } else {
                list($sortField, $sortType) = explode('|', $sort);
            }
        }
        $sortType = strtoupper($sortType);
        $sortType = self::SORT_MAP[$sortType] ?? self::SORT_MAP['DESC'];
        // Validate untrusted data
        if (!in_array($sortField, self::ALLOWED_PAGE_INDEX_SORT_FIELDS, true)) {
            throw new BadRequestHttpException(Craft::t('webperf', 'Invalid sort field specified.'));
        }
        // Query the db table
        $offset = ($page - 1) * $per_page;
        $query = (new Query())
            ->select([

The opening parenthesis of a multi-line function call should be the last content on the line.

                '[[url]]',
                'MIN([[title]]) AS [[title]]',
                'COUNT([[url]]) AS [[cnt]]',
                'AVG([[pageLoad]]) AS [[pageLoad]]',
                'AVG([[domInteractive]]) AS [[domInteractive]]',
                'AVG([[firstContentfulPaint]]) AS [[firstContentfulPaint]]',
                'AVG([[firstPaint]]) AS [[firstPaint]]',
                'AVG([[firstByte]]) AS [[firstByte]]',
                'AVG([[connect]]) AS [[connect]]',
                'AVG([[dns]]) AS [[dns]]',
                'AVG([[craftTotalMs]]) AS [[craftTotalMs]]',
                'AVG([[craftDbCnt]]) AS [[craftDbCnt]]',
                'AVG([[craftDbMs]]) AS [[craftDbMs]]',
                'AVG([[craftTwigCnt]]) AS [[craftTwigCnt]]',
                'AVG([[craftTwigMs]]) AS [[craftTwigMs]]',
                'AVG([[craftTotalMemory]]) AS [[craftTotalMemory]]',
            ])

For multi-line function calls, the closing parenthesis should be on a new line.

            ->from(['{{%webperf_data_samples}}'])
            ->offset($offset)
            ->where(['between', 'dateCreated', $start, $end])

Space after closing parenthesis of function call prohibited

        ;
        if ((int)$siteId !== 0) {
            $query->andWhere(['siteId' => $siteId]);
        }
        if ($filter !== '') {
            $query
                ->andWhere(['like', 'url', $filter])
                ->orWhere(['like', 'title', $filter])

Space after closing parenthesis of function call prohibited

            ;
        }
        $query
            ->orderBy([$sortField => $sortType])
            ->groupBy('url')
            ->limit($per_page)

Space after closing parenthesis of function call prohibited

        ;

        $stats = $query->all();
        if ($stats) {
            $user = Craft::$app->getUser()->getIdentity();
            // Compute the largest page load time
            $maxTotalPageLoad = 0;
            foreach ($stats as &$stat) {
             // Determine the stat type

Line indented incorrectly; expected at least 16 spaces, found 13

                if (!empty($stat['pageLoad']) && !empty($stat['craftTotalMs'])) {
                    $stat['type'] = 'both';
                }
                if (empty($stat['firstByte'])) {
                    $stat['type'] = 'craft';
                }
                if (empty($stat['craftTotalMs'])) {
                    $stat['type'] = 'frontend';
                }
                if ($stat['pageLoad'] > $maxTotalPageLoad) {
                    $maxTotalPageLoad = $stat['pageLoad'];
                }
            }
            // Massage the stats
            $index = 1;
            foreach ($stats as &$stat) {
                $stat['id'] = $index++;
                $stat['cnt'] = (int)$stat['cnt'];
                $stat['maxTotalPageLoad'] = (int)$maxTotalPageLoad;
                // Decode any emojis in the title
                if (!empty($stat['title'])) {
                    $stat['title'] = html_entity_decode($stat['title'], ENT_NOQUOTES, 'UTF-8');
                }
                // Set up the appropriate helper links
                $stat['deleteLink'] = UrlHelper::actionUrl('webperf/data-samples/delete-samples-by-url', [

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'pageUrl' => $stat['url'],
                    'siteId' => $siteId
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $stat['detailPageUrl'] = UrlHelper::cpUrl('webperf/performance/page-detail', [

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'pageUrl' => $stat['url'],
                    'siteId' => $siteId,
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                // Override based on permissions
                if (!$user->can('webperf:delete-data-samples')) {
                    $stat['deleteLink'] = '';
                }
                if (!$user->can('webperf:performance-detail')) {
                    $stat['detailPageUrl'] = '';
                }
            }
            // Format the data for the API
            $data['data'] = $stats;
            $query = (new Query())
                ->select(['[[url]]'])
                ->from(['{{%webperf_data_samples}}'])
                ->groupBy('[[url]]')
                ->where(['between', 'dateCreated', $start, $end])

Space after closing parenthesis of function call prohibited

                ;
            if ($filter !== '') {
                $query->andWhere(['like', 'url', $filter]);
                $query->orWhere(['like', 'title', $filter]);
            }
            $count = $query->count();
            $data['links']['pagination'] = [
                'total' => $count,
                'per_page' => $per_page,
                'current_page' => $page,
                'last_page' => ceil($count / $per_page),
                'next_page_url' => null,
                'prev_page_url' => null,
                'from' => $offset + 1,
                'to' => $offset + ($count > $per_page ? $per_page : $count),
            ];
        }

        return $this->asJson($data);
    }