RenderController::actionBeaconScript() - Code Metrics - Inspection of "Add the ability to render the script headless" - nystudio107/craft-webperf - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 0deb33...ed7ad9 )

by Andrew

created 2019-01-15 06:03 UTC

RenderController::actionBeaconScript() A

↳ Parent: RenderController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php
/**
 * Webperf plugin for Craft CMS 3.x
 *
 * Monitor the performance of your webpages through real-world user timing data
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2018 nystudio107

 */


namespace nystudio107\webperf\controllers;

use nystudio107\webperf\Webperf;

use craft\web\Controller;
filter:
    dependency_paths: ["lib/*"]

use yii\web\Response;
filter:
    dependency_paths: ["lib/*"]

/**

 * @author    nystudio107

 * @package   Webperf

 * @since     1.0.0

 */

class RenderController extends Controller
{
    // Protected Properties
    // =========================================================================

    protected $allowAnonymous = ['amp-iframe', 'beacon-script'];

    // Public Methods
    // =========================================================================

    /**

     * @return Response The rendered result
     */
    public function actionAmpIframe(): Response
    {
        // Render the template
        return $this->asRaw(Webperf::$plugin->beacons->ampHtmlIframe());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**

     * @param string $title

     *
     * @return Response
     */
    public function actionBeaconScript(string $title = ''): Response
    {
        return $this->asRaw(Webperf::$plugin->beacons->htmlBeaconScript($title));
    }
}


1			<?php
2			/**
3			* Webperf plugin for Craft CMS 3.x
4			*
5			* Monitor the performance of your webpages through real-world user timing data
6			*
7			* @link https://nystudio107.com
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) 2018 nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			namespace nystudio107\webperf\controllers;
12
13			use nystudio107\webperf\Webperf;
14
15			use craft\web\Controller;
			0 ignored issues – show Bug introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report The type `craft\web\Controller` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
16
17			use yii\web\Response;
			0 ignored issues – show Bug introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report The type `yii\web\Response` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
18
19			/**
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
20			* @author nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @package tag Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Content of the @author tag must be in the form "Display Name <[email protected]>" Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 2 spaces but found 4 Loading history...
21			* @package Webperf
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 1 spaces but found 3 Loading history...
22			* @since 1.0.0
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report The tag in position 3 should be the @author tag Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 3 spaces but found 5 Loading history...
23			*/
			0 ignored issues – show Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
24			class RenderController extends Controller
25			{
26			// Protected Properties
27			// =========================================================================
28
29			protected $allowAnonymous = ['amp-iframe', 'beacon-script'];
30
31			// Public Methods
32			// =========================================================================
33
34			/**
			0 ignored issues – show Coding Style introduced 2019-01-15 06:07 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
35			* @return Response The rendered result
36			*/
37			public function actionAmpIframe(): Response
38			{
39			// Render the template
40			return $this->asRaw(Webperf::$plugin->beacons->ampHtmlIframe());
			0 ignored issues – show Bug introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report Are you sure the usage of `nystudio107\webperf\Webp...eacons->ampHtmlIframe()` targeting `nystudio107\webperf\serv...eacons::ampHtmlIframe()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
41			}
42
43			/**
			0 ignored issues – show Coding Style introduced 2019-01-15 06:07 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
44			* @param string $title
			0 ignored issues – show Coding Style introduced 2019-01-15 06:07 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
45			*
46			* @return Response
47			*/
48			public function actionBeaconScript(string $title = ''): Response
49			{
50			return $this->asRaw(Webperf::$plugin->beacons->htmlBeaconScript($title));
51			}
52			}
53

nystudio107 / craft-webperf

Push — develop ( 0deb33...ed7ad9 )

RenderController::actionBeaconScript() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like