nystudio107\webperf\recommendations\MemoryLimit::evaluate()

Complexity

Conditions	5
Paths	5

Size

Total Lines	57
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function evaluate()
    {
        $phpMemoryLimit = $this->memoryLimit();
        if ($phpMemoryLimit) {
            $ratio = $phpMemoryLimit / $this->sample->craftTotalMemory;
            $displayCraftTotalMemory = (($this->sample->craftTotalMemory / 1024) / 1024) . 'M';
            $displayPhpMemoryLimit = (($phpMemoryLimit / 1024) / 1024) . 'M';
            $displayCraftMinMemory = ((self::MIN_CRAFT_MEMORY / 1024) / 1024) . 'M';
            $displayCraftMaxMemory = ((self::MAX_CRAFT_MEMORY / 1024) / 1024) . 'M';

The assignment to $displayCraftMaxMemory is dead and can be removed.

            $this->summary = Craft::t(
                'webperf',
                'Check the `memory_limit` setting in your `php.ini` file',
                []
            );
            // See if they have enough memory allocated
            if ($phpMemoryLimit < self::MIN_CRAFT_MEMORY) {
                $this->hasRecommendation = true;
                $this->detail = Craft::t(
                    'webperf',
                    'Pixel & Tonic recommends at least {displayCraftMinMemory} allocated to PHP for Craft CMS 3. You have only {displayPhpMemoryLimit} allocated in your `php.ini` file.',
                    [
                        'displayPhpMemoryLimit' => $displayPhpMemoryLimit,
                        'displayCraftMinMemory' => $displayCraftMinMemory,
                    ]
                );
                $this->learnMoreUrl = 'https://docs.craftcms.com/v3/requirements.html';

                return;
            }
            // See if they have too much memory allocated
            if ($phpMemoryLimit >= self::MAX_CRAFT_MEMORY) {
                $this->hasRecommendation = true;
                $this->detail = Craft::t(
                    'webperf',
                    'Your `php.ini` file has `memory_limit` set to {displayPhpMemoryLimit}. This may be set too high, since it is a per-process memory limit, and memory-intensive image transforms are done in a process separate from PHP.',
                    [
                        'displayPhpMemoryLimit' => $displayPhpMemoryLimit,
                    ]
                );
                $this->learnMoreUrl = 'https://docs.craftcms.com/v3/requirements.html';

                return;
            }
            // See if they have too much memory allocated
            if ($ratio < 1.5) {
                $this->hasRecommendation = true;
                $this->detail = Craft::t(
                    'webperf',
                    'Your `php.ini` file has `memory_limit` set to {displayPhpMemoryLimit}, but Craft is using {displayCraftTotalMemory}. Consider raising your `memory_limit`  to maintain a `1.5x` buffer of available memory.',
                    [
                        'displayPhpMemoryLimit' => $displayPhpMemoryLimit,
                        'displayCraftTotalMemory' => $displayCraftTotalMemory,
                    ]
                );
                $this->learnMoreUrl = 'https://docs.craftcms.com/v3/requirements.html';

                return;
            }