CraftQueryCount::evaluate() - Code Metrics - Inspection of "Version 1.0.0-beta.29" - nystudio107/craft-webperf - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v1 ( d9854b...3980d8 )

by Andrew

created 2019-01-28 23:41 UTC

CraftQueryCount::evaluate() A

↳ Parent: CraftQueryCount

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	11
dl	0
loc	20
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php
/**
 * Webperf plugin for Craft CMS 3.x
 *
 * Monitor the performance of your webpages through real-world user timing data
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2019 nystudio107

 */


namespace nystudio107\webperf\recommendations;

use nystudio107\webperf\base\Recommendation;

use Craft;
filter:
    dependency_paths: ["lib/*"]

/**

 * @author    nystudio107

 * @package   Webperf

 * @since     1.0.0

 */

class CraftQueryCount extends Recommendation
{
    // Constants
    // =========================================================================

    const MAX_QUERIES = 150;

    // Public Methods
    // =========================================================================

    /**

     * @inheritdoc
     */

    public function evaluate()
    {
        // See if there are too many database queries
        if ($this->sample->craftDbCnt >= self::MAX_QUERIES) {
            $this->hasRecommendation = true;
            $this->summary = Craft::t(
                'webperf',
                'Look into Eager Loading to decrease database queries',
                []
            );
            $this->detail = Craft::t(
                'webperf',
                'A total of {dbQueries} database queries were executed. Look into decreasing the number of database queries needed by leveraging Eager Loading in Craft CMS.',
                [
                    'dbQueries' => $this->sample->craftDbCnt,
                ]
            );
            $this->learnMoreUrl = 'https://nystudio107.com/blog/speed-up-your-craft-cms-templates-with-eager-loading';

            return;
        }
    }
}


1			<?php
2			/**
3			* Webperf plugin for Craft CMS 3.x
4			*
5			* Monitor the performance of your webpages through real-world user timing data
6			*
7			* @link https://nystudio107.com
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) 2019 nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			namespace nystudio107\webperf\recommendations;
12
13			use nystudio107\webperf\base\Recommendation;
14
15			use Craft;
			0 ignored issues – show Bug introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report The type `Craft` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
16
17			/**
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
18			* @author nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @package tag Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Content of the @author tag must be in the form "Display Name <[email protected]>" Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 2 spaces but found 4 Loading history...
19			* @package Webperf
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 1 spaces but found 3 Loading history...
20			* @since 1.0.0
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report The tag in position 3 should be the @author tag Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 3 spaces but found 5 Loading history...
21			*/
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
22			class CraftQueryCount extends Recommendation
23			{
24			// Constants
25			// =========================================================================
26
27			const MAX_QUERIES = 150;
28
29			// Public Methods
30			// =========================================================================
31
32			/**
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
33			* @inheritdoc
34			*/
			0 ignored issues – show Coding Style introduced 2019-01-28 23:43 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
35			public function evaluate()
36			{
37			// See if there are too many database queries
38			if ($this->sample->craftDbCnt >= self::MAX_QUERIES) {
39			$this->hasRecommendation = true;
40			$this->summary = Craft::t(
41			'webperf',
42			'Look into Eager Loading to decrease database queries',
43			[]
44			);
45			$this->detail = Craft::t(
46			'webperf',
47			'A total of {dbQueries} database queries were executed. Look into decreasing the number of database queries needed by leveraging Eager Loading in Craft CMS.',
48			[
49			'dbQueries' => $this->sample->craftDbCnt,
50			]
51			);
52			$this->learnMoreUrl = 'https://nystudio107.com/blog/speed-up-your-craft-cms-templates-with-eager-loading';
53
54			return;
55			}
56			}
57			}
58

nystudio107 / craft-webperf

Push — v1 ( d9854b...3980d8 )

CraftQueryCount::evaluate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like