nystudio107\webperf\services\Recommendations::data()

Complexity

Conditions	4
Paths	8

Size

Total Lines	47
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function data(
        $pageUrl = '',
        string $start = '',
        string $end = '',
        $siteId = 0
    ): array {
        $data = [];
        // Add a day since YYYY-MM-DD is really YYYY-MM-DD 00:00:00
        $end = date('Y-m-d', strtotime($end.'+1 day'));
        $pageUrl = urldecode($pageUrl);
        // Query the db table
        $query = (new Query())
            ->select([

The opening parenthesis of a multi-line function call should be the last content on the line.

                'COUNT(url) AS cnt',

                'AVG(pageLoad) AS pageLoad',
                'AVG(domInteractive) AS domInteractive',
                'AVG(firstContentfulPaint) AS firstContentfulPaint',
                'AVG(firstPaint) AS firstPaint',
                'AVG(firstByte) AS firstByte',
                'AVG(connect) AS connect',
                'AVG(dns) AS dns',

                'AVG(craftTotalMs) AS craftTotalMs',
                'AVG(craftDbMs) AS craftDbMs',
                'AVG(craftDbCnt) AS craftDbCnt',
                'AVG(craftTwigMs) AS craftTwigMs',
                'AVG(craftTwigCnt) AS craftTwigCnt',
                'AVG(craftOtherMs) AS craftOtherMs',
                'AVG(craftOtherCnt) AS craftOtherCnt',
                'AVG(craftTotalMemory) AS craftTotalMemory',
            ])

For multi-line function calls, the closing parenthesis should be on a new line.

            ->from(['{{%webperf_data_samples}}'])
            ->where(['between', 'dateCreated', $start, $end])

Space after closing parenthesis of function call prohibited

        ;
        if (!empty($pageUrl)) {
            $query->andWhere(['url' => $pageUrl]);
        }
        if ((int)$siteId !== 0) {
            $query->andWhere(['siteId' => $siteId]);
        }
        $stats = $query->all();
        if ($stats) {
            $data = $stats[0];
        }

        return $data;
    }