RecommendationsController::actionList() - Code Metrics - Inspection of "Updated assets build" - nystudio107/craft-webperf - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v1 ( 06dc74...d9854b )

by Andrew

created 2019-01-28 06:27 UTC

RecommendationsController::actionList() A

↳ Parent: RecommendationsController

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	15
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	4

<?php
/**
 * Webperf plugin for Craft CMS 3.x
 *
 * Monitor the performance of your webpages through real-world user timing data
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2019 nystudio107

 */


namespace nystudio107\webperf\controllers;

use nystudio107\webperf\helpers\Permission as PermissionHelper;

use nystudio107\webperf\models\RecommendationDataSample;

use craft\web\Controller;
filter:
    dependency_paths: ["lib/*"]

use nystudio107\webperf\Webperf;
use yii\web\ForbiddenHttpException;
filter:
    dependency_paths: ["lib/*"]
use yii\web\Response;
filter:
    dependency_paths: ["lib/*"]

/**

 * @author    nystudio107

 * @package   Webperf

 * @since     1.0.0

 */

class RecommendationsController extends Controller
{
    // Constants
    // =========================================================================

    // Protected Properties
    // =========================================================================

    /**

     * @var    bool|array

     */
    protected $allowAnonymous = [];

    // Public Methods
    // =========================================================================

    /**
     * Return a list of recommendations
     *
     * @param string $pageUrl

     * @param string $start

     * @param string $end

     * @param int    $siteId

     *
     * @return Response
     * @throws ForbiddenHttpException
     */
    public function actionList(
        $pageUrl = '',
        string $start = '',
        string $end = '',
        $siteId = 0
    ): Response {
        PermissionHelper::controllerPermissionCheck('webperf:recommendations');
        $data = [];
        $stats = Webperf::$plugin->recommendations->data($pageUrl, $start, $end, $siteId);
        if (!empty($stats)) {
            $recSample = new RecommendationDataSample($stats);
            $data = Webperf::$plugin->recommendations->list($recSample);
        }

        return $this->asJson($data);
    }

    // Protected Methods
    // =========================================================================
}


1			<?php
2			/**
3			* Webperf plugin for Craft CMS 3.x
4			*
5			* Monitor the performance of your webpages through real-world user timing data
6			*
7			* @link https://nystudio107.com
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) 2019 nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			namespace nystudio107\webperf\controllers;
12
13			use nystudio107\webperf\helpers\Permission as PermissionHelper;
14
15			use nystudio107\webperf\models\RecommendationDataSample;
16
17			use craft\web\Controller;
			0 ignored issues – show Bug introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report The type `craft\web\Controller` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
18
19			use nystudio107\webperf\Webperf;
20			use yii\web\ForbiddenHttpException;
			0 ignored issues – show Bug introduced 2019-01-27 17:07 UTC by Report Bug Copy Issue Report The type `yii\web\ForbiddenHttpException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
21			use yii\web\Response;
			0 ignored issues – show Bug introduced 2019-01-27 17:07 UTC by Report Bug Copy Issue Report The type `yii\web\Response` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
22
23			/**
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
24			* @author nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @package tag Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Content of the @author tag must be in the form "Display Name <[email protected]>" Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 2 spaces but found 4 Loading history...
25			* @package Webperf
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 1 spaces but found 3 Loading history...
26			* @since 1.0.0
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report The tag in position 3 should be the @author tag Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 3 spaces but found 5 Loading history...
27			*/
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
28			class RecommendationsController extends Controller
29			{
30			// Constants
31			// =========================================================================
32
33			// Protected Properties
34			// =========================================================================
35
36			/**
			0 ignored issues – show Coding Style introduced 2019-01-15 22:40 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
37			* @var bool\|array
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 1 spaces but found 4 Loading history...
38			*/
39			protected $allowAnonymous = [];
40
41			// Public Methods
42			// =========================================================================
43
44			/**
45			* Return a list of recommendations
46			*
47			* @param string $pageUrl
			0 ignored issues – show Coding Style introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
48			* @param string $start
			0 ignored issues – show Coding Style introduced 2019-01-23 06:22 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
49			* @param string $end
			0 ignored issues – show Coding Style introduced 2019-01-23 06:22 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
50			* @param int $siteId
			0 ignored issues – show Coding Style introduced 2019-01-19 05:19 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
51			*
52			* @return Response
53			* @throws ForbiddenHttpException
54			*/
55			public function actionList(
56			$pageUrl = '',
57			string $start = '',
58			string $end = '',
59			$siteId = 0
60			): Response {
61			PermissionHelper::controllerPermissionCheck('webperf:recommendations');
62			$data = [];
63			$stats = Webperf::$plugin->recommendations->data($pageUrl, $start, $end, $siteId);
64			if (!empty($stats)) {
65			$recSample = new RecommendationDataSample($stats);
66			$data = Webperf::$plugin->recommendations->list($recSample);
67			}
68
69			return $this->asJson($data);
70			}
71
72			// Protected Methods
73			// =========================================================================
74			}
75

nystudio107 / craft-webperf

Push — v1 ( 06dc74...d9854b )

RecommendationsController::actionList() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like