nystudio107 /
craft-webperf
| Conditions | 9 |
| Paths | 120 |
| Total Lines | 62 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 137 | public function actionRedirects( |
||
| 138 | string $sort = 'hitCount|desc', |
||
| 139 | int $page = 1, |
||
| 140 | int $per_page = 20, |
||
| 141 | $filter = '', |
||
| 142 | $siteId = 0 |
||
| 143 | ): Response { |
||
| 144 | PermissionHelper::controllerPermissionCheck('webperf:redirects'); |
||
| 145 | $data = []; |
||
| 146 | $sortField = 'hitCount'; |
||
| 147 | $sortType = 'DESC'; |
||
| 148 | // Figure out the sorting type |
||
| 149 | if ($sort !== '') { |
||
| 150 | if (strpos($sort, '|') === false) { |
||
| 151 | $sortField = $sort; |
||
| 152 | } else { |
||
| 153 | list($sortField, $sortType) = explode('|', $sort); |
||
| 154 | } |
||
| 155 | } |
||
| 156 | // Query the db table |
||
| 157 | $offset = ($page - 1) * $per_page; |
||
| 158 | $query = (new Query()) |
||
| 159 | ->from(['{{%retour_static_redirects}}']) |
||
| 160 | ->offset($offset) |
||
| 161 | ->limit($per_page) |
||
| 162 | ->orderBy("{$sortField} {$sortType}"); |
||
| 163 | if ((int)$siteId !== 0) { |
||
| 164 | $query->where(['siteId' => $siteId]); |
||
| 165 | } |
||
| 166 | if ($filter !== '') { |
||
| 167 | $query->where(['like', 'redirectSrcUrl', $filter]); |
||
| 168 | $query->orWhere(['like', 'redirectDestUrl', $filter]); |
||
| 169 | } |
||
| 170 | $redirects = $query->all(); |
||
| 171 | // Add in the `deleteLink` field |
||
| 172 | foreach ($redirects as &$redirect) { |
||
| 173 | $redirect['deleteLink'] = UrlHelper::cpUrl('retour/delete-redirect/'.$redirect['id']); |
||
| 174 | $redirect['editLink'] = UrlHelper::cpUrl('retour/edit-redirect/'.$redirect['id']); |
||
| 175 | } |
||
| 176 | // Format the data for the API |
||
| 177 | if ($redirects) { |
||
| 178 | $data['data'] = $redirects; |
||
| 179 | $query = (new Query()) |
||
| 180 | ->from(['{{%retour_static_redirects}}']); |
||
| 181 | if ($filter !== '') { |
||
| 182 | $query->where(['like', 'redirectSrcUrl', $filter]); |
||
| 183 | $query->orWhere(['like', 'redirectDestUrl', $filter]); |
||
| 184 | } |
||
| 185 | $count = $query->count(); |
||
| 186 | $data['links']['pagination'] = [ |
||
| 187 | 'total' => $count, |
||
| 188 | 'per_page' => $per_page, |
||
| 189 | 'current_page' => $page, |
||
| 190 | 'last_page' => ceil($count / $per_page), |
||
| 191 | 'next_page_url' => null, |
||
| 192 | 'prev_page_url' => null, |
||
| 193 | 'from' => $offset + 1, |
||
| 194 | 'to' => $offset + ($count > $per_page ? $per_page : $count), |
||
| 195 | ]; |
||
| 196 | } |
||
| 197 | |||
| 198 | return $this->asJson($data); |
||
| 199 | } |
||
| 204 |
Loading history...