Recommendations::addDataSample() - Code Metrics - Inspection of "Add recommendations framework" - nystudio107/craft-webperf - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 4f21d7...669183 )

by Andrew

created 2019-01-28 04:35 UTC

Recommendations::addDataSample() B

↳ Parent: Project

Complexity

Conditions	8
Paths	37

Size

Total Lines	63
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	42
nc	37
nop	1
dl	0
loc	63
rs	8.0035
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Webperf plugin for Craft CMS 3.x
 *
 * Monitor the performance of your webpages through real-world user timing data
 *
 * @link      https://nystudio107.com

 * @copyright Copyright (c) 2019 nystudio107

 */


namespace nystudio107\webperf\services;

use nystudio107\webperf\base\Recommendation;
use nystudio107\webperf\models\RecommendationDataSample;
use nystudio107\webperf\recommendations\MemoryLimit;

use Craft;
filter:
    dependency_paths: ["lib/*"]
use craft\base\Component;
filter:
    dependency_paths: ["lib/*"]
use craft\db\Query;
filter:
    dependency_paths: ["lib/*"]

/**

 * @author    nystudio107

 * @package   Webperf

 * @since     1.0.0

 */

class Recommendations extends Component
{
    // Constants
    // =========================================================================

    const RECOMMENDATIONS_LIST = [
        MemoryLimit::class,
    ];

    // Public Methods
    // =========================================================================

    /**
     * Return a list of recommendations
     *
     * @param RecommendationDataSample $sample

     *
     * @return array
     */
    public function list(RecommendationDataSample $sample): array
    {
        $data = [];
        foreach (self::RECOMMENDATIONS_LIST as $recClass) {
            /** @var Recommendation $rec */

            $rec = new $recClass(['sample' => $sample]);
            if ($rec->recommendation()) {
                $data[] = [
                    'summary' => $rec->summary(),
                    'detail' => $rec->detail(),
                    'learnMoreLink' => $rec->learnMoreLink(),
                ];
            }
        }
        return $data;
    }

    /**
     * Return a list of recommendations
     *
     * @param string $pageUrl

     * @param string $start

     * @param string $end

     * @param int    $siteId

     *
     * @return array
     */
    public function data(
        $pageUrl = '',
        string $start = '',
        string $end = '',
        $siteId = 0
    ): array {
        $data = [];
        // Add a day since YYYY-MM-DD is really YYYY-MM-DD 00:00:00
        $end = date('Y-m-d', strtotime($end.'+1 day'));
        $pageUrl = urldecode($pageUrl);
        // Query the db table
        $query = (new Query())
            ->select([

                'COUNT(url) AS cnt',

                'AVG(pageLoad) AS pageLoad',
                'AVG(domInteractive) AS domInteractive',
                'AVG(firstContentfulPaint) AS firstContentfulPaint',
                'AVG(firstPaint) AS firstPaint',
                'AVG(firstByte) AS firstByte',
                'AVG(connect) AS connect',
                'AVG(dns) AS dns',

                'AVG(craftTotalMs) AS craftTotalMs',
                'AVG(craftDbMs) AS craftDbMs',
                'AVG(craftDbCnt) AS craftDbCnt',
                'AVG(craftTwigMs) AS craftTwigMs',
                'AVG(craftTwigCnt) AS craftTwigCnt',
                'AVG(craftOtherMs) AS craftOtherMs',
                'AVG(craftOtherCnt) AS craftOtherCnt',
                'AVG(craftTotalMemory) AS craftTotalMemory',
            ])
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
            ->from(['{{%webperf_data_samples}}'])
            ->where(['between', 'dateCreated', $start, $end])

        ;
        if (!empty($pageUrl)) {
            $query->andWhere(['url' => $pageUrl]);
        }
        if ((int)$siteId !== 0) {
            $query->andWhere(['siteId' => $siteId]);
        }
        $stats = $query->all();
        if ($stats) {
            $data = $stats[0];
        }

        return $data;
    }
}


1			<?php
2			/**
3			* Webperf plugin for Craft CMS 3.x
4			*
5			* Monitor the performance of your webpages through real-world user timing data
6			*
7			* @link https://nystudio107.com
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) 2019 nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			namespace nystudio107\webperf\services;
12
13			use nystudio107\webperf\base\Recommendation;
14			use nystudio107\webperf\models\RecommendationDataSample;
15			use nystudio107\webperf\recommendations\MemoryLimit;
16
17			use Craft;
			0 ignored issues – show Bug introduced 2019-01-08 04:06 UTC by Report Bug Copy Issue Report The type `Craft` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
18			use craft\base\Component;
			0 ignored issues – show Bug introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report The type `craft\base\Component` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
19			use craft\db\Query;
			0 ignored issues – show Bug introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report The type `craft\db\Query` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
20
21			/**
			0 ignored issues – show Coding Style introduced 2019-01-02 04:37 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
22			* @author nystudio107
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @package tag Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Content of the @author tag must be in the form "Display Name <[email protected]>" Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 2 spaces but found 4 Loading history...
23			* @package Webperf
			0 ignored issues – show Coding Style introduced 2019-01-02 04:37 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 1 spaces but found 3 Loading history...
24			* @since 1.0.0
			0 ignored issues – show Coding Style introduced 2019-01-14 00:59 UTC by Report Bug Copy Issue Report The tag in position 3 should be the @author tag Loading history... Coding Style introduced 2019-01-14 00:59 UTC by Report Bug Copy Issue Report Tag value indented incorrectly; expected 3 spaces but found 5 Loading history...
25			*/
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
26			class Recommendations extends Component
27			{
28			// Constants
29			// =========================================================================
30
31			const RECOMMENDATIONS_LIST = [
32			MemoryLimit::class,
33			];
34
35			// Public Methods
36			// =========================================================================
37
38			/**
39			* Return a list of recommendations
40			*
41			* @param RecommendationDataSample $sample
			0 ignored issues – show Coding Style introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
42			*
43			* @return array
44			*/
45			public function list(RecommendationDataSample $sample): array
46			{
47			$data = [];
48			foreach (self::RECOMMENDATIONS_LIST as $recClass) {
49			/** @var Recommendation $rec */
			0 ignored issues – show Coding Style introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report The open comment tag must be the only content on the line Loading history... Coding Style introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history... Coding Style introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report The close comment tag must be the only content on the line Loading history...
50			$rec = new $recClass(['sample' => $sample]);
51			if ($rec->recommendation()) {
52			$data[] = [
53			'summary' => $rec->summary(),
54			'detail' => $rec->detail(),
55			'learnMoreLink' => $rec->learnMoreLink(),
56			];
57			}
58			}
59			return $data;
60			}
61
62			/**
63			* Return a list of recommendations
64			*
65			* @param string $pageUrl
			0 ignored issues – show Coding Style introduced 2019-01-28 04:39 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
66			* @param string $start
			0 ignored issues – show Coding Style introduced 2019-01-23 06:22 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
67			* @param string $end
			0 ignored issues – show Coding Style introduced 2019-01-23 06:22 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
68			* @param int $siteId
			0 ignored issues – show Coding Style introduced 2019-01-22 06:21 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
69			*
70			* @return array
71			*/
72			public function data(
73			$pageUrl = '',
74			string $start = '',
75			string $end = '',
76			$siteId = 0
77			): array {
78			$data = [];
79			// Add a day since YYYY-MM-DD is really YYYY-MM-DD 00:00:00
80			$end = date('Y-m-d', strtotime($end.'+1 day'));
81			$pageUrl = urldecode($pageUrl);
82			// Query the db table
83			$query = (new Query())
84			->select([
			0 ignored issues – show Coding Style introduced 2019-01-19 05:19 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
85			'COUNT(url) AS cnt',
86
87			'AVG(pageLoad) AS pageLoad',
88			'AVG(domInteractive) AS domInteractive',
89			'AVG(firstContentfulPaint) AS firstContentfulPaint',
90			'AVG(firstPaint) AS firstPaint',
91			'AVG(firstByte) AS firstByte',
92			'AVG(connect) AS connect',
93			'AVG(dns) AS dns',
94
95			'AVG(craftTotalMs) AS craftTotalMs',
96			'AVG(craftDbMs) AS craftDbMs',
97			'AVG(craftDbCnt) AS craftDbCnt',
98			'AVG(craftTwigMs) AS craftTwigMs',
99			'AVG(craftTwigCnt) AS craftTwigCnt',
100			'AVG(craftOtherMs) AS craftOtherMs',
101			'AVG(craftOtherCnt) AS craftOtherCnt',
102			'AVG(craftTotalMemory) AS craftTotalMemory',
103			])
			0 ignored issues – show Coding Style introduced 2019-01-19 05:19 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
104			->from(['{{%webperf_data_samples}}'])
105			->where(['between', 'dateCreated', $start, $end])
			0 ignored issues – show Coding Style introduced 2019-01-27 17:08 UTC by Report Bug Copy Issue Report Space after closing parenthesis of function call prohibited Loading history...
106			;
107			if (!empty($pageUrl)) {
108			$query->andWhere(['url' => $pageUrl]);
109			}
110			if ((int)$siteId !== 0) {
111			$query->andWhere(['siteId' => $siteId]);
112			}
113			$stats = $query->all();
114			if ($stats) {
115			$data = $stats[0];
116			}
117
118			return $data;
119			}
120			}
121

nystudio107 / craft-webperf

Push — develop ( 4f21d7...669183 )

Recommendations::addDataSample() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like