nystudio107\transcoder\services\Transcode::getAudioUrl()

Complexity

Conditions	14
Paths	436

Size

Total Lines	100
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getAudioUrl($filePath, $audioOptions): string
    {
        $result = '';
        $settings = Transcoder::$plugin->getSettings();
		$subfolder = '';

Line indented incorrectly; expected at least 8 spaces, found 2

		// sub folder check

Line indented incorrectly; expected at least 8 spaces, found 2

		if(\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {

Line indented incorrectly; expected 8 spaces, found 2

Expected "if (...) {\n"; found "if(...) {\n"

			$subfolder = $filePath->folderPath;

Line indented incorrectly; expected at least 12 spaces, found 3

		}

Line indented incorrectly; expected 8 spaces, found 2

        $filePath = $this->getAssetPath($filePath);

        if (!empty($filePath)) {
            $destAudioPath = $this->localDestPath('audio', $subfolder);

It seems like $subfolder can also be of type null; however, parameter $subfolder of nystudio107\transcoder\services\Transcode::localDestPath() does only seem to accept string, maybe add an additional type check?

            $audioOptions = $this->coalesceOptions('defaultAudioOptions', $audioOptions);

            // Get the audio encoder presets to use
            $audioEncoders = $settings['audioEncoders'];
            $thisEncoder = $audioEncoders[$audioOptions['audioEncoder']];

            $audioOptions['fileSuffix'] = $thisEncoder['fileSuffix'];

            // Build the basic command for ffmpeg
            $ffmpegCmd = $settings['ffmpegPath']
                .' -i '.escapeshellarg($filePath)
                .' -acodec '.$thisEncoder['audioCodec']
                .' '.$thisEncoder['audioCodecOptions']
                .' -bufsize 1000k'
                .' -threads '.$thisEncoder['threads'];

            // Set the bitrate if desired
            if (!empty($audioOptions['audioBitRate'])) {
                $ffmpegCmd .= ' -b:a '.$audioOptions['audioBitRate'];
            }
            // Set the sample rate if desired
            if (!empty($audioOptions['audioSampleRate'])) {
                $ffmpegCmd .= ' -ar '.$audioOptions['audioSampleRate'];
            }
            // Set the audio channels if desired
            if (!empty($audioOptions['audioChannels'])) {
                $ffmpegCmd .= ' -ac '.$audioOptions['audioChannels'];
            }
            $ffmpegCmd .= ' '.$thisEncoder['audioCodecOptions'];


            // Create the directory if it isn't there already
            if (!is_dir($destAudioPath)) {
                try {
                    FileHelper::createDirectory($destAudioPath);
                } catch (Exception $e) {
                    Craft::error($e->getMessage(), __METHOD__);
                }
            }

            $destAudioFile = $this->getFilename($filePath, $audioOptions);

            // File to store the audio encoding progress in
            $progressFile = sys_get_temp_dir().DIRECTORY_SEPARATOR.$destAudioFile.'.progress';

            // Assemble the destination path and final ffmpeg command
            $destAudioPath .= $destAudioFile;
            $ffmpegCmd .= ' -f '
                .$thisEncoder['fileFormat']
                .' -y '.escapeshellarg($destAudioPath)
                .' 1> '.$progressFile.' 2>&1 & echo $!';

            // Make sure there isn't a lockfile for this audio file already
            $lockFile = sys_get_temp_dir().DIRECTORY_SEPARATOR.$destAudioFile.'.lock';
            $oldPid = @file_get_contents($lockFile);
            if ($oldPid !== false) {
                exec("ps $oldPid", $ProcessState);
                if (\count($ProcessState) >= 2) {
                    return $result;
                }
                // It's finished transcoding, so delete the lockfile and progress file
                @unlink($lockFile);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

                @unlink($progressFile);
            }

            // If the audio file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
            if ($this->shouldGenerateAsset('audio', $destAudioPath, $filePath)) {
                $url = $settings['transcoderUrls']['audio'] . $subfolder ?? $settings['transcoderUrls']['default'];
                $result = Craft::getAlias($url).$destAudioFile;
            } else {
                // Kick off the transcoding
                $pid = $this->executeShellCommand($ffmpegCmd);
                Craft::info($ffmpegCmd."\nffmpeg PID: ".$pid, __METHOD__);

                // Create a lockfile in tmp
                file_put_contents($lockFile, $pid);
            }
        }

        if ($remoteUrl = $this->moveAssetToVolume('audio', $destAudioPath)) {

The variable $destAudioPath does not seem to be defined for all execution paths leading up to this point.

            $result = $remoteUrl;
        }

        return $result;
    }