nystudio107\transcoder\services\Transcode::getAudioUrl()

Complexity

Conditions	18
Paths	1922

Size

Total Lines	113
Code Lines	64

Duplication

Lines	0
Ratio	0 %

Importance

Changes	9
Bugs	0	Features	0

<?php
    public function getAudioUrl($filePath, $audioOptions): string
    {
        $result = '';
        $settings = Transcoder::$plugin->getSettings();
        $subfolder = '';

        // sub folder check
        if (\is_object($filePath) && ($filePath instanceof Asset) && $settings['createSubfolders']) {
            $subfolder = $filePath->folderPath;
        }

        $filePath = $this->getAssetPath($filePath);

        if (!empty($filePath)) {
            $destAudioPath = $settings['transcoderPaths']['audio'].$subfolder ?? $settings['transcoderPaths']['default'];
            $destAudioPath = Craft::getAlias($destAudioPath);

            $audioOptions = $this->coalesceOptions('defaultAudioOptions', $audioOptions);

            // Get the audio encoder presets to use
            $audioEncoders = $settings['audioEncoders'];
            $thisEncoder = $audioEncoders[$audioOptions['audioEncoder']];

            $audioOptions['fileSuffix'] = $thisEncoder['fileSuffix'];

            // Build the basic command for ffmpeg
            $ffmpegCmd = $settings['ffmpegPath']
                .' -i '.escapeshellarg($filePath)
                .' -acodec '.$thisEncoder['audioCodec']
                .' '.$thisEncoder['audioCodecOptions']
                .' -bufsize 1000k'
                .' -threads '.$thisEncoder['threads'];

            // Set the bitrate if desired
            if (!empty($audioOptions['audioBitRate'])) {
                $ffmpegCmd .= ' -b:a '.$audioOptions['audioBitRate'];
            }
            // Set the sample rate if desired
            if (!empty($audioOptions['audioSampleRate'])) {
                $ffmpegCmd .= ' -ar '.$audioOptions['audioSampleRate'];
            }
            // Set the audio channels if desired
            if (!empty($audioOptions['audioChannels'])) {
                $ffmpegCmd .= ' -ac '.$audioOptions['audioChannels'];
            }
            $ffmpegCmd .= ' '.$thisEncoder['audioCodecOptions'];

            if (!empty($audioOptions['timeInSecs'])) {
                $ffmpegCmd .= ' -t '.$audioOptions['timeInSecs'];
            }

            // Create the directory if it isn't there already
            if (!is_dir($destAudioPath)) {
                try {
                    FileHelper::createDirectory($destAudioPath);
                } catch (Exception $e) {
                    Craft::error($e->getMessage(), __METHOD__);
                }
            }

            $destAudioFile = $this->getFilename($filePath, $audioOptions);

            // File to store the audio encoding progress in
            $progressFile = sys_get_temp_dir().DIRECTORY_SEPARATOR.$destAudioFile.'.progress';

            // Assemble the destination path and final ffmpeg command
            $destAudioPath .= $destAudioFile;
            
            if ($audioOptions['stripMetadata']) {
                $ffmpegCmd .= ' -map_metadata -1 ';
            }
            
            $ffmpegCmd .= ' -f '
                .$thisEncoder['fileFormat']
                .' -y '.escapeshellarg($destAudioPath);
            
            if (!$audioOptions['synchronous']) {
                $ffmpegCmd .=' 1> '.$progressFile.' 2>&1 & echo $!';
                // Make sure there isn't a lockfile for this audio file already
                $lockFile = sys_get_temp_dir().DIRECTORY_SEPARATOR.$destAudioFile.'.lock';
                $oldPid = @file_get_contents($lockFile);
                if ($oldPid !== false) {
                    exec("ps $oldPid", $ProcessState);
                    if (\count($ProcessState) >= 2) {
                        return $result;
                    }
                    // It's finished transcoding, so delete the lockfile and progress file
                    @unlink($lockFile);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

                    @unlink($progressFile);
                }
            }

            // If the audio file already exists and hasn't been modified, return it.  Otherwise, start it transcoding
            if (file_exists($destAudioPath) && (@filemtime($destAudioPath) >= @filemtime($filePath))) {
                $url = $settings['transcoderUrls']['audio'].$subfolder ?? $settings['transcoderUrls']['default'];
                $result = Craft::getAlias($url).$destAudioFile;
            } else {
                // Kick off the transcoding
                $this->executeShellCommand($ffmpegCmd);
                
                if ($audioOptions['synchronous']) {
                    Craft::info($ffmpegCmd, __METHOD__);
                    $url = $settings['transcoderUrls']['audio'] . $subfolder ?? $settings['transcoderUrls']['default'];
                    $result = Craft::getAlias($url).$destAudioFile;
                } else {
                    Craft::info($ffmpegCmd."\nffmpeg PID: ".$pid, __METHOD__);

The variable $pid seems to be never defined.

                    // Create a lockfile in tmp
                    file_put_contents($lockFile, $pid);

The variable $lockFile does not seem to be defined for all execution paths leading up to this point.

                }
            }
        }

        return $result;
    }