nystudio107\transcoder\services\Transcode::getAssetPath()

Complexity

Conditions	10
Paths	63

Size

Total Lines	47
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

<?php
    protected function getAssetPath(Asset|string $filePath): string
    {
        // If we're passed an Asset, extract the path from it
        if (($filePath instanceof Asset)) {
            $asset = $filePath;
            $assetVolume = null;

The assignment to $assetVolume is dead and can be removed.

            try {
                $assetVolume = $asset->getVolume();
            } catch (InvalidConfigException $e) {
                Craft::error($e->getMessage(), __METHOD__);
            }

            if ($assetVolume) {
                // If it's local, get a path to the file
                $fs = $assetVolume->getFs();
                if ($fs instanceof Local) {
                    $sourcePath = rtrim($fs->path, DIRECTORY_SEPARATOR);

It seems like $fs->path can also be of type null; however, parameter $string of rtrim() does only seem to accept string, maybe add an additional type check?

                    $sourcePath .= '' === $sourcePath ? '' : DIRECTORY_SEPARATOR;
                    $folderPath = '';

The assignment to $folderPath is dead and can be removed.

                    try {
                        $folderPath = rtrim($asset->getFolder()->path, DIRECTORY_SEPARATOR);
                    } catch (InvalidConfigException $e) {
                        Craft::error($e->getMessage(), __METHOD__);
                    }
                    $folderPath .= '' === $folderPath ? '' : DIRECTORY_SEPARATOR;

                    $filePath = $sourcePath . $folderPath . $asset->filename;
                } else {
                    // Otherwise, get a URL
                    $filePath = $asset->getUrl() ?? '';
                }
            }
        }

        $filePath = (string)App::parseEnv($filePath);

        // Make sure that $filePath is either an existing file, or a valid URL
        if (!file_exists($filePath)) {
            $validator = new UrlValidator();
            $error = '';
            if (!$validator->validate($filePath, $error)) {
                Craft::error($error, __METHOD__);
                $filePath = '';
            }
        }

        return $filePath;
    }