TemplateCommentsParser::addImportedSymbol() - Code Metrics - Inspection of "Merge branch 'release/5.0.2' into v5" - nystudio107/craft-templatecomments - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v5 ( c5e113...41d382 )

by Andrew

created 2024-09-03 20:36 UTC

TemplateCommentsParser::addImportedSymbol() A

↳ Parent: TemplateCommentsParser

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	4
dl	0
loc	3
rs	10

<?php
/**
 * Template Comments plugin for Craft CMS
 *
 * Adds a HTML comment to demarcate each Twig template that is included or extended.
 *
 * @link      https://nystudio107.com/

 * @copyright Copyright (c)  nystudio107

 */


/**
 * This is a wholesale copy pasta of the Twig Parser class; with one modification so that it
 * does not throw a "A block definition cannot be nested under non-capturing nodes" SyntaxError exception
 *
 * This exception is explained in detail here: https://github.com/twigphp/Twig/issues/3926
 *
 * So that Template Comments can add HTML comments that indicate any {% include %} or {% extends %} templates
 * with execution timing, it uses its own CommentTemplateLoader which wraps the loaded template
 * with {% comments 'templateName' %}<loaded-template>{% endcomments %}
 *
 * There is a corresponding CommentsTokenParser that takes care of parsing the {% comments %} tags
 *
 * This worked in Twig 1.x and 2.x, but they added a check for block definitions nested under non-capturing
 * blocks in Twig 3.x, which causes it to throw an exception in that case. So if you end up with something like:
 *
 * {% comments 'index' %}
 *     {% block conent %}
 *     {% endblock %}
 * {% encomments %}
 *
 * ...the SyntaxError exception will be thrown.
 *
 * I tried adding implements NodeCaptureInterface to the CommentsNode but that resulted in the Parser returning
 * the node, causing duplicate rendering for every {% include %} or {% extends %} that was wrapped in a
 * {% comments %} tag
 *
 * We can't just subclass the Parser class, because the properties and methods are private
 *
 * So here we are.
 *
 * Don't judge me
 */

namespace nystudio107\templatecomments\web\twig;

use nystudio107\templatecomments\helpers\Reflection as ReflectionHelper;
use ReflectionException;
use Twig\Environment;
use Twig\Error\SyntaxError;
use Twig\ExpressionParser;
filter:
    dependency_paths: ["lib/*"]
use Twig\Node\BlockNode;
use Twig\Node\BlockReferenceNode;
use Twig\Node\BodyNode;
use Twig\Node\Expression\AbstractExpression;
use Twig\Node\MacroNode;
use Twig\Node\ModuleNode;
use Twig\Node\Node;
use Twig\Node\NodeCaptureInterface;
use Twig\Node\NodeOutputInterface;
use Twig\Node\PrintNode;
use Twig\Node\TextNode;
use Twig\NodeTraverser;
use Twig\Parser;
use Twig\Token;
use Twig\TokenParser\TokenParserInterface;
use Twig\TokenStream;
use function chr;
use function count;
use function get_class;
use function is_array;

/**

 * @author Fabien Potencier <[email protected]>
 */

class TemplateCommentsParser extends Parser
{
    private $stack = [];

    private $stream;

    private $parent;

    private $visitors;

    private $expressionParser;

    private $blocks;

    private $blockStack;

    private $macros;

    private $env;

    private $importedSymbols;

    private $traits;

    private $embeddedTemplates = [];

    private $varNameSalt = 0;

    private $expressionParserClass;


    public function __construct(Environment $env)

    {
        $this->env = $env;
        $this->expressionParserClass = ExpressionParser::class;
        // Get the existing parser object used by the Twig $env
        try {
            $parserReflection = ReflectionHelper::getReflectionProperty($env, 'parser');
        } catch (ReflectionException $e) {
            return;
        }
        $parserReflection->setAccessible(true);
        $parser = $parserReflection->getValue($env);
        if ($parser === null) {
            return;
        }
        // Get the expression parser used by the current parser
        try {
            $expressionParserReflection = ReflectionHelper::getReflectionProperty($parser, 'expressionParser');
        } catch (ReflectionException $e) {
            return;
        }
        // Preserve the existing expression parser and use it
        $expressionParserReflection->setAccessible(true);
        $expressionParser = $expressionParserReflection->getValue($parser);
        $this->expressionParserClass = get_class($expressionParser);
    }

    public function getVarName(): string

    {
        return sprintf('__internal_parse_%d', $this->varNameSalt++);
    }

    public function parse(TokenStream $stream, $test = null, bool $dropNeedle = false): ModuleNode

    {
        $vars = get_object_vars($this);
        unset($vars['stack'], $vars['env'], $vars['handlers'], $vars['visitors'], $vars['expressionParser'], $vars['reservedMacroNames'], $vars['varNameSalt']);
        $this->stack[] = $vars;

        // node visitors
        if (null === $this->visitors) {
            $this->visitors = $this->env->getNodeVisitors();
        }

        if (null === $this->expressionParser) {
            $this->expressionParser = new $this->expressionParserClass($this, $this->env);
        }

        $this->stream = $stream;
        $this->parent = null;
        $this->blocks = [];
        $this->macros = [];
        $this->traits = [];
        $this->blockStack = [];
        $this->importedSymbols = [[]];
        $this->embeddedTemplates = [];

        try {
            $body = $this->subparse($test, $dropNeedle);

            if (null !== $this->parent && null === $body = $this->filterBodyNodes($body)) {
                $body = new Node();
            }
        } catch (SyntaxError $e) {
            if (!$e->getSourceContext()) {
                $e->setSourceContext($this->stream->getSourceContext());
            }

            if (!$e->getTemplateLine()) {
                $e->setTemplateLine($this->stream->getCurrent()->getLine());
            }

            throw $e;
        }

        $node = new ModuleNode(new BodyNode([$body]), $this->parent, new Node($this->blocks), new Node($this->macros), new Node($this->traits), $this->embeddedTemplates, $stream->getSourceContext());

        $traverser = new NodeTraverser($this->env, $this->visitors);

        /** @var ModuleNode $node */

        $node = $traverser->traverse($node);

        // restore previous stack so previous parse() call can resume working
        foreach (array_pop($this->stack) as $key => $val) {
            $this->$key = $val;
        }

        return $node;
    }

    public function subparse($test, bool $dropNeedle = false): Node

    {
        $lineno = $this->getCurrentToken()->getLine();
        $rv = [];
        while (!$this->stream->isEOF()) {
            switch ($this->getCurrentToken()->getType()) {
                case /* Token::TEXT_TYPE */ 0:

                    $token = $this->stream->next();
                    $rv[] = new TextNode($token->getValue(), $token->getLine());
                    break;

                case /* Token::VAR_START_TYPE */ 2:

                    $token = $this->stream->next();
                    $expr = $this->expressionParser->parseExpression();
                    $this->stream->expect(/* Token::VAR_END_TYPE */ 4);
                    $rv[] = new PrintNode($expr, $token->getLine());
                    break;

                case /* Token::BLOCK_START_TYPE */ 1:

                    $this->stream->next();
                    $token = $this->getCurrentToken();

                    if (/* Token::NAME_TYPE */ 5 !== $token->getType()) {

                        throw new SyntaxError('A block must start with a tag name.', $token->getLine(), $this->stream->getSourceContext());
                    }


                    if (null !== $test && $test($token)) {

                        if ($dropNeedle) {

                            $this->stream->next();
                        }


                        if (1 === count($rv)) {

                            return $rv[0];
                        }


                        return new Node($rv, [], $lineno);
                    }


                    if (!$subparser = $this->env->getTokenParser($token->getValue())) {

                        if (null !== $test) {

                            $e = new SyntaxError(sprintf('Unexpected "%s" tag', $token->getValue()), $token->getLine(), $this->stream->getSourceContext());

                            if (is_array($test) && isset($test[0]) && $test[0] instanceof TokenParserInterface) {

                                $e->appendMessage(sprintf(' (expecting closing tag for the "%s" tag defined near line %s).', $test[0]->getTag(), $lineno));
                            }

                        } else {

                            $e = new SyntaxError(sprintf('Unknown "%s" tag.', $token->getValue()), $token->getLine(), $this->stream->getSourceContext());
                            $e->addSuggestions($token->getValue(), array_keys($this->env->getTokenParsers()));
                        }


                        throw $e;
                    }


                    $this->stream->next();

                    $subparser->setParser($this);
                    $node = $subparser->parse($token);
                    if (null !== $node) {

                        $rv[] = $node;
                    }

                    break;

                default:

                    throw new SyntaxError('Lexer or parser ended up in unsupported state.', $this->getCurrentToken()->getLine(), $this->stream->getSourceContext());
            }
        }

        if (1 === count($rv)) {
            return $rv[0];
        }

        return new Node($rv, [], $lineno);
    }

    public function getBlockStack(): array

    {
        return $this->blockStack;
    }

    public function peekBlockStack()

    {
        return $this->blockStack[count($this->blockStack) - 1] ?? null;
    }

    public function popBlockStack(): void

    {
        array_pop($this->blockStack);
    }

    public function pushBlockStack($name): void

    {
        $this->blockStack[] = $name;
    }

    public function hasBlock(string $name): bool

    {
        return isset($this->blocks[$name]);
    }

    public function getBlock(string $name): Node

    {
        return $this->blocks[$name];
    }

    public function setBlock(string $name, BlockNode $value): void

    {
        $this->blocks[$name] = new BodyNode([$value], [], $value->getTemplateLine());
    }

    public function hasMacro(string $name): bool

    {
        return isset($this->macros[$name]);
    }

    public function setMacro(string $name, MacroNode $node): void

    {
        $this->macros[$name] = $node;
    }

    public function addTrait($trait): void

    {
        $this->traits[] = $trait;
    }

    public function hasTraits(): bool

    {
        return count($this->traits) > 0;
    }

    public function embedTemplate(ModuleNode $template)

    {
        $template->setIndex(mt_rand());

        $this->embeddedTemplates[] = $template;
    }

    public function addImportedSymbol(string $type, string $alias, string $name = null, AbstractExpression $node = null): void

    {
        $this->importedSymbols[0][$type][$alias] = ['name' => $name, 'node' => $node];
    }

    public function getImportedSymbol(string $type, string $alias)

    {
        // if the symbol does not exist in the current scope (0), try in the main/global scope (last index)
        return $this->importedSymbols[0][$type][$alias] ?? ($this->importedSymbols[count($this->importedSymbols) - 1][$type][$alias] ?? null);
    }

    public function isMainScope(): bool

    {
        return 1 === count($this->importedSymbols);
    }

    public function pushLocalScope(): void

    {
        array_unshift($this->importedSymbols, []);
    }

    public function popLocalScope(): void

    {
        array_shift($this->importedSymbols);
    }

    public function getExpressionParser(): ExpressionParser

    {
        return $this->expressionParser;
    }

    public function getParent(): ?Node

    {
        return $this->parent;
    }

    public function setParent(?Node $parent): void

    {
        $this->parent = $parent;
    }

    public function hasInheritance()

    {
        return $this->parent || 0 < count($this->traits);
    }

    public function getStream(): TokenStream

    {
        return $this->stream;
    }

    public function getCurrentToken(): Token

    {
        return $this->stream->getCurrent();
    }

    private function filterBodyNodes(Node $node, bool $nested = false): ?Node

    {
        // check that the body does not contain non-empty output nodes
        if (

            ($node instanceof TextNode && !ctype_space($node->getAttribute('data')))

            || (!$node instanceof TextNode && !$node instanceof BlockReferenceNode && $node instanceof NodeOutputInterface)
        ) {
            if (str_contains((string)$node, chr(0xEF) . chr(0xBB) . chr(0xBF))) {
                $t = substr($node->getAttribute('data'), 3);
                if ('' === $t || ctype_space($t)) {
                    // bypass empty nodes starting with a BOM
                    return null;
                }
            }

            throw new SyntaxError('A template that extends another one cannot include content outside Twig blocks. Did you forget to put the content inside a {% block %} tag?', $node->getTemplateLine(), $this->stream->getSourceContext());
        }

        // bypass nodes that "capture" the output
        if ($node instanceof NodeCaptureInterface) {
            // a "block" tag in such a node will serve as a block definition AND be displayed in place as well
            return $node;
        }

        /**
         * We intentionally skip this check to avoid throwing an exception, so our {% comments %} tag can
         * render correctly
         * // "block" tags that are not captured (see above) are only used for defining
         * // the content of the block. In such a case, nesting it does not work as
         * // expected as the definition is not part of the default template code flow.
         * if ($nested && $node instanceof BlockReferenceNode) {
         * throw new SyntaxError('A block definition cannot be nested under non-capturing nodes.', $node->getTemplateLine(), $this->stream->getSourceContext());
         * }
         */
        if ($node instanceof NodeOutputInterface) {
            return null;
        }

        // here, $nested means "being at the root level of a child template"
        // we need to discard the wrapping "Node" for the "body" node
        $nested = $nested || Node::class !== get_class($node);
        foreach ($node as $k => $n) {
            if (null !== $n && null === $this->filterBodyNodes($n, $nested)) {
                $node->removeNode($k);
            }
        }

        return $node;
    }
}


1			<?php
2			/**
3			* Template Comments plugin for Craft CMS
4			*
5			* Adds a HTML comment to demarcate each Twig template that is included or extended.
6			*
7			* @link https://nystudio107.com/
			0 ignored issues – show Coding Style introduced 2018-10-02 16:17 UTC by Report Bug Copy Issue Report The tag in position 1 should be the @copyright tag Loading history...
8			* @copyright Copyright (c) nystudio107
			0 ignored issues – show Coding Style introduced 2018-10-02 16:17 UTC by Report Bug Copy Issue Report @copyright tag must contain a year and the name of the copyright holder Loading history...
9			*/
			0 ignored issues – show Coding Style introduced 2018-10-02 16:17 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2018-10-02 16:17 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2018-10-02 16:17 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2018-10-02 16:17 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2018-10-02 16:17 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history...
10
11			/**
12			* This is a wholesale copy pasta of the Twig Parser class; with one modification so that it
13			* does not throw a "A block definition cannot be nested under non-capturing nodes" SyntaxError exception
14			*
15			* This exception is explained in detail here: https://github.com/twigphp/Twig/issues/3926
16			*
17			* So that Template Comments can add HTML comments that indicate any {% include %} or {% extends %} templates
18			* with execution timing, it uses its own CommentTemplateLoader which wraps the loaded template
19			* with {% comments 'templateName' %}<loaded-template>{% endcomments %}
20			*
21			* There is a corresponding CommentsTokenParser that takes care of parsing the {% comments %} tags
22			*
23			* This worked in Twig 1.x and 2.x, but they added a check for block definitions nested under non-capturing
24			* blocks in Twig 3.x, which causes it to throw an exception in that case. So if you end up with something like:
25			*
26			* {% comments 'index' %}
27			* {% block conent %}
28			* {% endblock %}
29			* {% encomments %}
30			*
31			* ...the SyntaxError exception will be thrown.
32			*
33			* I tried adding implements NodeCaptureInterface to the CommentsNode but that resulted in the Parser returning
34			* the node, causing duplicate rendering for every {% include %} or {% extends %} that was wrapped in a
35			* {% comments %} tag
36			*
37			* We can't just subclass the Parser class, because the properties and methods are private

nystudio107 / craft-templatecomments

Push — v5 ( c5e113...41d382 )

TemplateCommentsParser::addImportedSymbol() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like