nystudio107\similar\services\Similar::find()

Complexity

Conditions	9
Paths	30

Size

Total Lines	64
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function find($data)
    {
        if (!isset($data['element'])) {
            throw new Exception('Required parameter `element` was not supplied to `craft.similar.find`.');
        }

        if (!isset($data['context'])) {
            throw new Exception('Required parameter `context` was not supplied to `craft.similar.find`.');
        }

        /** @var Element $element */
        $element = $data['element'];
        $context = $data['context'];
        $criteria = $data['criteria'] ?? [];
        if (\is_object($criteria)) {
            /** @var ElementQueryInterface $criteria */
            $criteria = $criteria->toArray();
        }

        // Get an ElementQuery for this Element
        $elementClass = \is_object($element) ? \get_class($element) : $element;
        /** @var EntryQuery $query */
        $query = $this->getElementQuery($elementClass, $criteria);

        // If the $query is null, just return an empty Entry
        if (!$query) { // no results

$query is of type craft\elements\db\EntryQuery, thus it always evaluated to true. If $query can have other possible types, add them to src/services/Similar.php:71

            return new Entry();
        }

        // Stash any orderBy directives from the $query for our anonymous function
        $this->preOrder = $query->orderBy;

        // Extract the $tagIds from the $context
        if (\is_array($context)) {
            $tagIds = $context;
        } else {
            /** @var ElementQueryInterface $context */
            $tagIds = $context->ids();
        }

        // We need to modify the actual craft\db\Query after the ElementQuery has been prepared
        $query->on(ElementQuery::EVENT_AFTER_PREPARE, [$this, 'eventAfterPrepareHandler']);
        // Return the data as an array, and only fetch the `id` and `siteId`
        $query->asArray(true);
        $query->select(['elements.id', 'elements_sites.siteId']);
        $query->andWhere('elements.id != :id', ['id' => $element->id]);
        $query->andWhere(['in', '{{%relations}}.targetId', $tagIds]);
        $query->leftJoin('{{%relations}}', 'elements.id={{%relations}}.sourceId');
        $results = $query->all();

        // Fetch the elements based on the returned `id` and `siteId`
        $elements = Craft::$app->getElements();
        $models = [];
        foreach ($results as $config) {
            $model = $elements->getElementById($config['id'], $elementClass, $config['siteId']);
            if ($model) {
                // The `count` property is added dynamically by our CountBehavior behavior
                /** @noinspection PhpUndefinedFieldInspection */
                $model->count = $config['count'];

Accessing count on the interface craft\base\ElementInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

                $models[] = $model;
            }
        }

        return $models;
    }