nystudio107\seomatic\controllers\ContentSeoController::actionMetaBundles()

Complexity

Conditions	20
Paths	324

Size

Total Lines	124
Code Lines	86

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

<?php
    public function actionMetaBundles(
        string $sort = 'sourceName|asc',
        int $page = 1,
        int $per_page = 20,
        $filter = '',
        $siteId = 0
    ): Response {
        $data = [];
        $sortField = 'sourceName';
        $sortType = 'ASC';
        $additionalSort = '';
        // Figure out the sorting type
        if ($sort !== '') {
            if (strpos($sort, '|') === false) {
                $sortField = $sort;
            } else {
                list($sortField, $sortType) = explode('|', $sort);
            }
        }
        if ($sortField !== 'sourceName') {
            $additionalSort = ', sourceName ASC';
        }
        // Query the db table
        $offset = ($page - 1) * $per_page;

        $query = (new Query())
            ->from(['{{%seomatic_metabundles}}'])
            ->offset($offset)
            ->limit($per_page)
            ->orderBy("{$sortField} {$sortType}".$additionalSort)
            ->where(['!=', 'sourceBundleType', Seomatic::$plugin->metaBundles::GLOBAL_META_BUNDLE])

Space after closing parenthesis of function call prohibited

            ;
        $currentSiteHandle = '';
        if ((int)$siteId !== 0) {
            $query->andWhere(['sourceSiteId' => $siteId]);
            $site = Craft::$app->getSites()->getSiteById($siteId);

It seems like $siteId can also be of type null; however, parameter $siteId of craft\services\Sites::getSiteById() does only seem to accept integer, maybe add an additional type check?

            if ($site !== null) {
                $currentSiteHandle = $site->handle;
            }
        }
        if ($filter !== '') {
            $query->andWhere(['like', 'sourceName', $filter]);
        }
        $bundles = $query->all();
        if ($bundles) {

The expression $bundles of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $dataArray = [];
            // Add in the `addLink` field
            foreach ($bundles as $bundle) {
                $dataItem = [];
                $metaBundle = MetaBundle::create($bundle);
                if ($metaBundle !== null) {
                    $sourceBundleType = $metaBundle->sourceBundleType;
                    $sourceHandle = $metaBundle->sourceHandle;
                    $dataItem['sourceName'] = $metaBundle->sourceName;
                    $dataItem['sourceType'] = $metaBundle->sourceType;
                    $dataItem['contentSeoUrl'] = UrlHelper::cpUrl(
                        "seomatic/edit-content/general/{$sourceBundleType}/{$sourceHandle}/{$currentSiteHandle}"
                    );
                    // Fill in the number of entries
                    $entries = 0;
                    $seoElement = Seomatic::$plugin->seoElements->getSeoElementByMetaBundleType(
                        $metaBundle->sourceBundleType
                    );
                    /** @var SeoElementInterface $seoElement */

The open comment tag must be the only content on the line

The close comment tag must be the only content on the line

                    if ($seoElement !== null) {
                        $query = $seoElement::sitemapElementsQuery($metaBundle);
                        $entries = $query->count();
                        Craft::error('shit: ' . print_r($entries, true), __METHOD__);
                    }
                    $dataItem['entries'] = $entries;
                    // Basic configuration setup
                    $dataItem['title'] = $metaBundle->metaGlobalVars->seoTitle !== '' ? 'enabled' : 'disabled';
                    $dataItem['description'] = $metaBundle->metaGlobalVars->seoDescription !== '' ? 'enabled' : 'disabled';
                    $dataItem['image'] = $metaBundle->metaGlobalVars->seoImage !== '' ? 'enabled' : 'disabled';
                    $dataItem['sitemap'] = $metaBundle->metaSitemapVars->sitemapUrls ? 'enabled' : 'disabled';
                    $dataItem['robots'] = $metaBundle->metaGlobalVars->robots;
                    // Calculate the setup stat
                    $stat = 0;
                    $numGrades = \count(SettingsController::SETUP_GRADES);
                    $numFields = \count(SettingsController::SEO_SETUP_FIELDS);
                    foreach (SettingsController::SEO_SETUP_FIELDS as $setupField => $setupLabel) {
                        $stat += (int)!empty($metaBundle->metaGlobalVars[$setupField]);
                        $value = $variables['contentSetupChecklist'][$setupField]['value'] ?? 0;
                        $variables['contentSetupChecklist'][$setupField] = [
                            'label' => $setupLabel,
                            'value' => $value + (int)!empty($metaBundle->metaGlobalVars[$setupField]),
                        ];
                    }
                    $stat = round($numGrades - (($stat * $numGrades) / $numFields));
                    if ($stat >= $numGrades) {
                        $stat = $numGrades - 1;
                    }
                    $dataItem['setup'] = SettingsController::SETUP_GRADES[$stat];

                    $dataArray[] = $dataItem;
                }
            }
            // Format the data for the API
            $data['data'] = $dataArray;
            $query = (new Query())
                ->from(['{{%seomatic_metabundles}}'])
                ->orderBy("{$sortField} {$sortType}")
                ->where(['!=', 'sourceBundleType', Seomatic::$plugin->metaBundles::GLOBAL_META_BUNDLE])

Space after closing parenthesis of function call prohibited

            ;
            if ((int)$siteId !== 0) {
                $query->andWhere(['sourceSiteId' => $siteId]);
            }
            if ($filter !== '') {
                $query->andWhere(['like', 'sourceName', $filter]);
            }
            $count = $query->count();
            $data['links']['pagination'] = [
                'total' => $count,
                'per_page' => $per_page,
                'current_page' => $page,
                'last_page' => ceil($count / $per_page),
                'next_page_url' => null,
                'prev_page_url' => null,
                'from' => $offset + 1,
                'to' => $offset + ($count > $per_page ? $per_page : $count),
            ];
        }

        return $this->asJson($data);
    }