nystudio107\seomatic\controllers\SettingsController::actionEditContent()

Complexity

Conditions	9
Paths	128

Size

Total Lines	123
Code Lines	83

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function actionEditContent(
        string $subSection,
        string $sourceBundleType,
        string $sourceHandle,
        string $siteHandle = null,
        $typeId = null,
        $loadFromSiteHandle = null
    ): Response {
        $variables = [];
        // @TODO: Let people choose an entry/categorygroup/product as the preview
        // Get the site to edit
        $siteId = $this->getSiteIdFromHandle($siteHandle);
        if ($typeId !== null && is_string($typeId)) {

The condition is_string($typeId) is always false.

            $typeId = (int)$typeId;
        }
        // Get the (entry) type menu
        $typeMenu = [];
        $seoElement = Seomatic::$plugin->seoElements->getSeoElementByMetaBundleType($sourceBundleType);
        if ($seoElement !== null) {
            $typeMenu = $seoElement::typeMenuFromHandle($sourceHandle);
        }
        $variables['typeMenu'] = $typeMenu;
        $variables['currentTypeId'] = null;
        if (!empty($typeMenu)) {
            $currentType = reset($typeMenu);
            $variables['currentType'] = $typeMenu[$typeId] ?? $currentType;
            $variables['currentTypeId'] = $typeId ?? key($typeMenu);
            $typeId = (int)$variables['currentTypeId'];
        }
        $pluginName = Seomatic::$settings->pluginName;
        // Asset bundle
        try {
            Seomatic::$view->registerAssetBundle(SeomaticAsset::class);
        } catch (InvalidConfigException $e) {
            Craft::error($e->getMessage(), __METHOD__);
        }
        $variables['baseAssetsUrl'] = Craft::$app->assetManager->getPublishedUrl(
            '@nystudio107/seomatic/assetbundles/seomatic/dist',
            true

The call to yii\web\AssetManager::getPublishedUrl() has too many arguments starting with true.

        );
        // Enabled sites
        $this->setMultiSiteVariables($siteHandle, $siteId, $variables);
        $this->cullDisabledSites($sourceBundleType, $sourceHandle, $variables);
        // Meta Bundle settings
        Seomatic::$previewingMetaContainers = true;
        // Get the site to copy the settings from, if any
        $variables['loadFromSiteHandle'] = $loadFromSiteHandle;
        $loadFromSiteId = $this->getSiteIdFromHandle($loadFromSiteHandle);
        $siteIdToLoad = $loadFromSiteHandle === null ? (int)$variables['currentSiteId'] : $loadFromSiteId;

The condition $loadFromSiteHandle === null is always true.

        // Load the metabundle
        $metaBundle = Seomatic::$plugin->metaBundles->getMetaBundleBySourceHandle(
            $sourceBundleType,
            $sourceHandle,
            $siteIdToLoad,
            $typeId
        );
        Seomatic::$previewingMetaContainers = false;
        $templateTitle = '';
        if ($metaBundle !== null) {
            $variables['metaGlobalVars'] = clone $metaBundle->metaGlobalVars;
            $variables['metaSitemapVars'] = $metaBundle->metaSitemapVars;
            $variables['metaBundleSettings'] = $metaBundle->metaBundleSettings;
            $variables['currentSourceHandle'] = $metaBundle->sourceHandle;
            $variables['currentSourceBundleType'] = $metaBundle->sourceBundleType;
            $templateTitle = $metaBundle->sourceName;
        }
        // Basic variables
        $subSectionTitle = Craft::t('seomatic', ucfirst($subSection));
        $variables['fullPageForm'] = true;
        $variables['docsUrl'] = self::DOCUMENTATION_URL;
        $variables['pluginName'] = Seomatic::$settings->pluginName;
        $variables['title'] = $templateTitle;
        $variables['subSectionTitle'] = $subSectionTitle;
        $variables['docTitle'] = "{$pluginName} - Content SEO - {$templateTitle} - {$subSectionTitle}";
        $siteHandleUri = Craft::$app->isMultiSite ? '/'.$siteHandle : '';
        $variables['siteHandleUri'] = $siteHandleUri;
        $variables['crumbs'] = [
            [
                'label' => $pluginName,
                'url' => UrlHelper::cpUrl('seomatic'),
            ],
            [
                'label' => 'Content SEO',
                'url' => UrlHelper::cpUrl('seomatic/content'.$siteHandleUri),
            ],
            [
                'label' => $metaBundle->sourceName.' · '.$subSectionTitle,
                'url' => UrlHelper::cpUrl("seomatic/edit-content/${subSection}/${sourceBundleType}/${sourceHandle}"),
            ],
        ];
        $variables['selectedSubnavItem'] = 'content';
        $variables['controllerHandle'] = "edit-content/${subSection}/${sourceBundleType}/${sourceHandle}";
        // Image selectors
        $variables['currentSubSection'] = $subSection;
        $bundleSettings = $metaBundle->metaBundleSettings;
        $variables['elementType'] = Asset::class;
        $variables['seoImageElements'] = ImageTransformHelper::assetElementsFromIds(
            $bundleSettings->seoImageIds,
            $siteId
        );
        $variables['twitterImageElements'] = ImageTransformHelper::assetElementsFromIds(
            $bundleSettings->twitterImageIds,
            $siteId
        );
        $variables['ogImageElements'] = ImageTransformHelper::assetElementsFromIds(
            $bundleSettings->ogImageIds,
            $siteId
        );
        $variables['sourceType'] = $metaBundle->sourceType;
        // Pass in the pull fields
        $groupName = ucfirst($metaBundle->sourceType);
        $this->setContentFieldSourceVariables($sourceBundleType, $sourceHandle, $groupName, $variables);
        $uri = $this->uriFromSourceBundle($sourceBundleType, $sourceHandle, $siteId);
        // Preview the meta containers
        Seomatic::$plugin->metaContainers->previewMetaContainers(
            $uri,
            (int)$variables['currentSiteId'],
            false,
            false
        );

        // Render the template
        return $this->renderTemplate('seomatic/settings/content/'.$subSection, $variables);
    }