Inspection of "Updated meta" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( e03220...4c5204 )

by Andrew

created 2021-08-30 17:10 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -222,15 +222,15 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
-        'endTime' => ['DateTime','Time'],
+        'agent' => ['Organization', 'Person'],
+        'endTime' => ['DateTime', 'Time'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text','VirtualLocation'],
+        'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
-        'startTime' => ['DateTime','Time'],
+        'startTime' => ['DateTime', 'Time'],
         'target' => ['EntryPoint']
     ];
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/EducationalOrganization.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Playground.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/PaintAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -222,15 +222,15 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
-        'endTime' => ['DateTime','Time'],
+        'agent' => ['Organization', 'Person'],
+        'endTime' => ['DateTime', 'Time'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text','VirtualLocation'],
+        'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
-        'startTime' => ['DateTime','Time'],
+        'startTime' => ['DateTime', 'Time'],
         'target' => ['EntryPoint']
     ];
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Course.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -172,11 +172,11 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'courseCode' => ['Text'],
-        'coursePrerequisites' => ['AlignmentObject','Course','Text'],
-        'educationalCredentialAwarded' => ['EducationalOccupationalCredential','Text','URL'],
+        'coursePrerequisites' => ['AlignmentObject', 'Course', 'Text'],
+        'educationalCredentialAwarded' => ['EducationalOccupationalCredential', 'Text', 'URL'],
         'hasCourseInstance' => ['CourseInstance'],
-        'numberOfCredits' => ['Integer','StructuredValue'],
-        'occupationalCredentialAwarded' => ['EducationalOccupationalCredential','Text','URL']
+        'numberOfCredits' => ['Integer', 'StructuredValue'],
+        'occupationalCredentialAwarded' => ['EducationalOccupationalCredential', 'Text', 'URL']
     ];
 
     /**
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['courseCode','coursePrerequisites','educationalCredentialAwarded','hasCourseInstance','numberOfCredits','occupationalCredentialAwarded'], 'validateJsonSchema'],
+            [['courseCode', 'coursePrerequisites', 'educationalCredentialAwarded', 'hasCourseInstance', 'numberOfCredits', 'occupationalCredentialAwarded'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/ChooseAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -119,7 +119,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'actionOption' => ['Text','Thing']
+        'actionOption' => ['Text', 'Thing']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/ItemAvailability.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/TelevisionChannel.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -164,9 +164,9 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'broadcastChannelId' => ['Text'],
-        'broadcastFrequency' => ['BroadcastFrequencySpecification','Text'],
+        'broadcastFrequency' => ['BroadcastFrequencySpecification', 'Text'],
         'broadcastServiceTier' => ['Text'],
-        'genre' => ['Text','URL'],
+        'genre' => ['Text', 'URL'],
         'inBroadcastLineup' => ['CableOrSatelliteService'],
         'providesBroadcastService' => ['BroadcastService']
     ];
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['broadcastChannelId','broadcastFrequency','broadcastServiceTier','genre','inBroadcastLineup','providesBroadcastService'], 'validateJsonSchema'],
+            [['broadcastChannelId', 'broadcastFrequency', 'broadcastServiceTier', 'genre', 'inBroadcastLineup', 'providesBroadcastService'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/ServiceChannel.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -177,7 +177,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'availableLanguage' => ['Language','Text'],
+        'availableLanguage' => ['Language', 'Text'],
         'processingTime' => ['Duration'],
         'providesService' => ['Service'],
         'serviceLocation' => ['Place'],
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['availableLanguage','processingTime','providesService','serviceLocation','servicePhone','servicePostalAddress','serviceSmsNumber','serviceUrl'], 'validateJsonSchema'],
+            [['availableLanguage', 'processingTime', 'providesService', 'serviceLocation', 'servicePhone', 'servicePostalAddress', 'serviceSmsNumber', 'serviceUrl'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -222,15 +222,15 @@ discard block
		block discarded – undo
222	222	*/
223	223	static protected $_schemaPropertyExpectedTypes = [
224	224	'actionStatus' => ['ActionStatusType'],
225		- 'agent' => ['Organization','Person'],
226		- 'endTime' => ['DateTime','Time'],
	225	+ 'agent' => ['Organization', 'Person'],
	226	+ 'endTime' => ['DateTime', 'Time'],
227	227	'error' => ['Thing'],
228	228	'instrument' => ['Thing'],
229		- 'location' => ['Place','PostalAddress','Text','VirtualLocation'],
	229	+ 'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
230	230	'object' => ['Thing'],
231		- 'participant' => ['Organization','Person'],
	231	+ 'participant' => ['Organization', 'Person'],
232	232	'result' => ['Thing'],
233		- 'startTime' => ['DateTime','Time'],
	233	+ 'startTime' => ['DateTime', 'Time'],
234	234	'target' => ['EntryPoint']
235	235	];
236	236
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	{
312	312	$rules = parent::rules();
313	313	$rules = array_merge($rules, [
314		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	314	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
315	315	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
316	316	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
317	317	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -172,11 +172,11 @@ discard block
		block discarded – undo
172	172	*/
173	173	static protected $_schemaPropertyExpectedTypes = [
174	174	'courseCode' => ['Text'],
175		- 'coursePrerequisites' => ['AlignmentObject','Course','Text'],
176		- 'educationalCredentialAwarded' => ['EducationalOccupationalCredential','Text','URL'],
	175	+ 'coursePrerequisites' => ['AlignmentObject', 'Course', 'Text'],
	176	+ 'educationalCredentialAwarded' => ['EducationalOccupationalCredential', 'Text', 'URL'],
177	177	'hasCourseInstance' => ['CourseInstance'],
178		- 'numberOfCredits' => ['Integer','StructuredValue'],
179		- 'occupationalCredentialAwarded' => ['EducationalOccupationalCredential','Text','URL']
	178	+ 'numberOfCredits' => ['Integer', 'StructuredValue'],
	179	+ 'occupationalCredentialAwarded' => ['EducationalOccupationalCredential', 'Text', 'URL']
180	180	];
181	181
182	182	/**
		@@ -251,7 +251,7 @@ discard block
		block discarded – undo
251	251	{
252	252	$rules = parent::rules();
253	253	$rules = array_merge($rules, [
254		- [['courseCode','coursePrerequisites','educationalCredentialAwarded','hasCourseInstance','numberOfCredits','occupationalCredentialAwarded'], 'validateJsonSchema'],
	254	+ [['courseCode', 'coursePrerequisites', 'educationalCredentialAwarded', 'hasCourseInstance', 'numberOfCredits', 'occupationalCredentialAwarded'], 'validateJsonSchema'],
255	255	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
256	256	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
257	257	]);

		@@ -119,7 +119,7 @@
		block discarded – undo
119	119	* @var array
120	120	*/
121	121	static protected $_schemaPropertyExpectedTypes = [
122		- 'actionOption' => ['Text','Thing']
	122	+ 'actionOption' => ['Text', 'Thing']
123	123	];
124	124
125	125	/**

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

		@@ -164,9 +164,9 @@ discard block
		block discarded – undo
164	164	*/
165	165	static protected $_schemaPropertyExpectedTypes = [
166	166	'broadcastChannelId' => ['Text'],
167		- 'broadcastFrequency' => ['BroadcastFrequencySpecification','Text'],
	167	+ 'broadcastFrequency' => ['BroadcastFrequencySpecification', 'Text'],
168	168	'broadcastServiceTier' => ['Text'],
169		- 'genre' => ['Text','URL'],
	169	+ 'genre' => ['Text', 'URL'],
170	170	'inBroadcastLineup' => ['CableOrSatelliteService'],
171	171	'providesBroadcastService' => ['BroadcastService']
172	172	];
		@@ -243,7 +243,7 @@ discard block
		block discarded – undo
243	243	{
244	244	$rules = parent::rules();
245	245	$rules = array_merge($rules, [
246		- [['broadcastChannelId','broadcastFrequency','broadcastServiceTier','genre','inBroadcastLineup','providesBroadcastService'], 'validateJsonSchema'],
	246	+ [['broadcastChannelId', 'broadcastFrequency', 'broadcastServiceTier', 'genre', 'inBroadcastLineup', 'providesBroadcastService'], 'validateJsonSchema'],
247	247	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
248	248	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
249	249	]);

		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	* @var array
178	178	*/
179	179	static protected $_schemaPropertyExpectedTypes = [
180		- 'availableLanguage' => ['Language','Text'],
	180	+ 'availableLanguage' => ['Language', 'Text'],
181	181	'processingTime' => ['Duration'],
182	182	'providesService' => ['Service'],
183	183	'serviceLocation' => ['Place'],
		@@ -261,7 +261,7 @@ discard block
		block discarded – undo
261	261	{
262	262	$rules = parent::rules();
263	263	$rules = array_merge($rules, [
264		- [['availableLanguage','processingTime','providesService','serviceLocation','servicePhone','servicePostalAddress','serviceSmsNumber','serviceUrl'], 'validateJsonSchema'],
	264	+ [['availableLanguage', 'processingTime', 'providesService', 'serviceLocation', 'servicePhone', 'servicePostalAddress', 'serviceSmsNumber', 'serviceUrl'], 'validateJsonSchema'],
265	265	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
266	266	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
267	267	]);

nystudio107 / craft-seomatic

Push — develop ( e03220...4c5204 )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch