Inspection of "Always create sitemap URLs from the given site" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#257)

by Timothy

created 2018-11-01 17:59 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Accommodation.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -164,9 +164,9 @@  discard block
 block discarded – undo
     static protected $_schemaPropertyExpectedTypes = [
         'amenityFeature' => ['LocationFeatureSpecification'],
         'floorSize' => ['QuantitativeValue'],
-        'numberOfRooms' => ['Number','QuantitativeValue'],
+        'numberOfRooms' => ['Number', 'QuantitativeValue'],
         'permittedUsage' => ['Text'],
-        'petsAllowed' => ['Boolean','Text']
+        'petsAllowed' => ['Boolean', 'Text']
     ];
 
     /**
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['amenityFeature','floorSize','numberOfRooms','permittedUsage','petsAllowed'], 'validateJsonSchema'],
+            [['amenityFeature', 'floorSize', 'numberOfRooms', 'permittedUsage', 'petsAllowed'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/DisagreeAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -218,13 +218,13 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
+        'agent' => ['Organization', 'Person'],
         'endTime' => ['DateTime'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text'],
+        'location' => ['Place', 'PostalAddress', 'Text'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
         'startTime' => ['DateTime'],
         'target' => ['EntryPoint']
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/QAPage.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -203,14 +203,14 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'breadcrumb' => ['BreadcrumbList','Text'],
+        'breadcrumb' => ['BreadcrumbList', 'Text'],
         'lastReviewed' => ['Date'],
         'mainContentOfPage' => ['WebPageElement'],
         'primaryImageOfPage' => ['ImageObject'],
         'relatedLink' => ['URL'],
-        'reviewedBy' => ['Organization','Person'],
+        'reviewedBy' => ['Organization', 'Person'],
         'significantLink' => ['URL'],
-        'speakable' => ['SpeakableSpecification','URL'],
+        'speakable' => ['SpeakableSpecification', 'URL'],
         'specialty' => ['Specialty']
     ];
 
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['breadcrumb','lastReviewed','mainContentOfPage','primaryImageOfPage','relatedLink','reviewedBy','significantLink','speakable','specialty'], 'validateJsonSchema'],
+            [['breadcrumb', 'lastReviewed', 'mainContentOfPage', 'primaryImageOfPage', 'relatedLink', 'reviewedBy', 'significantLink', 'speakable', 'specialty'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/RsvpAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -209,7 +209,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['additionalNumberOfGuests','comment','rsvpResponse'], 'validateJsonSchema'],
+            [['additionalNumberOfGuests', 'comment', 'rsvpResponse'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/HowToStep.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -152,8 +152,8 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'itemListElement' => ['ListItem','Text','Thing'],
-        'itemListOrder' => ['ItemListOrderType','Text'],
+        'itemListElement' => ['ListItem', 'Text', 'Thing'],
+        'itemListOrder' => ['ItemListOrderType', 'Text'],
         'numberOfItems' => ['Integer']
     ];
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['itemListElement','itemListOrder','numberOfItems'], 'validateJsonSchema'],
+            [['itemListElement', 'itemListOrder', 'numberOfItems'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/GeoCoordinates.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -158,11 +158,11 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'address' => ['PostalAddress','Text'],
-        'addressCountry' => ['Country','Text'],
-        'elevation' => ['Number','Text'],
-        'latitude' => ['Number','Text'],
-        'longitude' => ['Number','Text'],
+        'address' => ['PostalAddress', 'Text'],
+        'addressCountry' => ['Country', 'Text'],
+        'elevation' => ['Number', 'Text'],
+        'latitude' => ['Number', 'Text'],
+        'longitude' => ['Number', 'Text'],
         'postalCode' => ['Text']
     ];
 
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['address','addressCountry','elevation','latitude','longitude','postalCode'], 'validateJsonSchema'],
+            [['address', 'addressCountry', 'elevation', 'latitude', 'longitude', 'postalCode'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/PlaceOfWorship.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/AutoRental.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -164,9 +164,9 @@ discard block
		block discarded – undo
164	164	static protected $_schemaPropertyExpectedTypes = [
165	165	'amenityFeature' => ['LocationFeatureSpecification'],
166	166	'floorSize' => ['QuantitativeValue'],
167		- 'numberOfRooms' => ['Number','QuantitativeValue'],
	167	+ 'numberOfRooms' => ['Number', 'QuantitativeValue'],
168	168	'permittedUsage' => ['Text'],
169		- 'petsAllowed' => ['Boolean','Text']
	169	+ 'petsAllowed' => ['Boolean', 'Text']
170	170	];
171	171
172	172	/**
		@@ -240,7 +240,7 @@ discard block
		block discarded – undo
240	240	{
241	241	$rules = parent::rules();
242	242	$rules = array_merge($rules, [
243		- [['amenityFeature','floorSize','numberOfRooms','permittedUsage','petsAllowed'], 'validateJsonSchema'],
	243	+ [['amenityFeature', 'floorSize', 'numberOfRooms', 'permittedUsage', 'petsAllowed'], 'validateJsonSchema'],
244	244	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
245	245	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
246	246	]);

		@@ -218,13 +218,13 @@ discard block
		block discarded – undo
218	218	*/
219	219	static protected $_schemaPropertyExpectedTypes = [
220	220	'actionStatus' => ['ActionStatusType'],
221		- 'agent' => ['Organization','Person'],
	221	+ 'agent' => ['Organization', 'Person'],
222	222	'endTime' => ['DateTime'],
223	223	'error' => ['Thing'],
224	224	'instrument' => ['Thing'],
225		- 'location' => ['Place','PostalAddress','Text'],
	225	+ 'location' => ['Place', 'PostalAddress', 'Text'],
226	226	'object' => ['Thing'],
227		- 'participant' => ['Organization','Person'],
	227	+ 'participant' => ['Organization', 'Person'],
228	228	'result' => ['Thing'],
229	229	'startTime' => ['DateTime'],
230	230	'target' => ['EntryPoint']
		@@ -307,7 +307,7 @@ discard block
		block discarded – undo
307	307	{
308	308	$rules = parent::rules();
309	309	$rules = array_merge($rules, [
310		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	310	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
311	311	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
312	312	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
313	313	]);

		@@ -203,14 +203,14 @@ discard block
		block discarded – undo
203	203	* @var array
204	204	*/
205	205	static protected $_schemaPropertyExpectedTypes = [
206		- 'breadcrumb' => ['BreadcrumbList','Text'],
	206	+ 'breadcrumb' => ['BreadcrumbList', 'Text'],
207	207	'lastReviewed' => ['Date'],
208	208	'mainContentOfPage' => ['WebPageElement'],
209	209	'primaryImageOfPage' => ['ImageObject'],
210	210	'relatedLink' => ['URL'],
211		- 'reviewedBy' => ['Organization','Person'],
	211	+ 'reviewedBy' => ['Organization', 'Person'],
212	212	'significantLink' => ['URL'],
213		- 'speakable' => ['SpeakableSpecification','URL'],
	213	+ 'speakable' => ['SpeakableSpecification', 'URL'],
214	214	'specialty' => ['Specialty']
215	215	];
216	216
		@@ -289,7 +289,7 @@ discard block
		block discarded – undo
289	289	{
290	290	$rules = parent::rules();
291	291	$rules = array_merge($rules, [
292		- [['breadcrumb','lastReviewed','mainContentOfPage','primaryImageOfPage','relatedLink','reviewedBy','significantLink','speakable','specialty'], 'validateJsonSchema'],
	292	+ [['breadcrumb', 'lastReviewed', 'mainContentOfPage', 'primaryImageOfPage', 'relatedLink', 'reviewedBy', 'significantLink', 'speakable', 'specialty'], 'validateJsonSchema'],
293	293	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
294	294	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
295	295	]);

		@@ -209,7 +209,7 @@
		block discarded – undo
209	209	{
210	210	$rules = parent::rules();
211	211	$rules = array_merge($rules, [
212		- [['additionalNumberOfGuests','comment','rsvpResponse'], 'validateJsonSchema'],
	212	+ [['additionalNumberOfGuests', 'comment', 'rsvpResponse'], 'validateJsonSchema'],
213	213	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
214	214	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
215	215	]);

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -152,8 +152,8 @@ discard block
		block discarded – undo
152	152	* @var array
153	153	*/
154	154	static protected $_schemaPropertyExpectedTypes = [
155		- 'itemListElement' => ['ListItem','Text','Thing'],
156		- 'itemListOrder' => ['ItemListOrderType','Text'],
	155	+ 'itemListElement' => ['ListItem', 'Text', 'Thing'],
	156	+ 'itemListOrder' => ['ItemListOrderType', 'Text'],
157	157	'numberOfItems' => ['Integer']
158	158	];
159	159
		@@ -226,7 +226,7 @@ discard block
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['itemListElement','itemListOrder','numberOfItems'], 'validateJsonSchema'],
	229	+ [['itemListElement', 'itemListOrder', 'numberOfItems'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -158,11 +158,11 @@ discard block
		block discarded – undo
158	158	* @var array
159	159	*/
160	160	static protected $_schemaPropertyExpectedTypes = [
161		- 'address' => ['PostalAddress','Text'],
162		- 'addressCountry' => ['Country','Text'],
163		- 'elevation' => ['Number','Text'],
164		- 'latitude' => ['Number','Text'],
165		- 'longitude' => ['Number','Text'],
	161	+ 'address' => ['PostalAddress', 'Text'],
	162	+ 'addressCountry' => ['Country', 'Text'],
	163	+ 'elevation' => ['Number', 'Text'],
	164	+ 'latitude' => ['Number', 'Text'],
	165	+ 'longitude' => ['Number', 'Text'],
166	166	'postalCode' => ['Text']
167	167	];
168	168
		@@ -238,7 +238,7 @@ discard block
		block discarded – undo
238	238	{
239	239	$rules = parent::rules();
240	240	$rules = array_merge($rules, [
241		- [['address','addressCountry','elevation','latitude','longitude','postalCode'], 'validateJsonSchema'],
	241	+ [['address', 'addressCountry', 'elevation', 'latitude', 'longitude', 'postalCode'], 'validateJsonSchema'],
242	242	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
243	243	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
244	244	]);

nystudio107 / craft-seomatic

Pull Request — develop (#257)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch