Inspection of "Always create sitemap URLs from the given site" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#257)

by Timothy

created 2018-11-01 17:59 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -203,14 +203,14 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'breadcrumb' => ['BreadcrumbList','Text'],
+        'breadcrumb' => ['BreadcrumbList', 'Text'],
         'lastReviewed' => ['Date'],
         'mainContentOfPage' => ['WebPageElement'],
         'primaryImageOfPage' => ['ImageObject'],
         'relatedLink' => ['URL'],
-        'reviewedBy' => ['Organization','Person'],
+        'reviewedBy' => ['Organization', 'Person'],
         'significantLink' => ['URL'],
-        'speakable' => ['SpeakableSpecification','URL'],
+        'speakable' => ['SpeakableSpecification', 'URL'],
         'specialty' => ['Specialty']
     ];
 
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['breadcrumb','lastReviewed','mainContentOfPage','primaryImageOfPage','relatedLink','reviewedBy','significantLink','speakable','specialty'], 'validateJsonSchema'],
+            [['breadcrumb', 'lastReviewed', 'mainContentOfPage', 'primaryImageOfPage', 'relatedLink', 'reviewedBy', 'significantLink', 'speakable', 'specialty'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/AssessAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -218,13 +218,13 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
+        'agent' => ['Organization', 'Person'],
         'endTime' => ['DateTime'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text'],
+        'location' => ['Place', 'PostalAddress', 'Text'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
         'startTime' => ['DateTime'],
         'target' => ['EntryPoint']
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/WebApplication.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/CollegeOrUniversity.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Energy.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -217,9 +217,9 @@  discard block
 block discarded – undo
         'alternateName' => ['Text'],
         'description' => ['Text'],
         'disambiguatingDescription' => ['Text'],
-        'identifier' => ['PropertyValue','Text','URL'],
-        'image' => ['ImageObject','URL'],
-        'mainEntityOfPage' => ['CreativeWork','URL'],
+        'identifier' => ['PropertyValue', 'Text', 'URL'],
+        'image' => ['ImageObject', 'URL'],
+        'mainEntityOfPage' => ['CreativeWork', 'URL'],
         'name' => ['Text'],
         'potentialAction' => ['Action'],
         'sameAs' => ['URL'],
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['additionalType','alternateName','description','disambiguatingDescription','identifier','image','mainEntityOfPage','name','potentialAction','sameAs','url'], 'validateJsonSchema'],
+            [['additionalType', 'alternateName', 'description', 'disambiguatingDescription', 'identifier', 'image', 'mainEntityOfPage', 'name', 'potentialAction', 'sameAs', 'url'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Answer.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -211,7 +211,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['downvoteCount','parentItem','upvoteCount'], 'validateJsonSchema'],
+            [['downvoteCount', 'parentItem', 'upvoteCount'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/School.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/BusStop.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/AutoRepair.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -203,14 +203,14 @@ discard block
		block discarded – undo
203	203	* @var array
204	204	*/
205	205	static protected $_schemaPropertyExpectedTypes = [
206		- 'breadcrumb' => ['BreadcrumbList','Text'],
	206	+ 'breadcrumb' => ['BreadcrumbList', 'Text'],
207	207	'lastReviewed' => ['Date'],
208	208	'mainContentOfPage' => ['WebPageElement'],
209	209	'primaryImageOfPage' => ['ImageObject'],
210	210	'relatedLink' => ['URL'],
211		- 'reviewedBy' => ['Organization','Person'],
	211	+ 'reviewedBy' => ['Organization', 'Person'],
212	212	'significantLink' => ['URL'],
213		- 'speakable' => ['SpeakableSpecification','URL'],
	213	+ 'speakable' => ['SpeakableSpecification', 'URL'],
214	214	'specialty' => ['Specialty']
215	215	];
216	216
		@@ -289,7 +289,7 @@ discard block
		block discarded – undo
289	289	{
290	290	$rules = parent::rules();
291	291	$rules = array_merge($rules, [
292		- [['breadcrumb','lastReviewed','mainContentOfPage','primaryImageOfPage','relatedLink','reviewedBy','significantLink','speakable','specialty'], 'validateJsonSchema'],
	292	+ [['breadcrumb', 'lastReviewed', 'mainContentOfPage', 'primaryImageOfPage', 'relatedLink', 'reviewedBy', 'significantLink', 'speakable', 'specialty'], 'validateJsonSchema'],
293	293	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
294	294	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
295	295	]);

		@@ -218,13 +218,13 @@ discard block
		block discarded – undo
218	218	*/
219	219	static protected $_schemaPropertyExpectedTypes = [
220	220	'actionStatus' => ['ActionStatusType'],
221		- 'agent' => ['Organization','Person'],
	221	+ 'agent' => ['Organization', 'Person'],
222	222	'endTime' => ['DateTime'],
223	223	'error' => ['Thing'],
224	224	'instrument' => ['Thing'],
225		- 'location' => ['Place','PostalAddress','Text'],
	225	+ 'location' => ['Place', 'PostalAddress', 'Text'],
226	226	'object' => ['Thing'],
227		- 'participant' => ['Organization','Person'],
	227	+ 'participant' => ['Organization', 'Person'],
228	228	'result' => ['Thing'],
229	229	'startTime' => ['DateTime'],
230	230	'target' => ['EntryPoint']
		@@ -307,7 +307,7 @@ discard block
		block discarded – undo
307	307	{
308	308	$rules = parent::rules();
309	309	$rules = array_merge($rules, [
310		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	310	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
311	311	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
312	312	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
313	313	]);

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -217,9 +217,9 @@ discard block
		block discarded – undo
217	217	'alternateName' => ['Text'],
218	218	'description' => ['Text'],
219	219	'disambiguatingDescription' => ['Text'],
220		- 'identifier' => ['PropertyValue','Text','URL'],
221		- 'image' => ['ImageObject','URL'],
222		- 'mainEntityOfPage' => ['CreativeWork','URL'],
	220	+ 'identifier' => ['PropertyValue', 'Text', 'URL'],
	221	+ 'image' => ['ImageObject', 'URL'],
	222	+ 'mainEntityOfPage' => ['CreativeWork', 'URL'],
223	223	'name' => ['Text'],
224	224	'potentialAction' => ['Action'],
225	225	'sameAs' => ['URL'],
		@@ -303,7 +303,7 @@ discard block
		block discarded – undo
303	303	{
304	304	$rules = parent::rules();
305	305	$rules = array_merge($rules, [
306		- [['additionalType','alternateName','description','disambiguatingDescription','identifier','image','mainEntityOfPage','name','potentialAction','sameAs','url'], 'validateJsonSchema'],
	306	+ [['additionalType', 'alternateName', 'description', 'disambiguatingDescription', 'identifier', 'image', 'mainEntityOfPage', 'name', 'potentialAction', 'sameAs', 'url'], 'validateJsonSchema'],
307	307	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
308	308	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
309	309	]);

		@@ -211,7 +211,7 @@
		block discarded – undo
211	211	{
212	212	$rules = parent::rules();
213	213	$rules = array_merge($rules, [
214		- [['downvoteCount','parentItem','upvoteCount'], 'validateJsonSchema'],
	214	+ [['downvoteCount', 'parentItem', 'upvoteCount'], 'validateJsonSchema'],
215	215	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
216	216	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
217	217	]);

nystudio107 / craft-seomatic

Pull Request — develop (#257)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch