Inspection of "Always create sitemap URLs from the given site" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#257)

by Timothy

created 2018-11-01 17:59 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'requiredQuantity' => ['Number','QuantitativeValue','Text']
+        'requiredQuantity' => ['Number', 'QuantitativeValue', 'Text']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/TouristAttraction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -132,8 +132,8 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'availableLanguage' => ['Language','Text'],
-        'touristType' => ['Audience','Text']
+        'availableLanguage' => ['Language', 'Text'],
+        'touristType' => ['Audience', 'Text']
     ];
 
     /**
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['availableLanguage','touristType'], 'validateJsonSchema'],
+            [['availableLanguage', 'touristType'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/NightClub.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/ParcelDelivery.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -210,7 +210,7 @@  discard block
 block discarded – undo
         'itemShipped' => ['Product'],
         'originAddress' => ['PostalAddress'],
         'partOfOrder' => ['Order'],
-        'provider' => ['Organization','Person'],
+        'provider' => ['Organization', 'Person'],
         'trackingNumber' => ['Text'],
         'trackingUrl' => ['URL']
     ];
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['deliveryAddress','deliveryStatus','expectedArrivalFrom','expectedArrivalUntil','hasDeliveryMethod','itemShipped','originAddress','partOfOrder','provider','trackingNumber','trackingUrl'], 'validateJsonSchema'],
+            [['deliveryAddress', 'deliveryStatus', 'expectedArrivalFrom', 'expectedArrivalUntil', 'hasDeliveryMethod', 'itemShipped', 'originAddress', 'partOfOrder', 'provider', 'trackingNumber', 'trackingUrl'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MusicRelease.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -162,7 +162,7 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'catalogNumber' => ['Text'],
-        'creditedTo' => ['Organization','Person'],
+        'creditedTo' => ['Organization', 'Person'],
         'duration' => ['Duration'],
         'musicReleaseFormat' => ['MusicReleaseFormatType'],
         'recordLabel' => ['Organization'],
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['catalogNumber','creditedTo','duration','musicReleaseFormat','recordLabel','releaseOf'], 'validateJsonSchema'],
+            [['catalogNumber', 'creditedTo', 'duration', 'musicReleaseFormat', 'recordLabel', 'releaseOf'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/AssignAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'purpose' => ['MedicalDevicePurpose','Thing']
+        'purpose' => ['MedicalDevicePurpose', 'Thing']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/MiddleSchool.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/EmergencyService.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/InviteAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -118,7 +118,7 @@
		block discarded – undo
118	118	* @var array
119	119	*/
120	120	static protected $_schemaPropertyExpectedTypes = [
121		- 'requiredQuantity' => ['Number','QuantitativeValue','Text']
	121	+ 'requiredQuantity' => ['Number', 'QuantitativeValue', 'Text']
122	122	];
123	123
124	124	/**

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -132,8 +132,8 @@ discard block
		block discarded – undo
132	132	* @var array
133	133	*/
134	134	static protected $_schemaPropertyExpectedTypes = [
135		- 'availableLanguage' => ['Language','Text'],
136		- 'touristType' => ['Audience','Text']
	135	+ 'availableLanguage' => ['Language', 'Text'],
	136	+ 'touristType' => ['Audience', 'Text']
137	137	];
138	138
139	139	/**
		@@ -204,7 +204,7 @@ discard block
		block discarded – undo
204	204	{
205	205	$rules = parent::rules();
206	206	$rules = array_merge($rules, [
207		- [['availableLanguage','touristType'], 'validateJsonSchema'],
	207	+ [['availableLanguage', 'touristType'], 'validateJsonSchema'],
208	208	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
209	209	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
210	210	]);

		@@ -210,7 +210,7 @@ discard block
		block discarded – undo
210	210	'itemShipped' => ['Product'],
211	211	'originAddress' => ['PostalAddress'],
212	212	'partOfOrder' => ['Order'],
213		- 'provider' => ['Organization','Person'],
	213	+ 'provider' => ['Organization', 'Person'],
214	214	'trackingNumber' => ['Text'],
215	215	'trackingUrl' => ['URL']
216	216	];
		@@ -292,7 +292,7 @@ discard block
		block discarded – undo
292	292	{
293	293	$rules = parent::rules();
294	294	$rules = array_merge($rules, [
295		- [['deliveryAddress','deliveryStatus','expectedArrivalFrom','expectedArrivalUntil','hasDeliveryMethod','itemShipped','originAddress','partOfOrder','provider','trackingNumber','trackingUrl'], 'validateJsonSchema'],
	295	+ [['deliveryAddress', 'deliveryStatus', 'expectedArrivalFrom', 'expectedArrivalUntil', 'hasDeliveryMethod', 'itemShipped', 'originAddress', 'partOfOrder', 'provider', 'trackingNumber', 'trackingUrl'], 'validateJsonSchema'],
296	296	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
297	297	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
298	298	]);

		@@ -162,7 +162,7 @@ discard block
		block discarded – undo
162	162	*/
163	163	static protected $_schemaPropertyExpectedTypes = [
164	164	'catalogNumber' => ['Text'],
165		- 'creditedTo' => ['Organization','Person'],
	165	+ 'creditedTo' => ['Organization', 'Person'],
166	166	'duration' => ['Duration'],
167	167	'musicReleaseFormat' => ['MusicReleaseFormatType'],
168	168	'recordLabel' => ['Organization'],
		@@ -241,7 +241,7 @@ discard block
		block discarded – undo
241	241	{
242	242	$rules = parent::rules();
243	243	$rules = array_merge($rules, [
244		- [['catalogNumber','creditedTo','duration','musicReleaseFormat','recordLabel','releaseOf'], 'validateJsonSchema'],
	244	+ [['catalogNumber', 'creditedTo', 'duration', 'musicReleaseFormat', 'recordLabel', 'releaseOf'], 'validateJsonSchema'],
245	245	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
246	246	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
247	247	]);

nystudio107 / craft-seomatic

Pull Request — develop (#257)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch