Inspection of "Always create sitemap URLs from the given site" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#257)

by Timothy

created 2018-11-01 17:57 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -203,14 +203,14 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'breadcrumb' => ['BreadcrumbList','Text'],
+        'breadcrumb' => ['BreadcrumbList', 'Text'],
         'lastReviewed' => ['Date'],
         'mainContentOfPage' => ['WebPageElement'],
         'primaryImageOfPage' => ['ImageObject'],
         'relatedLink' => ['URL'],
-        'reviewedBy' => ['Organization','Person'],
+        'reviewedBy' => ['Organization', 'Person'],
         'significantLink' => ['URL'],
-        'speakable' => ['SpeakableSpecification','URL'],
+        'speakable' => ['SpeakableSpecification', 'URL'],
         'specialty' => ['Specialty']
     ];
 
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['breadcrumb','lastReviewed','mainContentOfPage','primaryImageOfPage','relatedLink','reviewedBy','significantLink','speakable','specialty'], 'validateJsonSchema'],
+            [['breadcrumb', 'lastReviewed', 'mainContentOfPage', 'primaryImageOfPage', 'relatedLink', 'reviewedBy', 'significantLink', 'speakable', 'specialty'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MusicAlbumProductionType.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/CreativeWorkSeason.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -199,13 +199,13 @@  discard block
 block discarded – undo
     static protected $_schemaPropertyExpectedTypes = [
         'actor' => ['Person'],
         'director' => ['Person'],
-        'endDate' => ['Date','DateTime'],
+        'endDate' => ['Date', 'DateTime'],
         'episode' => ['Episode'],
         'numberOfEpisodes' => ['Integer'],
         'partOfSeries' => ['CreativeWorkSeries'],
         'productionCompany' => ['Organization'],
-        'seasonNumber' => ['Integer','Text'],
-        'startDate' => ['Date','DateTime'],
+        'seasonNumber' => ['Integer', 'Text'],
+        'startDate' => ['Date', 'DateTime'],
         'trailer' => ['VideoObject']
     ];
 
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actor','director','endDate','episode','numberOfEpisodes','partOfSeries','productionCompany','seasonNumber','startDate','trailer'], 'validateJsonSchema'],
+            [['actor', 'director', 'endDate', 'episode', 'numberOfEpisodes', 'partOfSeries', 'productionCompany', 'seasonNumber', 'startDate', 'trailer'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Integer.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/SportsTeam.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -198,7 +198,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['athlete','coach'], 'validateJsonSchema'],
+            [['athlete', 'coach'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/DepartAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -202,7 +202,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['fromLocation','toLocation'], 'validateJsonSchema'],
+            [['fromLocation', 'toLocation'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/GasStation.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/TVSeries.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -202,7 +202,7 @@  discard block
 block discarded – undo
         'countryOfOrigin' => ['Country'],
         'director' => ['Person'],
         'episode' => ['Episode'],
-        'musicBy' => ['MusicGroup','Person'],
+        'musicBy' => ['MusicGroup', 'Person'],
         'numberOfEpisodes' => ['Integer'],
         'numberOfSeasons' => ['Integer'],
         'productionCompany' => ['Organization'],
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actor','containsSeason','countryOfOrigin','director','episode','musicBy','numberOfEpisodes','numberOfSeasons','productionCompany','trailer'], 'validateJsonSchema'],
+            [['actor', 'containsSeason', 'countryOfOrigin', 'director', 'episode', 'musicBy', 'numberOfEpisodes', 'numberOfSeasons', 'productionCompany', 'trailer'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/UpdateAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

		@@ -203,14 +203,14 @@ discard block
		block discarded – undo
203	203	* @var array
204	204	*/
205	205	static protected $_schemaPropertyExpectedTypes = [
206		- 'breadcrumb' => ['BreadcrumbList','Text'],
	206	+ 'breadcrumb' => ['BreadcrumbList', 'Text'],
207	207	'lastReviewed' => ['Date'],
208	208	'mainContentOfPage' => ['WebPageElement'],
209	209	'primaryImageOfPage' => ['ImageObject'],
210	210	'relatedLink' => ['URL'],
211		- 'reviewedBy' => ['Organization','Person'],
	211	+ 'reviewedBy' => ['Organization', 'Person'],
212	212	'significantLink' => ['URL'],
213		- 'speakable' => ['SpeakableSpecification','URL'],
	213	+ 'speakable' => ['SpeakableSpecification', 'URL'],
214	214	'specialty' => ['Specialty']
215	215	];
216	216
		@@ -289,7 +289,7 @@ discard block
		block discarded – undo
289	289	{
290	290	$rules = parent::rules();
291	291	$rules = array_merge($rules, [
292		- [['breadcrumb','lastReviewed','mainContentOfPage','primaryImageOfPage','relatedLink','reviewedBy','significantLink','speakable','specialty'], 'validateJsonSchema'],
	292	+ [['breadcrumb', 'lastReviewed', 'mainContentOfPage', 'primaryImageOfPage', 'relatedLink', 'reviewedBy', 'significantLink', 'speakable', 'specialty'], 'validateJsonSchema'],
293	293	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
294	294	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
295	295	]);

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -199,13 +199,13 @@ discard block
		block discarded – undo
199	199	static protected $_schemaPropertyExpectedTypes = [
200	200	'actor' => ['Person'],
201	201	'director' => ['Person'],
202		- 'endDate' => ['Date','DateTime'],
	202	+ 'endDate' => ['Date', 'DateTime'],
203	203	'episode' => ['Episode'],
204	204	'numberOfEpisodes' => ['Integer'],
205	205	'partOfSeries' => ['CreativeWorkSeries'],
206	206	'productionCompany' => ['Organization'],
207		- 'seasonNumber' => ['Integer','Text'],
208		- 'startDate' => ['Date','DateTime'],
	207	+ 'seasonNumber' => ['Integer', 'Text'],
	208	+ 'startDate' => ['Date', 'DateTime'],
209	209	'trailer' => ['VideoObject']
210	210	];
211	211
		@@ -285,7 +285,7 @@ discard block
		block discarded – undo
285	285	{
286	286	$rules = parent::rules();
287	287	$rules = array_merge($rules, [
288		- [['actor','director','endDate','episode','numberOfEpisodes','partOfSeries','productionCompany','seasonNumber','startDate','trailer'], 'validateJsonSchema'],
	288	+ [['actor', 'director', 'endDate', 'episode', 'numberOfEpisodes', 'partOfSeries', 'productionCompany', 'seasonNumber', 'startDate', 'trailer'], 'validateJsonSchema'],
289	289	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
290	290	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
291	291	]);

		@@ -198,7 +198,7 @@
		block discarded – undo
198	198	{
199	199	$rules = parent::rules();
200	200	$rules = array_merge($rules, [
201		- [['athlete','coach'], 'validateJsonSchema'],
	201	+ [['athlete', 'coach'], 'validateJsonSchema'],
202	202	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
203	203	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
204	204	]);

		@@ -202,7 +202,7 @@
		block discarded – undo
202	202	{
203	203	$rules = parent::rules();
204	204	$rules = array_merge($rules, [
205		- [['fromLocation','toLocation'], 'validateJsonSchema'],
	205	+ [['fromLocation', 'toLocation'], 'validateJsonSchema'],
206	206	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
207	207	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
208	208	]);

		@@ -202,7 +202,7 @@ discard block
		block discarded – undo
202	202	'countryOfOrigin' => ['Country'],
203	203	'director' => ['Person'],
204	204	'episode' => ['Episode'],
205		- 'musicBy' => ['MusicGroup','Person'],
	205	+ 'musicBy' => ['MusicGroup', 'Person'],
206	206	'numberOfEpisodes' => ['Integer'],
207	207	'numberOfSeasons' => ['Integer'],
208	208	'productionCompany' => ['Organization'],
		@@ -285,7 +285,7 @@ discard block
		block discarded – undo
285	285	{
286	286	$rules = parent::rules();
287	287	$rules = array_merge($rules, [
288		- [['actor','containsSeason','countryOfOrigin','director','episode','musicBy','numberOfEpisodes','numberOfSeasons','productionCompany','trailer'], 'validateJsonSchema'],
	288	+ [['actor', 'containsSeason', 'countryOfOrigin', 'director', 'episode', 'musicBy', 'numberOfEpisodes', 'numberOfSeasons', 'productionCompany', 'trailer'], 'validateJsonSchema'],
289	289	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
290	290	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
291	291	]);

nystudio107 / craft-seomatic

Pull Request — develop (#257)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch