Inspection of "Always create sitemap URLs from the given site" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#257)

by Timothy

created 2018-11-01 17:57 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -217,9 +217,9 @@  discard block
 block discarded – undo
         'alternateName' => ['Text'],
         'description' => ['Text'],
         'disambiguatingDescription' => ['Text'],
-        'identifier' => ['PropertyValue','Text','URL'],
-        'image' => ['ImageObject','URL'],
-        'mainEntityOfPage' => ['CreativeWork','URL'],
+        'identifier' => ['PropertyValue', 'Text', 'URL'],
+        'image' => ['ImageObject', 'URL'],
+        'mainEntityOfPage' => ['CreativeWork', 'URL'],
         'name' => ['Text'],
         'potentialAction' => ['Action'],
         'sameAs' => ['URL'],
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['additionalType','alternateName','description','disambiguatingDescription','identifier','image','mainEntityOfPage','name','potentialAction','sameAs','url'], 'validateJsonSchema'],
+            [['additionalType', 'alternateName', 'description', 'disambiguatingDescription', 'identifier', 'image', 'mainEntityOfPage', 'name', 'potentialAction', 'sameAs', 'url'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/NailSalon.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MarryAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -218,13 +218,13 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
+        'agent' => ['Organization', 'Person'],
         'endTime' => ['DateTime'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text'],
+        'location' => ['Place', 'PostalAddress', 'Text'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
         'startTime' => ['DateTime'],
         'target' => ['EntryPoint']
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/ReserveAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/IndividualProduct.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Synagogue.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/BroadcastEvent.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -208,7 +208,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['broadcastOfEvent','isLiveBroadcast','videoFormat'], 'validateJsonSchema'],
+            [['broadcastOfEvent', 'isLiveBroadcast', 'videoFormat'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/FlightReservation.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -146,7 +146,7 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'boardingGroup' => ['Text'],
-        'passengerPriorityStatus' => ['QualitativeValue','Text'],
+        'passengerPriorityStatus' => ['QualitativeValue', 'Text'],
         'passengerSequenceNumber' => ['Text'],
         'securityScreening' => ['Text']
     ];
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['boardingGroup','passengerPriorityStatus','passengerSequenceNumber','securityScreening'], 'validateJsonSchema'],
+            [['boardingGroup', 'passengerPriorityStatus', 'passengerSequenceNumber', 'securityScreening'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/EngineSpecification.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -172,8 +172,8 @@  discard block
 block discarded – undo
     static protected $_schemaPropertyExpectedTypes = [
         'engineDisplacement' => ['QuantitativeValue'],
         'enginePower' => ['QuantitativeValue'],
-        'engineType' => ['QualitativeValue','Text','URL'],
-        'fuelType' => ['QualitativeValue','Text','URL'],
+        'engineType' => ['QualitativeValue', 'Text', 'URL'],
+        'fuelType' => ['QualitativeValue', 'Text', 'URL'],
         'torque' => ['QuantitativeValue']
     ];
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['engineDisplacement','enginePower','engineType','fuelType','torque'], 'validateJsonSchema'],
+            [['engineDisplacement', 'enginePower', 'engineType', 'fuelType', 'torque'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -217,9 +217,9 @@ discard block
		block discarded – undo
217	217	'alternateName' => ['Text'],
218	218	'description' => ['Text'],
219	219	'disambiguatingDescription' => ['Text'],
220		- 'identifier' => ['PropertyValue','Text','URL'],
221		- 'image' => ['ImageObject','URL'],
222		- 'mainEntityOfPage' => ['CreativeWork','URL'],
	220	+ 'identifier' => ['PropertyValue', 'Text', 'URL'],
	221	+ 'image' => ['ImageObject', 'URL'],
	222	+ 'mainEntityOfPage' => ['CreativeWork', 'URL'],
223	223	'name' => ['Text'],
224	224	'potentialAction' => ['Action'],
225	225	'sameAs' => ['URL'],
		@@ -303,7 +303,7 @@ discard block
		block discarded – undo
303	303	{
304	304	$rules = parent::rules();
305	305	$rules = array_merge($rules, [
306		- [['additionalType','alternateName','description','disambiguatingDescription','identifier','image','mainEntityOfPage','name','potentialAction','sameAs','url'], 'validateJsonSchema'],
	306	+ [['additionalType', 'alternateName', 'description', 'disambiguatingDescription', 'identifier', 'image', 'mainEntityOfPage', 'name', 'potentialAction', 'sameAs', 'url'], 'validateJsonSchema'],
307	307	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
308	308	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
309	309	]);

		@@ -218,13 +218,13 @@ discard block
		block discarded – undo
218	218	*/
219	219	static protected $_schemaPropertyExpectedTypes = [
220	220	'actionStatus' => ['ActionStatusType'],
221		- 'agent' => ['Organization','Person'],
	221	+ 'agent' => ['Organization', 'Person'],
222	222	'endTime' => ['DateTime'],
223	223	'error' => ['Thing'],
224	224	'instrument' => ['Thing'],
225		- 'location' => ['Place','PostalAddress','Text'],
	225	+ 'location' => ['Place', 'PostalAddress', 'Text'],
226	226	'object' => ['Thing'],
227		- 'participant' => ['Organization','Person'],
	227	+ 'participant' => ['Organization', 'Person'],
228	228	'result' => ['Thing'],
229	229	'startTime' => ['DateTime'],
230	230	'target' => ['EntryPoint']
		@@ -307,7 +307,7 @@ discard block
		block discarded – undo
307	307	{
308	308	$rules = parent::rules();
309	309	$rules = array_merge($rules, [
310		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	310	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
311	311	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
312	312	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
313	313	]);

		@@ -208,7 +208,7 @@
		block discarded – undo
208	208	{
209	209	$rules = parent::rules();
210	210	$rules = array_merge($rules, [
211		- [['broadcastOfEvent','isLiveBroadcast','videoFormat'], 'validateJsonSchema'],
	211	+ [['broadcastOfEvent', 'isLiveBroadcast', 'videoFormat'], 'validateJsonSchema'],
212	212	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
213	213	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
214	214	]);

		@@ -146,7 +146,7 @@ discard block
		block discarded – undo
146	146	*/
147	147	static protected $_schemaPropertyExpectedTypes = [
148	148	'boardingGroup' => ['Text'],
149		- 'passengerPriorityStatus' => ['QualitativeValue','Text'],
	149	+ 'passengerPriorityStatus' => ['QualitativeValue', 'Text'],
150	150	'passengerSequenceNumber' => ['Text'],
151	151	'securityScreening' => ['Text']
152	152	];
		@@ -221,7 +221,7 @@ discard block
		block discarded – undo
221	221	{
222	222	$rules = parent::rules();
223	223	$rules = array_merge($rules, [
224		- [['boardingGroup','passengerPriorityStatus','passengerSequenceNumber','securityScreening'], 'validateJsonSchema'],
	224	+ [['boardingGroup', 'passengerPriorityStatus', 'passengerSequenceNumber', 'securityScreening'], 'validateJsonSchema'],
225	225	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
226	226	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
227	227	]);

		@@ -172,8 +172,8 @@ discard block
		block discarded – undo
172	172	static protected $_schemaPropertyExpectedTypes = [
173	173	'engineDisplacement' => ['QuantitativeValue'],
174	174	'enginePower' => ['QuantitativeValue'],
175		- 'engineType' => ['QualitativeValue','Text','URL'],
176		- 'fuelType' => ['QualitativeValue','Text','URL'],
	175	+ 'engineType' => ['QualitativeValue', 'Text', 'URL'],
	176	+ 'fuelType' => ['QualitativeValue', 'Text', 'URL'],
177	177	'torque' => ['QuantitativeValue']
178	178	];
179	179
		@@ -248,7 +248,7 @@ discard block
		block discarded – undo
248	248	{
249	249	$rules = parent::rules();
250	250	$rules = array_merge($rules, [
251		- [['engineDisplacement','enginePower','engineType','fuelType','torque'], 'validateJsonSchema'],
	251	+ [['engineDisplacement', 'enginePower', 'engineType', 'fuelType', 'torque'], 'validateJsonSchema'],
252	252	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
253	253	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
254	254	]);

nystudio107 / craft-seomatic

Pull Request — develop (#257)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch