Inspection of "Merge branch 'release/3.4.30' into v3" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v3 ( 6054b6...238b69 )

by Andrew

created 2022-04-18 22:16 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -185,9 +185,9 @@  discard block
 block discarded – undo
         'countryOfOrigin' => ['Country'],
         'director' => ['Person'],
         'duration' => ['Duration'],
-        'musicBy' => ['MusicGroup','Person'],
+        'musicBy' => ['MusicGroup', 'Person'],
         'productionCompany' => ['Organization'],
-        'subtitleLanguage' => ['Language','Text'],
+        'subtitleLanguage' => ['Language', 'Text'],
         'trailer' => ['VideoObject']
     ];
 
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actor','countryOfOrigin','director','duration','musicBy','productionCompany','subtitleLanguage','trailer'], 'validateJsonSchema'],
+            [['actor', 'countryOfOrigin', 'director', 'duration', 'musicBy', 'productionCompany', 'subtitleLanguage', 'trailer'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/PayAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -119,7 +119,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'recipient' => ['Audience','ContactPoint','Organization','Person']
+        'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/BuyAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -120,7 +120,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'seller' => ['Organization','Person']
+        'seller' => ['Organization', 'Person']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/LikeAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -222,15 +222,15 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
-        'endTime' => ['DateTime','Time'],
+        'agent' => ['Organization', 'Person'],
+        'endTime' => ['DateTime', 'Time'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text','VirtualLocation'],
+        'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
-        'startTime' => ['DateTime','Time'],
+        'startTime' => ['DateTime', 'Time'],
         'target' => ['EntryPoint']
     ];
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/VoteAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/AudioObject.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -127,7 +127,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'caption' => ['MediaObject','Text'],
+        'caption' => ['MediaObject', 'Text'],
         'transcript' => ['Text']
     ];
 
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['caption','transcript'], 'validateJsonSchema'],
+            [['caption', 'transcript'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/WearAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -200,7 +200,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionAccessibilityRequirement','expectsAcceptanceOf'], 'validateJsonSchema'],
+            [['actionAccessibilityRequirement', 'expectsAcceptanceOf'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/ContactPointOption.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/Winery.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -147,8 +147,8 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'acceptsReservations' => ['Boolean','Text','URL'],
-        'hasMenu' => ['Menu','Text','URL'],
+        'acceptsReservations' => ['Boolean', 'Text', 'URL'],
+        'hasMenu' => ['Menu', 'Text', 'URL'],
         'servesCuisine' => ['Text'],
         'starRating' => ['Rating']
     ];
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
+            [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -185,9 +185,9 @@ discard block
		block discarded – undo
185	185	'countryOfOrigin' => ['Country'],
186	186	'director' => ['Person'],
187	187	'duration' => ['Duration'],
188		- 'musicBy' => ['MusicGroup','Person'],
	188	+ 'musicBy' => ['MusicGroup', 'Person'],
189	189	'productionCompany' => ['Organization'],
190		- 'subtitleLanguage' => ['Language','Text'],
	190	+ 'subtitleLanguage' => ['Language', 'Text'],
191	191	'trailer' => ['VideoObject']
192	192	];
193	193
		@@ -265,7 +265,7 @@ discard block
		block discarded – undo
265	265	{
266	266	$rules = parent::rules();
267	267	$rules = array_merge($rules, [
268		- [['actor','countryOfOrigin','director','duration','musicBy','productionCompany','subtitleLanguage','trailer'], 'validateJsonSchema'],
	268	+ [['actor', 'countryOfOrigin', 'director', 'duration', 'musicBy', 'productionCompany', 'subtitleLanguage', 'trailer'], 'validateJsonSchema'],
269	269	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
270	270	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
271	271	]);

		@@ -222,15 +222,15 @@ discard block
		block discarded – undo
222	222	*/
223	223	static protected $_schemaPropertyExpectedTypes = [
224	224	'actionStatus' => ['ActionStatusType'],
225		- 'agent' => ['Organization','Person'],
226		- 'endTime' => ['DateTime','Time'],
	225	+ 'agent' => ['Organization', 'Person'],
	226	+ 'endTime' => ['DateTime', 'Time'],
227	227	'error' => ['Thing'],
228	228	'instrument' => ['Thing'],
229		- 'location' => ['Place','PostalAddress','Text','VirtualLocation'],
	229	+ 'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
230	230	'object' => ['Thing'],
231		- 'participant' => ['Organization','Person'],
	231	+ 'participant' => ['Organization', 'Person'],
232	232	'result' => ['Thing'],
233		- 'startTime' => ['DateTime','Time'],
	233	+ 'startTime' => ['DateTime', 'Time'],
234	234	'target' => ['EntryPoint']
235	235	];
236	236
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	{
312	312	$rules = parent::rules();
313	313	$rules = array_merge($rules, [
314		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	314	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
315	315	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
316	316	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
317	317	]);

		@@ -147,8 +147,8 @@ discard block
		block discarded – undo
147	147	* @var array
148	148	*/
149	149	static protected $_schemaPropertyExpectedTypes = [
150		- 'acceptsReservations' => ['Boolean','Text','URL'],
151		- 'hasMenu' => ['Menu','Text','URL'],
	150	+ 'acceptsReservations' => ['Boolean', 'Text', 'URL'],
	151	+ 'hasMenu' => ['Menu', 'Text', 'URL'],
152	152	'servesCuisine' => ['Text'],
153	153	'starRating' => ['Rating']
154	154	];
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	{
224	224	$rules = parent::rules();
225	225	$rules = array_merge($rules, [
226		- [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
	226	+ [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
227	227	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
228	228	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
229	229	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -119,7 +119,7 @@
		block discarded – undo
119	119	* @var array
120	120	*/
121	121	static protected $_schemaPropertyExpectedTypes = [
122		- 'recipient' => ['Audience','ContactPoint','Organization','Person']
	122	+ 'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
123	123	];
124	124
125	125	/**

		@@ -120,7 +120,7 @@
		block discarded – undo
120	120	* @var array
121	121	*/
122	122	static protected $_schemaPropertyExpectedTypes = [
123		- 'seller' => ['Organization','Person']
	123	+ 'seller' => ['Organization', 'Person']
124	124	];
125	125
126	126	/**

		@@ -127,7 +127,7 @@ discard block
		block discarded – undo
127	127	* @var array
128	128	*/
129	129	static protected $_schemaPropertyExpectedTypes = [
130		- 'caption' => ['MediaObject','Text'],
	130	+ 'caption' => ['MediaObject', 'Text'],
131	131	'transcript' => ['Text']
132	132	];
133	133
		@@ -199,7 +199,7 @@ discard block
		block discarded – undo
199	199	{
200	200	$rules = parent::rules();
201	201	$rules = array_merge($rules, [
202		- [['caption','transcript'], 'validateJsonSchema'],
	202	+ [['caption', 'transcript'], 'validateJsonSchema'],
203	203	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
204	204	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
205	205	]);

		@@ -200,7 +200,7 @@
		block discarded – undo
200	200	{
201	201	$rules = parent::rules();
202	202	$rules = array_merge($rules, [
203		- [['actionAccessibilityRequirement','expectsAcceptanceOf'], 'validateJsonSchema'],
	203	+ [['actionAccessibilityRequirement', 'expectsAcceptanceOf'], 'validateJsonSchema'],
204	204	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
205	205	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
206	206	]);

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

nystudio107 / craft-seomatic

Push — v3 ( 6054b6...238b69 )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch