Inspection of "Merge branch 'release/3.4.30' into v3" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v3 ( 6054b6...238b69 )

by Andrew

created 2022-04-18 22:16 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/TravelAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Festival.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -456,36 +456,36 @@  discard block
 block discarded – undo
         'about' => ['Thing'],
         'actor' => ['Person'],
         'aggregateRating' => ['AggregateRating'],
-        'attendee' => ['Organization','Person'],
+        'attendee' => ['Organization', 'Person'],
         'audience' => ['Audience'],
-        'composer' => ['Organization','Person'],
-        'contributor' => ['Organization','Person'],
+        'composer' => ['Organization', 'Person'],
+        'contributor' => ['Organization', 'Person'],
         'director' => ['Person'],
-        'doorTime' => ['DateTime','Time'],
+        'doorTime' => ['DateTime', 'Time'],
         'duration' => ['Duration'],
-        'endDate' => ['Date','DateTime'],
+        'endDate' => ['Date', 'DateTime'],
         'eventAttendanceMode' => ['EventAttendanceModeEnumeration'],
         'eventSchedule' => ['Schedule'],
         'eventStatus' => ['EventStatusType'],
-        'funder' => ['Organization','Person'],
-        'inLanguage' => ['Language','Text'],
+        'funder' => ['Organization', 'Person'],
+        'inLanguage' => ['Language', 'Text'],
         'isAccessibleForFree' => ['Boolean'],
-        'location' => ['Place','PostalAddress','Text','VirtualLocation'],
+        'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
         'maximumAttendeeCapacity' => ['Integer'],
         'maximumPhysicalAttendeeCapacity' => ['Integer'],
         'maximumVirtualAttendeeCapacity' => ['Integer'],
-        'offers' => ['Demand','Offer'],
-        'organizer' => ['Organization','Person'],
-        'performer' => ['Organization','Person'],
+        'offers' => ['Demand', 'Offer'],
+        'organizer' => ['Organization', 'Person'],
+        'performer' => ['Organization', 'Person'],
         'previousStartDate' => ['Date'],
         'recordedIn' => ['CreativeWork'],
         'remainingAttendeeCapacity' => ['Integer'],
         'review' => ['Review'],
-        'sponsor' => ['Organization','Person'],
-        'startDate' => ['Date','DateTime'],
+        'sponsor' => ['Organization', 'Person'],
+        'startDate' => ['Date', 'DateTime'],
         'subEvent' => ['Event'],
         'superEvent' => ['Event'],
-        'translator' => ['Organization','Person'],
+        'translator' => ['Organization', 'Person'],
         'typicalAgeRange' => ['Text'],
         'workFeatured' => ['CreativeWork'],
         'workPerformed' => ['CreativeWork']
@@ -593,7 +593,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventAttendanceMode','eventSchedule','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','maximumPhysicalAttendeeCapacity','maximumVirtualAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
+            [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventAttendanceMode', 'eventSchedule', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'maximumPhysicalAttendeeCapacity', 'maximumVirtualAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Enumeration.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/MusicPlaylist.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -127,7 +127,7 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'numTracks' => ['Integer'],
-        'track' => ['ItemList','MusicRecording']
+        'track' => ['ItemList', 'MusicRecording']
     ];
 
     /**
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['numTracks','track'], 'validateJsonSchema'],
+            [['numTracks', 'track'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/TipAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -119,7 +119,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'recipient' => ['Audience','ContactPoint','Organization','Person']
+        'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/Book.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -237,7 +237,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['abridged','bookEdition','bookFormat','illustrator','isbn','numberOfPages'], 'validateJsonSchema'],
+            [['abridged', 'bookEdition', 'bookFormat', 'illustrator', 'isbn', 'numberOfPages'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/TaxiReservation.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -136,7 +136,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'partySize' => ['Integer','QuantitativeValue'],
+        'partySize' => ['Integer', 'QuantitativeValue'],
         'pickupLocation' => ['Place'],
         'pickupTime' => ['DateTime']
     ];
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['partySize','pickupLocation','pickupTime'], 'validateJsonSchema'],
+            [['partySize', 'pickupLocation', 'pickupTime'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/FinancialService.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'feesAndCommissionsSpecification' => ['Text','URL']
+        'feesAndCommissionsSpecification' => ['Text', 'URL']
     ];
 
     /**

Please login to merge, or discard this patch.

		@@ -456,36 +456,36 @@ discard block
		block discarded – undo
456	456	'about' => ['Thing'],
457	457	'actor' => ['Person'],
458	458	'aggregateRating' => ['AggregateRating'],
459		- 'attendee' => ['Organization','Person'],
	459	+ 'attendee' => ['Organization', 'Person'],
460	460	'audience' => ['Audience'],
461		- 'composer' => ['Organization','Person'],
462		- 'contributor' => ['Organization','Person'],
	461	+ 'composer' => ['Organization', 'Person'],
	462	+ 'contributor' => ['Organization', 'Person'],
463	463	'director' => ['Person'],
464		- 'doorTime' => ['DateTime','Time'],
	464	+ 'doorTime' => ['DateTime', 'Time'],
465	465	'duration' => ['Duration'],
466		- 'endDate' => ['Date','DateTime'],
	466	+ 'endDate' => ['Date', 'DateTime'],
467	467	'eventAttendanceMode' => ['EventAttendanceModeEnumeration'],
468	468	'eventSchedule' => ['Schedule'],
469	469	'eventStatus' => ['EventStatusType'],
470		- 'funder' => ['Organization','Person'],
471		- 'inLanguage' => ['Language','Text'],
	470	+ 'funder' => ['Organization', 'Person'],
	471	+ 'inLanguage' => ['Language', 'Text'],
472	472	'isAccessibleForFree' => ['Boolean'],
473		- 'location' => ['Place','PostalAddress','Text','VirtualLocation'],
	473	+ 'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
474	474	'maximumAttendeeCapacity' => ['Integer'],
475	475	'maximumPhysicalAttendeeCapacity' => ['Integer'],
476	476	'maximumVirtualAttendeeCapacity' => ['Integer'],
477		- 'offers' => ['Demand','Offer'],
478		- 'organizer' => ['Organization','Person'],
479		- 'performer' => ['Organization','Person'],
	477	+ 'offers' => ['Demand', 'Offer'],
	478	+ 'organizer' => ['Organization', 'Person'],
	479	+ 'performer' => ['Organization', 'Person'],
480	480	'previousStartDate' => ['Date'],
481	481	'recordedIn' => ['CreativeWork'],
482	482	'remainingAttendeeCapacity' => ['Integer'],
483	483	'review' => ['Review'],
484		- 'sponsor' => ['Organization','Person'],
485		- 'startDate' => ['Date','DateTime'],
	484	+ 'sponsor' => ['Organization', 'Person'],
	485	+ 'startDate' => ['Date', 'DateTime'],
486	486	'subEvent' => ['Event'],
487	487	'superEvent' => ['Event'],
488		- 'translator' => ['Organization','Person'],
	488	+ 'translator' => ['Organization', 'Person'],
489	489	'typicalAgeRange' => ['Text'],
490	490	'workFeatured' => ['CreativeWork'],
491	491	'workPerformed' => ['CreativeWork']
		@@ -593,7 +593,7 @@ discard block
		block discarded – undo
593	593	{
594	594	$rules = parent::rules();
595	595	$rules = array_merge($rules, [
596		- [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventAttendanceMode','eventSchedule','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','maximumPhysicalAttendeeCapacity','maximumVirtualAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
	596	+ [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventAttendanceMode', 'eventSchedule', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'maximumPhysicalAttendeeCapacity', 'maximumVirtualAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
597	597	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
598	598	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
599	599	]);

		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	* @var array
137	137	*/
138	138	static protected $_schemaPropertyExpectedTypes = [
139		- 'partySize' => ['Integer','QuantitativeValue'],
	139	+ 'partySize' => ['Integer', 'QuantitativeValue'],
140	140	'pickupLocation' => ['Place'],
141	141	'pickupTime' => ['DateTime']
142	142	];
		@@ -210,7 +210,7 @@ discard block
		block discarded – undo
210	210	{
211	211	$rules = parent::rules();
212	212	$rules = array_merge($rules, [
213		- [['partySize','pickupLocation','pickupTime'], 'validateJsonSchema'],
	213	+ [['partySize', 'pickupLocation', 'pickupTime'], 'validateJsonSchema'],
214	214	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
215	215	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
216	216	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

		@@ -127,7 +127,7 @@ discard block
		block discarded – undo
127	127	*/
128	128	static protected $_schemaPropertyExpectedTypes = [
129	129	'numTracks' => ['Integer'],
130		- 'track' => ['ItemList','MusicRecording']
	130	+ 'track' => ['ItemList', 'MusicRecording']
131	131	];
132	132
133	133	/**
		@@ -198,7 +198,7 @@ discard block
		block discarded – undo
198	198	{
199	199	$rules = parent::rules();
200	200	$rules = array_merge($rules, [
201		- [['numTracks','track'], 'validateJsonSchema'],
	201	+ [['numTracks', 'track'], 'validateJsonSchema'],
202	202	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
203	203	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
204	204	]);

		@@ -119,7 +119,7 @@
		block discarded – undo
119	119	* @var array
120	120	*/
121	121	static protected $_schemaPropertyExpectedTypes = [
122		- 'recipient' => ['Audience','ContactPoint','Organization','Person']
	122	+ 'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
123	123	];
124	124
125	125	/**

		@@ -237,7 +237,7 @@
		block discarded – undo
237	237	{
238	238	$rules = parent::rules();
239	239	$rules = array_merge($rules, [
240		- [['abridged','bookEdition','bookFormat','illustrator','isbn','numberOfPages'], 'validateJsonSchema'],
	240	+ [['abridged', 'bookEdition', 'bookFormat', 'illustrator', 'isbn', 'numberOfPages'], 'validateJsonSchema'],
241	241	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
242	242	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
243	243	]);

		@@ -118,7 +118,7 @@
		block discarded – undo
118	118	* @var array
119	119	*/
120	120	static protected $_schemaPropertyExpectedTypes = [
121		- 'feesAndCommissionsSpecification' => ['Text','URL']
	121	+ 'feesAndCommissionsSpecification' => ['Text', 'URL']
122	122	];
123	123
124	124	/**

nystudio107 / craft-seomatic

Push — v3 ( 6054b6...238b69 )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch