Inspection of "Merge branch 'release/3.4.30' into v3" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v3 ( 6054b6...238b69 )

by Andrew

created 2022-04-18 22:16 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -127,7 +127,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'baseSalary' => ['MonetaryAmount','Number','PriceSpecification'],
+        'baseSalary' => ['MonetaryAmount', 'Number', 'PriceSpecification'],
         'salaryCurrency' => ['Text']
     ];
 
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['baseSalary','salaryCurrency'], 'validateJsonSchema'],
+            [['baseSalary', 'salaryCurrency'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Action.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -222,15 +222,15 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
-        'endTime' => ['DateTime','Time'],
+        'agent' => ['Organization', 'Person'],
+        'endTime' => ['DateTime', 'Time'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text','VirtualLocation'],
+        'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
-        'startTime' => ['DateTime','Time'],
+        'startTime' => ['DateTime', 'Time'],
         'target' => ['EntryPoint']
     ];
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/BikeStore.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/TireShop.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/RejectAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -222,15 +222,15 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
-        'endTime' => ['DateTime','Time'],
+        'agent' => ['Organization', 'Person'],
+        'endTime' => ['DateTime', 'Time'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text','VirtualLocation'],
+        'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
-        'startTime' => ['DateTime','Time'],
+        'startTime' => ['DateTime', 'Time'],
         'target' => ['EntryPoint']
     ];
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/ParcelService.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/MovieClip.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -189,10 +189,10 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actor' => ['Person'],
-        'clipNumber' => ['Integer','Text'],
+        'clipNumber' => ['Integer', 'Text'],
         'director' => ['Person'],
         'endOffset' => ['Number'],
-        'musicBy' => ['MusicGroup','Person'],
+        'musicBy' => ['MusicGroup', 'Person'],
         'partOfEpisode' => ['Episode'],
         'partOfSeason' => ['CreativeWorkSeason'],
         'partOfSeries' => ['CreativeWorkSeries'],
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actor','clipNumber','director','endOffset','musicBy','partOfEpisode','partOfSeason','partOfSeries','startOffset'], 'validateJsonSchema'],
+            [['actor', 'clipNumber', 'director', 'endOffset', 'musicBy', 'partOfEpisode', 'partOfSeason', 'partOfSeries', 'startOffset'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/HowToItem.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'requiredQuantity' => ['Number','QuantitativeValue','Text']
+        'requiredQuantity' => ['Number', 'QuantitativeValue', 'Text']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/Date.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

		@@ -222,15 +222,15 @@ discard block
		block discarded – undo
222	222	*/
223	223	static protected $_schemaPropertyExpectedTypes = [
224	224	'actionStatus' => ['ActionStatusType'],
225		- 'agent' => ['Organization','Person'],
226		- 'endTime' => ['DateTime','Time'],
	225	+ 'agent' => ['Organization', 'Person'],
	226	+ 'endTime' => ['DateTime', 'Time'],
227	227	'error' => ['Thing'],
228	228	'instrument' => ['Thing'],
229		- 'location' => ['Place','PostalAddress','Text','VirtualLocation'],
	229	+ 'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
230	230	'object' => ['Thing'],
231		- 'participant' => ['Organization','Person'],
	231	+ 'participant' => ['Organization', 'Person'],
232	232	'result' => ['Thing'],
233		- 'startTime' => ['DateTime','Time'],
	233	+ 'startTime' => ['DateTime', 'Time'],
234	234	'target' => ['EntryPoint']
235	235	];
236	236
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	{
312	312	$rules = parent::rules();
313	313	$rules = array_merge($rules, [
314		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	314	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
315	315	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
316	316	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
317	317	]);

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -222,15 +222,15 @@ discard block
		block discarded – undo
222	222	*/
223	223	static protected $_schemaPropertyExpectedTypes = [
224	224	'actionStatus' => ['ActionStatusType'],
225		- 'agent' => ['Organization','Person'],
226		- 'endTime' => ['DateTime','Time'],
	225	+ 'agent' => ['Organization', 'Person'],
	226	+ 'endTime' => ['DateTime', 'Time'],
227	227	'error' => ['Thing'],
228	228	'instrument' => ['Thing'],
229		- 'location' => ['Place','PostalAddress','Text','VirtualLocation'],
	229	+ 'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
230	230	'object' => ['Thing'],
231		- 'participant' => ['Organization','Person'],
	231	+ 'participant' => ['Organization', 'Person'],
232	232	'result' => ['Thing'],
233		- 'startTime' => ['DateTime','Time'],
	233	+ 'startTime' => ['DateTime', 'Time'],
234	234	'target' => ['EntryPoint']
235	235	];
236	236
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	{
312	312	$rules = parent::rules();
313	313	$rules = array_merge($rules, [
314		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	314	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
315	315	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
316	316	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
317	317	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -127,7 +127,7 @@ discard block
		block discarded – undo
127	127	* @var array
128	128	*/
129	129	static protected $_schemaPropertyExpectedTypes = [
130		- 'baseSalary' => ['MonetaryAmount','Number','PriceSpecification'],
	130	+ 'baseSalary' => ['MonetaryAmount', 'Number', 'PriceSpecification'],
131	131	'salaryCurrency' => ['Text']
132	132	];
133	133
		@@ -199,7 +199,7 @@ discard block
		block discarded – undo
199	199	{
200	200	$rules = parent::rules();
201	201	$rules = array_merge($rules, [
202		- [['baseSalary','salaryCurrency'], 'validateJsonSchema'],
	202	+ [['baseSalary', 'salaryCurrency'], 'validateJsonSchema'],
203	203	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
204	204	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
205	205	]);

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

		@@ -189,10 +189,10 @@ discard block
		block discarded – undo
189	189	*/
190	190	static protected $_schemaPropertyExpectedTypes = [
191	191	'actor' => ['Person'],
192		- 'clipNumber' => ['Integer','Text'],
	192	+ 'clipNumber' => ['Integer', 'Text'],
193	193	'director' => ['Person'],
194	194	'endOffset' => ['Number'],
195		- 'musicBy' => ['MusicGroup','Person'],
	195	+ 'musicBy' => ['MusicGroup', 'Person'],
196	196	'partOfEpisode' => ['Episode'],
197	197	'partOfSeason' => ['CreativeWorkSeason'],
198	198	'partOfSeries' => ['CreativeWorkSeries'],
		@@ -274,7 +274,7 @@ discard block
		block discarded – undo
274	274	{
275	275	$rules = parent::rules();
276	276	$rules = array_merge($rules, [
277		- [['actor','clipNumber','director','endOffset','musicBy','partOfEpisode','partOfSeason','partOfSeries','startOffset'], 'validateJsonSchema'],
	277	+ [['actor', 'clipNumber', 'director', 'endOffset', 'musicBy', 'partOfEpisode', 'partOfSeason', 'partOfSeries', 'startOffset'], 'validateJsonSchema'],
278	278	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
279	279	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
280	280	]);

		@@ -118,7 +118,7 @@
		block discarded – undo
118	118	* @var array
119	119	*/
120	120	static protected $_schemaPropertyExpectedTypes = [
121		- 'requiredQuantity' => ['Number','QuantitativeValue','Text']
	121	+ 'requiredQuantity' => ['Number', 'QuantitativeValue', 'Text']
122	122	];
123	123
124	124	/**

nystudio107 / craft-seomatic

Push — v3 ( 6054b6...238b69 )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch