Inspection of "Merge branch 'release/3.4.30' into v3" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v3 ( 6054b6...238b69 )

by Andrew

created 2022-04-18 22:16 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/LodgingBusiness.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -191,11 +191,11 @@  discard block
 block discarded – undo
     static protected $_schemaPropertyExpectedTypes = [
         'amenityFeature' => ['LocationFeatureSpecification'],
         'audience' => ['Audience'],
-        'availableLanguage' => ['Language','Text'],
-        'checkinTime' => ['DateTime','Time'],
-        'checkoutTime' => ['DateTime','Time'],
-        'numberOfRooms' => ['Number','QuantitativeValue'],
-        'petsAllowed' => ['Boolean','Text'],
+        'availableLanguage' => ['Language', 'Text'],
+        'checkinTime' => ['DateTime', 'Time'],
+        'checkoutTime' => ['DateTime', 'Time'],
+        'numberOfRooms' => ['Number', 'QuantitativeValue'],
+        'petsAllowed' => ['Boolean', 'Text'],
         'starRating' => ['Rating']
     ];
 
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['amenityFeature','audience','availableLanguage','checkinTime','checkoutTime','numberOfRooms','petsAllowed','starRating'], 'validateJsonSchema'],
+            [['amenityFeature', 'audience', 'availableLanguage', 'checkinTime', 'checkoutTime', 'numberOfRooms', 'petsAllowed', 'starRating'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/DownloadAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -202,7 +202,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['fromLocation','toLocation'], 'validateJsonSchema'],
+            [['fromLocation', 'toLocation'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Campground.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Corporation.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/BusReservation.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -220,17 +220,17 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'bookingTime' => ['DateTime'],
-        'broker' => ['Organization','Person'],
+        'broker' => ['Organization', 'Person'],
         'modifiedTime' => ['DateTime'],
         'priceCurrency' => ['Text'],
         'programMembershipUsed' => ['ProgramMembership'],
-        'provider' => ['Organization','Person'],
+        'provider' => ['Organization', 'Person'],
         'reservationFor' => ['Thing'],
         'reservationId' => ['Text'],
         'reservationStatus' => ['ReservationStatusType'],
         'reservedTicket' => ['Ticket'],
-        'totalPrice' => ['Number','PriceSpecification','Text'],
-        'underName' => ['Organization','Person']
+        'totalPrice' => ['Number', 'PriceSpecification', 'Text'],
+        'underName' => ['Organization', 'Person']
     ];
 
     /**
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['bookingTime','broker','modifiedTime','priceCurrency','programMembershipUsed','provider','reservationFor','reservationId','reservationStatus','reservedTicket','totalPrice','underName'], 'validateJsonSchema'],
+            [['bookingTime', 'broker', 'modifiedTime', 'priceCurrency', 'programMembershipUsed', 'provider', 'reservationFor', 'reservationId', 'reservationStatus', 'reservedTicket', 'totalPrice', 'underName'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/WPHeader.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -201,7 +201,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['cssSelector','xpath'], 'validateJsonSchema'],
+            [['cssSelector', 'xpath'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Attorney.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/CourseInstance.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -143,7 +143,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'courseMode' => ['Text','URL'],
+        'courseMode' => ['Text', 'URL'],
         'courseWorkload' => ['Text'],
         'instructor' => ['Person']
     ];
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['courseMode','courseWorkload','instructor'], 'validateJsonSchema'],
+            [['courseMode', 'courseWorkload', 'instructor'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -202,7 +202,7 @@
		block discarded – undo
202	202	{
203	203	$rules = parent::rules();
204	204	$rules = array_merge($rules, [
205		- [['fromLocation','toLocation'], 'validateJsonSchema'],
	205	+ [['fromLocation', 'toLocation'], 'validateJsonSchema'],
206	206	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
207	207	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
208	208	]);

		@@ -220,17 +220,17 @@ discard block
		block discarded – undo
220	220	*/
221	221	static protected $_schemaPropertyExpectedTypes = [
222	222	'bookingTime' => ['DateTime'],
223		- 'broker' => ['Organization','Person'],
	223	+ 'broker' => ['Organization', 'Person'],
224	224	'modifiedTime' => ['DateTime'],
225	225	'priceCurrency' => ['Text'],
226	226	'programMembershipUsed' => ['ProgramMembership'],
227		- 'provider' => ['Organization','Person'],
	227	+ 'provider' => ['Organization', 'Person'],
228	228	'reservationFor' => ['Thing'],
229	229	'reservationId' => ['Text'],
230	230	'reservationStatus' => ['ReservationStatusType'],
231	231	'reservedTicket' => ['Ticket'],
232		- 'totalPrice' => ['Number','PriceSpecification','Text'],
233		- 'underName' => ['Organization','Person']
	232	+ 'totalPrice' => ['Number', 'PriceSpecification', 'Text'],
	233	+ 'underName' => ['Organization', 'Person']
234	234	];
235	235
236	236	/**
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	{
312	312	$rules = parent::rules();
313	313	$rules = array_merge($rules, [
314		- [['bookingTime','broker','modifiedTime','priceCurrency','programMembershipUsed','provider','reservationFor','reservationId','reservationStatus','reservedTicket','totalPrice','underName'], 'validateJsonSchema'],
	314	+ [['bookingTime', 'broker', 'modifiedTime', 'priceCurrency', 'programMembershipUsed', 'provider', 'reservationFor', 'reservationId', 'reservationStatus', 'reservedTicket', 'totalPrice', 'underName'], 'validateJsonSchema'],
315	315	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
316	316	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
317	317	]);

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -191,11 +191,11 @@ discard block
		block discarded – undo
191	191	static protected $_schemaPropertyExpectedTypes = [
192	192	'amenityFeature' => ['LocationFeatureSpecification'],
193	193	'audience' => ['Audience'],
194		- 'availableLanguage' => ['Language','Text'],
195		- 'checkinTime' => ['DateTime','Time'],
196		- 'checkoutTime' => ['DateTime','Time'],
197		- 'numberOfRooms' => ['Number','QuantitativeValue'],
198		- 'petsAllowed' => ['Boolean','Text'],
	194	+ 'availableLanguage' => ['Language', 'Text'],
	195	+ 'checkinTime' => ['DateTime', 'Time'],
	196	+ 'checkoutTime' => ['DateTime', 'Time'],
	197	+ 'numberOfRooms' => ['Number', 'QuantitativeValue'],
	198	+ 'petsAllowed' => ['Boolean', 'Text'],
199	199	'starRating' => ['Rating']
200	200	];
201	201
		@@ -273,7 +273,7 @@ discard block
		block discarded – undo
273	273	{
274	274	$rules = parent::rules();
275	275	$rules = array_merge($rules, [
276		- [['amenityFeature','audience','availableLanguage','checkinTime','checkoutTime','numberOfRooms','petsAllowed','starRating'], 'validateJsonSchema'],
	276	+ [['amenityFeature', 'audience', 'availableLanguage', 'checkinTime', 'checkoutTime', 'numberOfRooms', 'petsAllowed', 'starRating'], 'validateJsonSchema'],
277	277	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
278	278	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
279	279	]);

		@@ -201,7 +201,7 @@
		block discarded – undo
201	201	{
202	202	$rules = parent::rules();
203	203	$rules = array_merge($rules, [
204		- [['cssSelector','xpath'], 'validateJsonSchema'],
	204	+ [['cssSelector', 'xpath'], 'validateJsonSchema'],
205	205	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
206	206	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
207	207	]);

		@@ -143,7 +143,7 @@ discard block
		block discarded – undo
143	143	* @var array
144	144	*/
145	145	static protected $_schemaPropertyExpectedTypes = [
146		- 'courseMode' => ['Text','URL'],
	146	+ 'courseMode' => ['Text', 'URL'],
147	147	'courseWorkload' => ['Text'],
148	148	'instructor' => ['Person']
149	149	];
		@@ -217,7 +217,7 @@ discard block
		block discarded – undo
217	217	{
218	218	$rules = parent::rules();
219	219	$rules = array_merge($rules, [
220		- [['courseMode','courseWorkload','instructor'], 'validateJsonSchema'],
	220	+ [['courseMode', 'courseWorkload', 'instructor'], 'validateJsonSchema'],
221	221	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
222	222	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
223	223	]);

nystudio107 / craft-seomatic

Push — v3 ( 6054b6...238b69 )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch