Inspection of "Merge branch 'release/3.4.30' into v3" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v3 ( 6054b6...238b69 )

by Andrew

created 2022-04-18 22:16 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/BookSeries.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -138,9 +138,9 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'endDate' => ['Date','DateTime'],
+        'endDate' => ['Date', 'DateTime'],
         'issn' => ['Text'],
-        'startDate' => ['Date','DateTime']
+        'startDate' => ['Date', 'DateTime']
     ];
 
     /**
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['endDate','issn','startDate'], 'validateJsonSchema'],
+            [['endDate', 'issn', 'startDate'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/AuthorizeAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -119,7 +119,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'recipient' => ['Audience','ContactPoint','Organization','Person']
+        'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/Quantity.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -229,13 +229,13 @@  discard block
 block discarded – undo
         'alternateName' => ['Text'],
         'description' => ['Text'],
         'disambiguatingDescription' => ['Text'],
-        'identifier' => ['PropertyValue','Text','URL'],
-        'image' => ['ImageObject','URL'],
-        'mainEntityOfPage' => ['CreativeWork','URL'],
+        'identifier' => ['PropertyValue', 'Text', 'URL'],
+        'image' => ['ImageObject', 'URL'],
+        'mainEntityOfPage' => ['CreativeWork', 'URL'],
         'name' => ['Text'],
         'potentialAction' => ['Action'],
         'sameAs' => ['URL'],
-        'subjectOf' => ['CreativeWork','Event'],
+        'subjectOf' => ['CreativeWork', 'Event'],
         'url' => ['URL']
     ];
 
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['additionalType','alternateName','description','disambiguatingDescription','identifier','image','mainEntityOfPage','name','potentialAction','sameAs','subjectOf','url'], 'validateJsonSchema'],
+            [['additionalType', 'alternateName', 'description', 'disambiguatingDescription', 'identifier', 'image', 'mainEntityOfPage', 'name', 'potentialAction', 'sameAs', 'subjectOf', 'url'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Physician.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -133,7 +133,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'availableService' => ['MedicalProcedure','MedicalTest','MedicalTherapy'],
+        'availableService' => ['MedicalProcedure', 'MedicalTest', 'MedicalTherapy'],
         'hospitalAffiliation' => ['Hospital'],
         'medicalSpecialty' => ['MedicalSpecialty']
     ];
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['availableService','hospitalAffiliation','medicalSpecialty'], 'validateJsonSchema'],
+            [['availableService', 'hospitalAffiliation', 'medicalSpecialty'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/QuoteAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -150,7 +150,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'price' => ['Number','Text'],
+        'price' => ['Number', 'Text'],
         'priceCurrency' => ['Text'],
         'priceSpecification' => ['PriceSpecification']
     ];
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['price','priceCurrency','priceSpecification'], 'validateJsonSchema'],
+            [['price', 'priceCurrency', 'priceSpecification'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/BreadcrumbList.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -152,8 +152,8 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'itemListElement' => ['ListItem','Text','Thing'],
-        'itemListOrder' => ['ItemListOrderType','Text'],
+        'itemListElement' => ['ListItem', 'Text', 'Thing'],
+        'itemListOrder' => ['ItemListOrderType', 'Text'],
         'numberOfItems' => ['Integer']
     ];
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['itemListElement','itemListOrder','numberOfItems'], 'validateJsonSchema'],
+            [['itemListElement', 'itemListOrder', 'numberOfItems'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/BlogPosting.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Restaurant.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -147,8 +147,8 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'acceptsReservations' => ['Boolean','Text','URL'],
-        'hasMenu' => ['Menu','Text','URL'],
+        'acceptsReservations' => ['Boolean', 'Text', 'URL'],
+        'hasMenu' => ['Menu', 'Text', 'URL'],
         'servesCuisine' => ['Text'],
         'starRating' => ['Rating']
     ];
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
+            [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -138,9 +138,9 @@ discard block
		block discarded – undo
138	138	* @var array
139	139	*/
140	140	static protected $_schemaPropertyExpectedTypes = [
141		- 'endDate' => ['Date','DateTime'],
	141	+ 'endDate' => ['Date', 'DateTime'],
142	142	'issn' => ['Text'],
143		- 'startDate' => ['Date','DateTime']
	143	+ 'startDate' => ['Date', 'DateTime']
144	144	];
145	145
146	146	/**
		@@ -212,7 +212,7 @@ discard block
		block discarded – undo
212	212	{
213	213	$rules = parent::rules();
214	214	$rules = array_merge($rules, [
215		- [['endDate','issn','startDate'], 'validateJsonSchema'],
	215	+ [['endDate', 'issn', 'startDate'], 'validateJsonSchema'],
216	216	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
217	217	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
218	218	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -119,7 +119,7 @@
		block discarded – undo
119	119	* @var array
120	120	*/
121	121	static protected $_schemaPropertyExpectedTypes = [
122		- 'recipient' => ['Audience','ContactPoint','Organization','Person']
	122	+ 'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
123	123	];
124	124
125	125	/**

		@@ -229,13 +229,13 @@ discard block
		block discarded – undo
229	229	'alternateName' => ['Text'],
230	230	'description' => ['Text'],
231	231	'disambiguatingDescription' => ['Text'],
232		- 'identifier' => ['PropertyValue','Text','URL'],
233		- 'image' => ['ImageObject','URL'],
234		- 'mainEntityOfPage' => ['CreativeWork','URL'],
	232	+ 'identifier' => ['PropertyValue', 'Text', 'URL'],
	233	+ 'image' => ['ImageObject', 'URL'],
	234	+ 'mainEntityOfPage' => ['CreativeWork', 'URL'],
235	235	'name' => ['Text'],
236	236	'potentialAction' => ['Action'],
237	237	'sameAs' => ['URL'],
238		- 'subjectOf' => ['CreativeWork','Event'],
	238	+ 'subjectOf' => ['CreativeWork', 'Event'],
239	239	'url' => ['URL']
240	240	];
241	241
		@@ -317,7 +317,7 @@ discard block
		block discarded – undo
317	317	{
318	318	$rules = parent::rules();
319	319	$rules = array_merge($rules, [
320		- [['additionalType','alternateName','description','disambiguatingDescription','identifier','image','mainEntityOfPage','name','potentialAction','sameAs','subjectOf','url'], 'validateJsonSchema'],
	320	+ [['additionalType', 'alternateName', 'description', 'disambiguatingDescription', 'identifier', 'image', 'mainEntityOfPage', 'name', 'potentialAction', 'sameAs', 'subjectOf', 'url'], 'validateJsonSchema'],
321	321	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
322	322	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
323	323	]);

		@@ -133,7 +133,7 @@ discard block
		block discarded – undo
133	133	* @var array
134	134	*/
135	135	static protected $_schemaPropertyExpectedTypes = [
136		- 'availableService' => ['MedicalProcedure','MedicalTest','MedicalTherapy'],
	136	+ 'availableService' => ['MedicalProcedure', 'MedicalTest', 'MedicalTherapy'],
137	137	'hospitalAffiliation' => ['Hospital'],
138	138	'medicalSpecialty' => ['MedicalSpecialty']
139	139	];
		@@ -207,7 +207,7 @@ discard block
		block discarded – undo
207	207	{
208	208	$rules = parent::rules();
209	209	$rules = array_merge($rules, [
210		- [['availableService','hospitalAffiliation','medicalSpecialty'], 'validateJsonSchema'],
	210	+ [['availableService', 'hospitalAffiliation', 'medicalSpecialty'], 'validateJsonSchema'],
211	211	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
212	212	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
213	213	]);

		@@ -150,7 +150,7 @@ discard block
		block discarded – undo
150	150	* @var array
151	151	*/
152	152	static protected $_schemaPropertyExpectedTypes = [
153		- 'price' => ['Number','Text'],
	153	+ 'price' => ['Number', 'Text'],
154	154	'priceCurrency' => ['Text'],
155	155	'priceSpecification' => ['PriceSpecification']
156	156	];
		@@ -224,7 +224,7 @@ discard block
		block discarded – undo
224	224	{
225	225	$rules = parent::rules();
226	226	$rules = array_merge($rules, [
227		- [['price','priceCurrency','priceSpecification'], 'validateJsonSchema'],
	227	+ [['price', 'priceCurrency', 'priceSpecification'], 'validateJsonSchema'],
228	228	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
229	229	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
230	230	]);

		@@ -152,8 +152,8 @@ discard block
		block discarded – undo
152	152	* @var array
153	153	*/
154	154	static protected $_schemaPropertyExpectedTypes = [
155		- 'itemListElement' => ['ListItem','Text','Thing'],
156		- 'itemListOrder' => ['ItemListOrderType','Text'],
	155	+ 'itemListElement' => ['ListItem', 'Text', 'Thing'],
	156	+ 'itemListOrder' => ['ItemListOrderType', 'Text'],
157	157	'numberOfItems' => ['Integer']
158	158	];
159	159
		@@ -226,7 +226,7 @@ discard block
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['itemListElement','itemListOrder','numberOfItems'], 'validateJsonSchema'],
	229	+ [['itemListElement', 'itemListOrder', 'numberOfItems'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -147,8 +147,8 @@ discard block
		block discarded – undo
147	147	* @var array
148	148	*/
149	149	static protected $_schemaPropertyExpectedTypes = [
150		- 'acceptsReservations' => ['Boolean','Text','URL'],
151		- 'hasMenu' => ['Menu','Text','URL'],
	150	+ 'acceptsReservations' => ['Boolean', 'Text', 'URL'],
	151	+ 'hasMenu' => ['Menu', 'Text', 'URL'],
152	152	'servesCuisine' => ['Text'],
153	153	'starRating' => ['Rating']
154	154	];
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	{
224	224	$rules = parent::rules();
225	225	$rules = array_merge($rules, [
226		- [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
	226	+ [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
227	227	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
228	228	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
229	229	]);

nystudio107 / craft-seomatic

Push — v3 ( 6054b6...238b69 )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch