nystudio107\seomatic\helpers\Autocomplete

Complexity

Total Complexity

87

Size/Duplication

Total Lines	468
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getBehaviorCompletion()	0	6	3
A	overrideValues()	0	5	1
C	generate()	0	52	13
F	getMethodCompletion()	0	79	18
A	getComponentCompletion()	0	12	5
B	getClassCompletion()	0	30	6
A	elementRouteVariables()	0	13	4
F	getPropertyCompletion()	0	101	36
A	parseObject()	0	16	1

<?php
/**
 * SEOmatic plugin for Craft CMS 3.x
 *
 * @link      https://nystudio107.com/
 * @copyright Copyright (c) 2021 nystudio107
 * @license   https://nystudio107.com/license

@license tag must contain a URL and a license name

 */

namespace nystudio107\seomatic\helpers;

use Craft;
use craft\base\Element;
use craft\helpers\ArrayHelper;

This use statement conflicts with another class in this namespace, nystudio107\seomatic\helpers\ArrayHelper. Consider defining an alias.

use phpDocumentor\Reflection\DocBlockFactory;
use ReflectionClass;
use ReflectionException;
use ReflectionNamedType;
use ReflectionUnionType;
use yii\base\Behavior;
use yii\base\InvalidConfigException;
use yii\di\ServiceLocator;

/**
 * @author    nystudio107

The tag in position 1 should be the @package tag

Content of the @author tag must be in the form "Display Name <username@example.com>"

 * @package   Seomatic
 * @since     3.4.21
 */
class Autocomplete
{
    // Constants
    // =========================================================================

    const COMPLETION_KEY = '__completions';
    const EXCLUDED_PROPERTY_NAMES = [
        'controller',
        'Controller',
        'CraftEdition',
        'CraftSolo',
        'CraftPro',
    ];
    const EXCLUDED_BEHAVIOR_NAMES = [
        'fieldHandles',
        'hasMethods',
        'owner',
    ];
    const ELEMENT_ROUTE_EXCLUDES = [
        'matrixblock',
        'globalset'
    ];
    const EXCLUDED_PROPERTY_REGEXES = [
        '^_',
    ];
    const EXCLUDED_METHOD_REGEXES = [
        '^_',
    ];

    // Faux enum, from: https://microsoft.github.io/monaco-editor/api/enums/monaco.languages.completionitemkind.html
    const CompletionItemKind = [

This class constant is not uppercase (expected COMPLETIONITEMKIND).

        'Class' => 5,
        'Color' => 19,
        'Constant' => 14,
        'Constructor' => 2,
        'Customcolor' => 22,
        'Enum' => 15,
        'EnumMember' => 16,
        'Event' => 10,
        'Field' => 3,
        'File' => 20,
        'Folder' => 23,
        'Function' => 1,
        'Interface' => 7,
        'Issue' => 26,
        'Keyword' => 17,
        'Method' => 0,
        'Module' => 8,
        'Operator' => 11,
        'Property' => 9,
        'Reference' => 21,
        'Snippet' => 27,
        'Struct' => 6,
        'Text' => 18,
        'TypeParameter' => 24,
        'Unit' => 12,
        'User' => 25,
        'Value' => 13,
        'Variable' => 4,
    ];

    // Public Static Methods
    // =========================================================================

    /**
     * Core function that generates the autocomplete array
     * @param null $additionalCompletionsCacheKey

Are you sure the doc-type for parameter $additionalCompletionsCacheKey is correct as it would always require null to be passed?

There must be exactly one blank line before the tags in a doc comment

Missing parameter comment

     * @return array

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public static function generate($additionalCompletionsCacheKey = null): array
    {
        $completionList = [];
        // Iterate through the globals in the Twig context
        /* @noinspection PhpInternalEntityUsedInspection */
        $globals = array_merge(
            Craft::$app->view->getTwig()->getGlobals(),
            self::elementRouteVariables(),
            self::overrideValues()
        );
        foreach ($globals as $key => $value) {
            if (!in_array($key, self::EXCLUDED_PROPERTY_NAMES, true)) {
                $type = gettype($value);
                switch ($type) {
                    case 'object':

Line indented incorrectly; expected 16 spaces, found 20

                        self::parseObject($completionList, $key, $value);
                        break;

                    case 'array':

Line indented incorrectly; expected 16 spaces, found 20

                    case 'boolean':

Line indented incorrectly; expected 16 spaces, found 20

                    case 'double':

Line indented incorrectly; expected 16 spaces, found 20

                    case 'integer':

Line indented incorrectly; expected 16 spaces, found 20

                    case 'string':

Line indented incorrectly; expected 16 spaces, found 20

                        $kind = self::CompletionItemKind['Variable'];
                        $path = $key;
                        $normalizedKey = preg_replace("/[^A-Za-z]/", '', $key);
                        if (ctype_upper($normalizedKey)) {

Line indented incorrectly; expected 20 spaces, found 24

                            $kind = self::CompletionItemKind['Constant'];
                        }

Line indented incorrectly; expected 20 spaces, found 24

                        ArrayHelper::setValue($completionList, $path, [
                            self::COMPLETION_KEY => [
                                'detail' => "$value",
                                'kind' => $kind,
                                'label' => $key,
                                'insertText' => $key,
                            ]
                        ]);
                        break;
                }
            }
        }
        // Add in additional completion items from the cache, if present
        if ($additionalCompletionsCacheKey) {

$additionalCompletionsCacheKey is of type null, thus it always evaluated to false.

            $cache = Craft::$app->getCache();
            $additionalCompletions = $cache->get([self::class, $additionalCompletionsCacheKey]);
            if ($additionalCompletions !== false && is_array($additionalCompletions)) {
                $completionList = array_merge($completionList, $additionalCompletions);
            }

        }

        return $completionList;
    }

    /**
     * Parse the object passed in, including any properties or methods
     *
     * @param array $completionList

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

     * @param string $name

Missing parameter comment

     * @param $object

Missing parameter comment

     * @param string $path

Missing parameter comment

     */
    public static function parseObject(array &$completionList, string $name, $object, string $path = '')
    {
        // Create the docblock factory
        $factory = DocBlockFactory::createInstance();

        $path = trim(implode('.', [$path, $name]), '.');
        // The class itself
        self::getClassCompletion($completionList, $object, $factory, $name, $path);
        // ServiceLocator Components
        self::getComponentCompletion($completionList, $object, $path);
        // Class properties
        self::getPropertyCompletion($completionList, $object, $factory, $path);
        // Class methods
        self::getMethodCompletion($completionList, $object, $factory, $path);
        // Behavior properties
        self::getBehaviorCompletion($completionList, $object, $factory, $path);
    }

    // Protected Static Methods
    // =========================================================================

    /**
     * @param array $completionList

Missing parameter comment

Expected 11 spaces after parameter type; 1 found

     * @param $object

Missing parameter comment

     * @param DocBlockFactory $factory

Missing parameter comment

     * @param string $name

Missing parameter comment

Expected 10 spaces after parameter type; 1 found

     * @param $path

Missing parameter comment

     */
    protected static function getClassCompletion(array &$completionList, $object, DocBlockFactory $factory, string $name, $path)
    {
        try {
            $reflectionClass = new ReflectionClass($object);
        } catch (ReflectionException $e) {
            return;
        }
        // Information on the class itself
        $className = $reflectionClass->getName();
        $docs = $reflectionClass->getDocComment();
        if ($docs) {
            $docblock = $factory->create($docs);
            if ($docblock) {

$docblock is of type phpDocumentor\Reflection\DocBlock, thus it always evaluated to true.

                $summary = $docblock->getSummary();
                if (!empty($summary)) {
                    $docs = $summary;
                }
                $description = $docblock->getDescription()->render();
                if (!empty($description)) {
                    $docs = $description;
                }
            }
        }
        ArrayHelper::setValue($completionList, $path, [
            self::COMPLETION_KEY => [
                'detail' => "$className",
                'documentation' => $docs,
                'kind' => self::CompletionItemKind['Class'],
                'label' => $name,
                'insertText' => $name,
            ]
        ]);
    }

    /**
     * @param array $completionList

Missing parameter comment

     * @param $object

Missing parameter comment

     * @param $path

Missing parameter comment

     */
    protected static function getComponentCompletion(array &$completionList, $object, $path)
    {
        if ($object instanceof ServiceLocator) {
            foreach ($object->getComponents() as $key => $value) {
                $componentObject = null;

The assignment to $componentObject is dead and can be removed.

                try {
                    $componentObject = $object->get($key);
                } catch (InvalidConfigException $e) {
                    // That's okay
                }
                if ($componentObject) {
                    self::parseObject($completionList, $key, $componentObject, $path);
                }
            }
        }
    }

    /**
     * @param array $completionList

Missing parameter comment

Expected 11 spaces after parameter type; 1 found

     * @param $object

Missing parameter comment

     * @param DocBlockFactory $factory

Missing parameter comment

     * @param string $path

Missing parameter comment

Expected 10 spaces after parameter type; 1 found

     */
    protected static function getPropertyCompletion(array &$completionList, $object, DocBlockFactory $factory, string $path)
    {
        try {
            $reflectionClass = new ReflectionClass($object);
        } catch (ReflectionException $e) {
            return;
        }
        $reflectionProperties = $reflectionClass->getProperties();
        $customField = false;
        if ($object instanceof Behavior) {
            $customField = true;
        }
        $sortPrefix = $customField ? '~' : '~~';
        foreach ($reflectionProperties as $reflectionProperty) {
            $propertyName = $reflectionProperty->getName();
            // Exclude some properties
            $propertyAllowed = true;
            foreach (self::EXCLUDED_PROPERTY_REGEXES as $excludePattern) {
                $pattern = '`' . $excludePattern . '`i';
                if (preg_match($pattern, $propertyName) === 1) {
                    $propertyAllowed = false;
                }
            }
            if (in_array($propertyName, self::EXCLUDED_PROPERTY_NAMES, true)) {
                $propertyAllowed = false;
            }
            if ($customField && in_array($propertyName, self::EXCLUDED_BEHAVIOR_NAMES, true)) {
                $propertyAllowed = false;
            }
            // Process the property
            if ($propertyAllowed && $reflectionProperty->isPublic()) {
                $detail = "Property";
                $docblock = null;
                $docs = $reflectionProperty->getDocComment();
                if ($docs) {
                    $docblock = $factory->create($docs);
                    $docs = '';
                    if ($docblock) {
                        $summary = $docblock->getSummary();
                        if (!empty($summary)) {
                            $docs = $summary;
                        }
                        $description = $docblock->getDescription()->render();
                        if (!empty($description)) {
                            $docs = $description;
                        }
                    }
                }
                // Figure out the type
                if ($docblock) {
                    $tag = $docblock->getTagsByName('var');
                    if ($tag && isset($tag[0])) {
                        $detail = strval($tag[0]);
                    }
                }
                if ($detail === "Property") {
                    if (preg_match('/@var\s+([^\s]+)/', $docs, $matches)) {
                        list(, $type) = $matches;
                        $detail = $type;
                    } else {
                        $detail = "Property";
                    }
                }
                if ($detail === "Property") {
                    if ((PHP_MAJOR_VERSION >= 7 && PHP_MINOR_VERSION >= 4) || (PHP_MAJOR_VERSION >= 8)) {
                        if ($reflectionProperty->hasType()) {
                            $reflectionType = $reflectionProperty->getType();
                            if ($reflectionType instanceof ReflectionNamedType) {
                                $type = $reflectionType->getName();
                                $detail = $type;
                            }
                        }
                        if (PHP_MAJOR_VERSION >= 8) {
                            if ($reflectionProperty->hasDefaultValue()) {
                                $value = $reflectionProperty->getDefaultValue();
                                if (is_array($value)) {
                                    $value = json_encode($value);
                                }
                                if (!empty($value)) {
                                    $detail = "$value";
                                }
                            }
                        }
                    }
                }
                $thisPath = trim(implode('.', [$path, $propertyName]), '.');
                $label = $propertyName;
                ArrayHelper::setValue($completionList, $thisPath, [
                    self::COMPLETION_KEY => [
                        'detail' => $detail,
                        'documentation' => $docs,
                        'kind' => $customField ? self::CompletionItemKind['Field'] : self::CompletionItemKind['Property'],
                        'label' => $label,
                        'insertText' => $label,
                        'sortText' => $sortPrefix . $label,
                    ]
                ]);
                // Recurse through if this is an object
                if (isset($object->$propertyName) && is_object($object->$propertyName)) {
                    if (!$customField && !in_array($propertyName, self::EXCLUDED_PROPERTY_NAMES, true)) {
                        self::parseObject($completionList, $propertyName, $object->$propertyName, $path);
                    }
                }
            }
        }
    }

    /**
     * @param array $completionList

Missing parameter comment

Expected 11 spaces after parameter type; 1 found

     * @param $object

Missing parameter comment

     * @param DocBlockFactory $factory

Missing parameter comment

     * @param string $path

Missing parameter comment

Expected 10 spaces after parameter type; 1 found

     */
    protected static function getMethodCompletion(array &$completionList, $object, DocBlockFactory $factory, string $path)
    {
        try {
            $reflectionClass = new ReflectionClass($object);
        } catch (ReflectionException $e) {
            return;
        }
        $reflectionMethods = $reflectionClass->getMethods();
        foreach ($reflectionMethods as $reflectionMethod) {
            $methodName = $reflectionMethod->getName();
            // Exclude some properties
            $methodAllowed = true;
            foreach (self::EXCLUDED_METHOD_REGEXES as $excludePattern) {
                $pattern = '`' . $excludePattern . '`i';
                if (preg_match($pattern, $methodName) === 1) {
                    $methodAllowed = false;
                }
            }
            // Process the method
            if ($methodAllowed && $reflectionMethod->isPublic()) {
                $docblock = null;
                $docs = $reflectionMethod->getDocComment();
                if ($docs) {
                    $docblock = $factory->create($docs);
                    if ($docblock) {
                        $summary = $docblock->getSummary();
                        if (!empty($summary)) {
                            $docs = $summary;
                        }
                        $description = $docblock->getDescription()->render();
                        if (!empty($description)) {
                            $docs = $description;
                        }
                    }
                }
                $detail = $methodName . '(';
                $params = $reflectionMethod->getParameters();
                $paramList = [];
                foreach ($params as $param) {
                    if ($param->hasType()) {
                        $reflectionType = $param->getType();
                        if ($reflectionType instanceof ReflectionUnionType) {
                            $unionTypes = $reflectionType->getTypes();
                            $typeName = '';
                            foreach ($unionTypes as $unionType) {
                                $typeName .= '|' . $unionType->getName();
                            }
                            $typeName = trim($typeName, '|');
                            $paramList[] = $typeName . ': ' . '$' . $param->getName();
                        } else {
                            $paramList[] = $param->getType()->getName() . ': ' . '$' . $param->getName();

The method getName() does not exist on ReflectionType. It seems like you code against a sub-type of ReflectionType such as ReflectionNamedType.

                        }
                    } else {
                        $paramList[] = '$' . $param->getName();
                    }
                }
                $detail .= implode(', ', $paramList) . ')';
                $thisPath = trim(implode('.', [$path, $methodName]), '.');
                $label = $methodName . '()';
                $docsPreamble = '';
                // Figure out the type
                if ($docblock) {
                    $tags = $docblock->getTagsByName('param');
                    if ($tags) {
                        $docsPreamble = "Parameters:\n\n";
                        foreach ($tags as $tag) {
                            $docsPreamble .= $tag . "\n";
                        }
                        $docsPreamble .= "\n";
                    }
                }
                ArrayHelper::setValue($completionList, $thisPath, [
                    self::COMPLETION_KEY => [
                        'detail' => $detail,
                        'documentation' => $docsPreamble . $docs,
                        'kind' => self::CompletionItemKind['Method'],
                        'label' => $label,
                        'insertText' => $label,
                        'sortText' => '~~~' . $label,
                    ]
                ]);
            }
        }
    }

    /**
     * @param array $completionList

Missing parameter comment

Expected 11 spaces after parameter type; 1 found

     * @param $object

Missing parameter comment

     * @param DocBlockFactory $factory

Missing parameter comment

     * @param string $path

Missing parameter comment

Expected 10 spaces after parameter type; 1 found

     */
    protected static function getBehaviorCompletion(array &$completionList, $object, DocBlockFactory $factory, string $path)
    {
        if ($object instanceof Element) {
            $behaviorClass = $object->getBehavior('customFields');
            if ($behaviorClass) {
                self::getPropertyCompletion($completionList, $behaviorClass, $factory, $path);
            }
        }
    }

    // Private Static Methods
    // =========================================================================

    /**
     * Add in the element types that could be injected as route variables
     *
     * @return array
     */
    private static function elementRouteVariables(): array

Private method name "Autocomplete::elementRouteVariables" must be prefixed with an underscore

    {
        $routeVariables = [];
        $elementTypes = Craft::$app->elements->getAllElementTypes();

The method getAllElementTypes() does not exist on null.

        foreach ($elementTypes as $elementType) {
            /* @var Element $elementType */
            $key = $elementType::refHandle();

Are you sure the assignment to $key is correct as $elementType::refHandle() targeting craft\base\Element::refHandle() seems to always return null.

            if (!empty($key) && !in_array($key, static::ELEMENT_ROUTE_EXCLUDES)) {
                $routeVariables[$key] = new $elementType();
            }
        }

        return $routeVariables;
    }

    /**
     * Override certain values that we always want hard-coded
     *
     * @return array
     */
    private static function overrideValues(): array

Private method name "Autocomplete::overrideValues" must be prefixed with an underscore

    {
        return [
            // Set the nonce to a blank string, as it changes on every request
            'nonce' => '',
        ];
    }
}