Inspection of "Do not invalidate meta bundle for drafts and revis..." - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — v3 (#436)

by Ben

created 2019-07-10 07:15 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/TattooParlor.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MusicEvent.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -401,32 +401,32 @@  discard block
 block discarded – undo
         'about' => ['Thing'],
         'actor' => ['Person'],
         'aggregateRating' => ['AggregateRating'],
-        'attendee' => ['Organization','Person'],
+        'attendee' => ['Organization', 'Person'],
         'audience' => ['Audience'],
-        'composer' => ['Organization','Person'],
-        'contributor' => ['Organization','Person'],
+        'composer' => ['Organization', 'Person'],
+        'contributor' => ['Organization', 'Person'],
         'director' => ['Person'],
         'doorTime' => ['DateTime'],
         'duration' => ['Duration'],
-        'endDate' => ['Date','DateTime'],
+        'endDate' => ['Date', 'DateTime'],
         'eventStatus' => ['EventStatusType'],
-        'funder' => ['Organization','Person'],
-        'inLanguage' => ['Language','Text'],
+        'funder' => ['Organization', 'Person'],
+        'inLanguage' => ['Language', 'Text'],
         'isAccessibleForFree' => ['Boolean'],
-        'location' => ['Place','PostalAddress','Text'],
+        'location' => ['Place', 'PostalAddress', 'Text'],
         'maximumAttendeeCapacity' => ['Integer'],
         'offers' => ['Offer'],
-        'organizer' => ['Organization','Person'],
-        'performer' => ['Organization','Person'],
+        'organizer' => ['Organization', 'Person'],
+        'performer' => ['Organization', 'Person'],
         'previousStartDate' => ['Date'],
         'recordedIn' => ['CreativeWork'],
         'remainingAttendeeCapacity' => ['Integer'],
         'review' => ['Review'],
-        'sponsor' => ['Organization','Person'],
-        'startDate' => ['Date','DateTime'],
+        'sponsor' => ['Organization', 'Person'],
+        'startDate' => ['Date', 'DateTime'],
         'subEvent' => ['Event'],
         'superEvent' => ['Event'],
-        'translator' => ['Organization','Person'],
+        'translator' => ['Organization', 'Person'],
         'typicalAgeRange' => ['Text'],
         'workFeatured' => ['CreativeWork'],
         'workPerformed' => ['CreativeWork']
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
+            [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/LiteraryEvent.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -401,32 +401,32 @@  discard block
 block discarded – undo
         'about' => ['Thing'],
         'actor' => ['Person'],
         'aggregateRating' => ['AggregateRating'],
-        'attendee' => ['Organization','Person'],
+        'attendee' => ['Organization', 'Person'],
         'audience' => ['Audience'],
-        'composer' => ['Organization','Person'],
-        'contributor' => ['Organization','Person'],
+        'composer' => ['Organization', 'Person'],
+        'contributor' => ['Organization', 'Person'],
         'director' => ['Person'],
         'doorTime' => ['DateTime'],
         'duration' => ['Duration'],
-        'endDate' => ['Date','DateTime'],
+        'endDate' => ['Date', 'DateTime'],
         'eventStatus' => ['EventStatusType'],
-        'funder' => ['Organization','Person'],
-        'inLanguage' => ['Language','Text'],
+        'funder' => ['Organization', 'Person'],
+        'inLanguage' => ['Language', 'Text'],
         'isAccessibleForFree' => ['Boolean'],
-        'location' => ['Place','PostalAddress','Text'],
+        'location' => ['Place', 'PostalAddress', 'Text'],
         'maximumAttendeeCapacity' => ['Integer'],
         'offers' => ['Offer'],
-        'organizer' => ['Organization','Person'],
-        'performer' => ['Organization','Person'],
+        'organizer' => ['Organization', 'Person'],
+        'performer' => ['Organization', 'Person'],
         'previousStartDate' => ['Date'],
         'recordedIn' => ['CreativeWork'],
         'remainingAttendeeCapacity' => ['Integer'],
         'review' => ['Review'],
-        'sponsor' => ['Organization','Person'],
-        'startDate' => ['Date','DateTime'],
+        'sponsor' => ['Organization', 'Person'],
+        'startDate' => ['Date', 'DateTime'],
         'subEvent' => ['Event'],
         'superEvent' => ['Event'],
-        'translator' => ['Organization','Person'],
+        'translator' => ['Organization', 'Person'],
         'typicalAgeRange' => ['Text'],
         'workFeatured' => ['CreativeWork'],
         'workPerformed' => ['CreativeWork']
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
+            [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MoveAction.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -202,7 +202,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['fromLocation','toLocation'], 'validateJsonSchema'],
+            [['fromLocation', 'toLocation'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MusicStore.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/LegalService.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Bakery.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -147,8 +147,8 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'acceptsReservations' => ['Boolean','Text','URL'],
-        'hasMenu' => ['Menu','Text','URL'],
+        'acceptsReservations' => ['Boolean', 'Text', 'URL'],
+        'hasMenu' => ['Menu', 'Text', 'URL'],
         'servesCuisine' => ['Text'],
         'starRating' => ['Rating']
     ];
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
+            [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MapCategoryType.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -401,32 +401,32 @@ discard block
		block discarded – undo
401	401	'about' => ['Thing'],
402	402	'actor' => ['Person'],
403	403	'aggregateRating' => ['AggregateRating'],
404		- 'attendee' => ['Organization','Person'],
	404	+ 'attendee' => ['Organization', 'Person'],
405	405	'audience' => ['Audience'],
406		- 'composer' => ['Organization','Person'],
407		- 'contributor' => ['Organization','Person'],
	406	+ 'composer' => ['Organization', 'Person'],
	407	+ 'contributor' => ['Organization', 'Person'],
408	408	'director' => ['Person'],
409	409	'doorTime' => ['DateTime'],
410	410	'duration' => ['Duration'],
411		- 'endDate' => ['Date','DateTime'],
	411	+ 'endDate' => ['Date', 'DateTime'],
412	412	'eventStatus' => ['EventStatusType'],
413		- 'funder' => ['Organization','Person'],
414		- 'inLanguage' => ['Language','Text'],
	413	+ 'funder' => ['Organization', 'Person'],
	414	+ 'inLanguage' => ['Language', 'Text'],
415	415	'isAccessibleForFree' => ['Boolean'],
416		- 'location' => ['Place','PostalAddress','Text'],
	416	+ 'location' => ['Place', 'PostalAddress', 'Text'],
417	417	'maximumAttendeeCapacity' => ['Integer'],
418	418	'offers' => ['Offer'],
419		- 'organizer' => ['Organization','Person'],
420		- 'performer' => ['Organization','Person'],
	419	+ 'organizer' => ['Organization', 'Person'],
	420	+ 'performer' => ['Organization', 'Person'],
421	421	'previousStartDate' => ['Date'],
422	422	'recordedIn' => ['CreativeWork'],
423	423	'remainingAttendeeCapacity' => ['Integer'],
424	424	'review' => ['Review'],
425		- 'sponsor' => ['Organization','Person'],
426		- 'startDate' => ['Date','DateTime'],
	425	+ 'sponsor' => ['Organization', 'Person'],
	426	+ 'startDate' => ['Date', 'DateTime'],
427	427	'subEvent' => ['Event'],
428	428	'superEvent' => ['Event'],
429		- 'translator' => ['Organization','Person'],
	429	+ 'translator' => ['Organization', 'Person'],
430	430	'typicalAgeRange' => ['Text'],
431	431	'workFeatured' => ['CreativeWork'],
432	432	'workPerformed' => ['CreativeWork']
		@@ -530,7 +530,7 @@ discard block
		block discarded – undo
530	530	{
531	531	$rules = parent::rules();
532	532	$rules = array_merge($rules, [
533		- [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
	533	+ [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
534	534	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
535	535	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
536	536	]);

		@@ -401,32 +401,32 @@ discard block
		block discarded – undo
401	401	'about' => ['Thing'],
402	402	'actor' => ['Person'],
403	403	'aggregateRating' => ['AggregateRating'],
404		- 'attendee' => ['Organization','Person'],
	404	+ 'attendee' => ['Organization', 'Person'],
405	405	'audience' => ['Audience'],
406		- 'composer' => ['Organization','Person'],
407		- 'contributor' => ['Organization','Person'],
	406	+ 'composer' => ['Organization', 'Person'],
	407	+ 'contributor' => ['Organization', 'Person'],
408	408	'director' => ['Person'],
409	409	'doorTime' => ['DateTime'],
410	410	'duration' => ['Duration'],
411		- 'endDate' => ['Date','DateTime'],
	411	+ 'endDate' => ['Date', 'DateTime'],
412	412	'eventStatus' => ['EventStatusType'],
413		- 'funder' => ['Organization','Person'],
414		- 'inLanguage' => ['Language','Text'],
	413	+ 'funder' => ['Organization', 'Person'],
	414	+ 'inLanguage' => ['Language', 'Text'],
415	415	'isAccessibleForFree' => ['Boolean'],
416		- 'location' => ['Place','PostalAddress','Text'],
	416	+ 'location' => ['Place', 'PostalAddress', 'Text'],
417	417	'maximumAttendeeCapacity' => ['Integer'],
418	418	'offers' => ['Offer'],
419		- 'organizer' => ['Organization','Person'],
420		- 'performer' => ['Organization','Person'],
	419	+ 'organizer' => ['Organization', 'Person'],
	420	+ 'performer' => ['Organization', 'Person'],
421	421	'previousStartDate' => ['Date'],
422	422	'recordedIn' => ['CreativeWork'],
423	423	'remainingAttendeeCapacity' => ['Integer'],
424	424	'review' => ['Review'],
425		- 'sponsor' => ['Organization','Person'],
426		- 'startDate' => ['Date','DateTime'],
	425	+ 'sponsor' => ['Organization', 'Person'],
	426	+ 'startDate' => ['Date', 'DateTime'],
427	427	'subEvent' => ['Event'],
428	428	'superEvent' => ['Event'],
429		- 'translator' => ['Organization','Person'],
	429	+ 'translator' => ['Organization', 'Person'],
430	430	'typicalAgeRange' => ['Text'],
431	431	'workFeatured' => ['CreativeWork'],
432	432	'workPerformed' => ['CreativeWork']
		@@ -530,7 +530,7 @@ discard block
		block discarded – undo
530	530	{
531	531	$rules = parent::rules();
532	532	$rules = array_merge($rules, [
533		- [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
	533	+ [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
534	534	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
535	535	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
536	536	]);

		@@ -202,7 +202,7 @@
		block discarded – undo
202	202	{
203	203	$rules = parent::rules();
204	204	$rules = array_merge($rules, [
205		- [['fromLocation','toLocation'], 'validateJsonSchema'],
	205	+ [['fromLocation', 'toLocation'], 'validateJsonSchema'],
206	206	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
207	207	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
208	208	]);

		@@ -147,8 +147,8 @@ discard block
		block discarded – undo
147	147	* @var array
148	148	*/
149	149	static protected $_schemaPropertyExpectedTypes = [
150		- 'acceptsReservations' => ['Boolean','Text','URL'],
151		- 'hasMenu' => ['Menu','Text','URL'],
	150	+ 'acceptsReservations' => ['Boolean', 'Text', 'URL'],
	151	+ 'hasMenu' => ['Menu', 'Text', 'URL'],
152	152	'servesCuisine' => ['Text'],
153	153	'starRating' => ['Rating']
154	154	];
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	{
224	224	$rules = parent::rules();
225	225	$rules = array_merge($rules, [
226		- [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
	226	+ [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
227	227	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
228	228	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
229	229	]);

nystudio107 / craft-seomatic

Pull Request — v3 (#436)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch