Inspection of "Merge branch 'release/3.3.47' into v3" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v3 ( 01a338...22e12d )

by Andrew

created 2021-08-10 22:06 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -222,15 +222,15 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'actionStatus' => ['ActionStatusType'],
-        'agent' => ['Organization','Person'],
-        'endTime' => ['DateTime','Time'],
+        'agent' => ['Organization', 'Person'],
+        'endTime' => ['DateTime', 'Time'],
         'error' => ['Thing'],
         'instrument' => ['Thing'],
-        'location' => ['Place','PostalAddress','Text','VirtualLocation'],
+        'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
         'object' => ['Thing'],
-        'participant' => ['Organization','Person'],
+        'participant' => ['Organization', 'Person'],
         'result' => ['Thing'],
-        'startTime' => ['DateTime','Time'],
+        'startTime' => ['DateTime', 'Time'],
         'target' => ['EntryPoint']
     ];
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
+            [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/WPSideBar.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -201,7 +201,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['cssSelector','xpath'], 'validateJsonSchema'],
+            [['cssSelector', 'xpath'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/PaymentMethod.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/DepositAccount.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -138,7 +138,7 @@  discard block
 block discarded – undo
     static protected $_schemaPropertyExpectedTypes = [
         'accountMinimumInflow' => ['MonetaryAmount'],
         'accountOverdraftLimit' => ['MonetaryAmount'],
-        'bankAccountType' => ['Text','URL']
+        'bankAccountType' => ['Text', 'URL']
     ];
 
     /**
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['accountMinimumInflow','accountOverdraftLimit','bankAccountType'], 'validateJsonSchema'],
+            [['accountMinimumInflow', 'accountOverdraftLimit', 'bankAccountType'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Invoice.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -241,19 +241,19 @@  discard block
 block discarded – undo
     static protected $_schemaPropertyExpectedTypes = [
         'accountId' => ['Text'],
         'billingPeriod' => ['Duration'],
-        'broker' => ['Organization','Person'],
-        'category' => ['PhysicalActivityCategory','Text','Thing'],
+        'broker' => ['Organization', 'Person'],
+        'category' => ['PhysicalActivityCategory', 'Text', 'Thing'],
         'confirmationNumber' => ['Text'],
-        'customer' => ['Organization','Person'],
-        'minimumPaymentDue' => ['MonetaryAmount','PriceSpecification'],
-        'paymentDueDate' => ['Date','DateTime'],
+        'customer' => ['Organization', 'Person'],
+        'minimumPaymentDue' => ['MonetaryAmount', 'PriceSpecification'],
+        'paymentDueDate' => ['Date', 'DateTime'],
         'paymentMethod' => ['PaymentMethod'],
         'paymentMethodId' => ['Text'],
-        'paymentStatus' => ['PaymentStatusType','Text'],
-        'provider' => ['Organization','Person'],
+        'paymentStatus' => ['PaymentStatusType', 'Text'],
+        'provider' => ['Organization', 'Person'],
         'referencesOrder' => ['Order'],
         'scheduledPaymentDate' => ['Date'],
-        'totalPaymentDue' => ['MonetaryAmount','PriceSpecification']
+        'totalPaymentDue' => ['MonetaryAmount', 'PriceSpecification']
     ];
 
     /**
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['accountId','billingPeriod','broker','category','confirmationNumber','customer','minimumPaymentDue','paymentDueDate','paymentMethod','paymentMethodId','paymentStatus','provider','referencesOrder','scheduledPaymentDate','totalPaymentDue'], 'validateJsonSchema'],
+            [['accountId', 'billingPeriod', 'broker', 'category', 'confirmationNumber', 'customer', 'minimumPaymentDue', 'paymentDueDate', 'paymentMethod', 'paymentMethodId', 'paymentStatus', 'provider', 'referencesOrder', 'scheduledPaymentDate', 'totalPaymentDue'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/InsertAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Crematorium.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/MovieTheater.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/HowToTool.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'requiredQuantity' => ['Number','QuantitativeValue','Text']
+        'requiredQuantity' => ['Number', 'QuantitativeValue', 'Text']
     ];
 
     /**

Please login to merge, or discard this patch.

		@@ -222,15 +222,15 @@ discard block
		block discarded – undo
222	222	*/
223	223	static protected $_schemaPropertyExpectedTypes = [
224	224	'actionStatus' => ['ActionStatusType'],
225		- 'agent' => ['Organization','Person'],
226		- 'endTime' => ['DateTime','Time'],
	225	+ 'agent' => ['Organization', 'Person'],
	226	+ 'endTime' => ['DateTime', 'Time'],
227	227	'error' => ['Thing'],
228	228	'instrument' => ['Thing'],
229		- 'location' => ['Place','PostalAddress','Text','VirtualLocation'],
	229	+ 'location' => ['Place', 'PostalAddress', 'Text', 'VirtualLocation'],
230	230	'object' => ['Thing'],
231		- 'participant' => ['Organization','Person'],
	231	+ 'participant' => ['Organization', 'Person'],
232	232	'result' => ['Thing'],
233		- 'startTime' => ['DateTime','Time'],
	233	+ 'startTime' => ['DateTime', 'Time'],
234	234	'target' => ['EntryPoint']
235	235	];
236	236
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	{
312	312	$rules = parent::rules();
313	313	$rules = array_merge($rules, [
314		- [['actionStatus','agent','endTime','error','instrument','location','object','participant','result','startTime','target'], 'validateJsonSchema'],
	314	+ [['actionStatus', 'agent', 'endTime', 'error', 'instrument', 'location', 'object', 'participant', 'result', 'startTime', 'target'], 'validateJsonSchema'],
315	315	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
316	316	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
317	317	]);

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

		@@ -138,7 +138,7 @@ discard block
		block discarded – undo
138	138	static protected $_schemaPropertyExpectedTypes = [
139	139	'accountMinimumInflow' => ['MonetaryAmount'],
140	140	'accountOverdraftLimit' => ['MonetaryAmount'],
141		- 'bankAccountType' => ['Text','URL']
	141	+ 'bankAccountType' => ['Text', 'URL']
142	142	];
143	143
144	144	/**
		@@ -210,7 +210,7 @@ discard block
		block discarded – undo
210	210	{
211	211	$rules = parent::rules();
212	212	$rules = array_merge($rules, [
213		- [['accountMinimumInflow','accountOverdraftLimit','bankAccountType'], 'validateJsonSchema'],
	213	+ [['accountMinimumInflow', 'accountOverdraftLimit', 'bankAccountType'], 'validateJsonSchema'],
214	214	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
215	215	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
216	216	]);

		@@ -241,19 +241,19 @@ discard block
		block discarded – undo
241	241	static protected $_schemaPropertyExpectedTypes = [
242	242	'accountId' => ['Text'],
243	243	'billingPeriod' => ['Duration'],
244		- 'broker' => ['Organization','Person'],
245		- 'category' => ['PhysicalActivityCategory','Text','Thing'],
	244	+ 'broker' => ['Organization', 'Person'],
	245	+ 'category' => ['PhysicalActivityCategory', 'Text', 'Thing'],
246	246	'confirmationNumber' => ['Text'],
247		- 'customer' => ['Organization','Person'],
248		- 'minimumPaymentDue' => ['MonetaryAmount','PriceSpecification'],
249		- 'paymentDueDate' => ['Date','DateTime'],
	247	+ 'customer' => ['Organization', 'Person'],
	248	+ 'minimumPaymentDue' => ['MonetaryAmount', 'PriceSpecification'],
	249	+ 'paymentDueDate' => ['Date', 'DateTime'],
250	250	'paymentMethod' => ['PaymentMethod'],
251	251	'paymentMethodId' => ['Text'],
252		- 'paymentStatus' => ['PaymentStatusType','Text'],
253		- 'provider' => ['Organization','Person'],
	252	+ 'paymentStatus' => ['PaymentStatusType', 'Text'],
	253	+ 'provider' => ['Organization', 'Person'],
254	254	'referencesOrder' => ['Order'],
255	255	'scheduledPaymentDate' => ['Date'],
256		- 'totalPaymentDue' => ['MonetaryAmount','PriceSpecification']
	256	+ 'totalPaymentDue' => ['MonetaryAmount', 'PriceSpecification']
257	257	];
258	258
259	259	/**
		@@ -337,7 +337,7 @@ discard block
		block discarded – undo
337	337	{
338	338	$rules = parent::rules();
339	339	$rules = array_merge($rules, [
340		- [['accountId','billingPeriod','broker','category','confirmationNumber','customer','minimumPaymentDue','paymentDueDate','paymentMethod','paymentMethodId','paymentStatus','provider','referencesOrder','scheduledPaymentDate','totalPaymentDue'], 'validateJsonSchema'],
	340	+ [['accountId', 'billingPeriod', 'broker', 'category', 'confirmationNumber', 'customer', 'minimumPaymentDue', 'paymentDueDate', 'paymentMethod', 'paymentMethodId', 'paymentStatus', 'provider', 'referencesOrder', 'scheduledPaymentDate', 'totalPaymentDue'], 'validateJsonSchema'],
341	341	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
342	342	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
343	343	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -201,7 +201,7 @@
		block discarded – undo
201	201	{
202	202	$rules = parent::rules();
203	203	$rules = array_merge($rules, [
204		- [['cssSelector','xpath'], 'validateJsonSchema'],
	204	+ [['cssSelector', 'xpath'], 'validateJsonSchema'],
205	205	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
206	206	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
207	207	]);

		@@ -118,7 +118,7 @@
		block discarded – undo
118	118	* @var array
119	119	*/
120	120	static protected $_schemaPropertyExpectedTypes = [
121		- 'requiredQuantity' => ['Number','QuantitativeValue','Text']
	121	+ 'requiredQuantity' => ['Number', 'QuantitativeValue', 'Text']
122	122	];
123	123
124	124	/**

nystudio107 / craft-seomatic

Push — v3 ( 01a338...22e12d )

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch