Inspection of "Fix rendering for MetaLink with multiple tags" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — v3 (#249)

by Timothy

created 2018-10-24 17:00 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -202,7 +202,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['fromLocation','toLocation'], 'validateJsonSchema'],
+            [['fromLocation', 'toLocation'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/SportsEvent.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -133,9 +133,9 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'awayTeam' => ['Person','SportsTeam'],
-        'competitor' => ['Person','SportsTeam'],
-        'homeTeam' => ['Person','SportsTeam']
+        'awayTeam' => ['Person', 'SportsTeam'],
+        'competitor' => ['Person', 'SportsTeam'],
+        'homeTeam' => ['Person', 'SportsTeam']
     ];
 
     /**
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['awayTeam','competitor','homeTeam'], 'validateJsonSchema'],
+            [['awayTeam', 'competitor', 'homeTeam'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/LeaveAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/JobPosting.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -282,11 +282,11 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'baseSalary' => ['MonetaryAmount','Number','PriceSpecification'],
+        'baseSalary' => ['MonetaryAmount', 'Number', 'PriceSpecification'],
         'datePosted' => ['Date'],
         'educationRequirements' => ['Text'],
         'employmentType' => ['Text'],
-        'estimatedSalary' => ['MonetaryAmount','Number','PriceSpecification'],
+        'estimatedSalary' => ['MonetaryAmount', 'Number', 'PriceSpecification'],
         'experienceRequirements' => ['Text'],
         'hiringOrganization' => ['Organization'],
         'incentiveCompensation' => ['Text'],
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['baseSalary','datePosted','educationRequirements','employmentType','estimatedSalary','experienceRequirements','hiringOrganization','incentiveCompensation','industry','jobBenefits','jobLocation','occupationalCategory','qualifications','responsibilities','salaryCurrency','skills','specialCommitments','title','validThrough','workHours'], 'validateJsonSchema'],
+            [['baseSalary', 'datePosted', 'educationRequirements', 'employmentType', 'estimatedSalary', 'experienceRequirements', 'hiringOrganization', 'incentiveCompensation', 'industry', 'jobBenefits', 'jobLocation', 'occupationalCategory', 'qualifications', 'responsibilities', 'salaryCurrency', 'skills', 'specialCommitments', 'title', 'validThrough', 'workHours'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/JoinAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/BankOrCreditUnion.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -118,7 +118,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'feesAndCommissionsSpecification' => ['Text','URL']
+        'feesAndCommissionsSpecification' => ['Text', 'URL']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/HowToDirection.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -187,8 +187,8 @@  discard block
 block discarded – undo
         'duringMedia' => ['MediaObject'],
         'performTime' => ['Duration'],
         'prepTime' => ['Duration'],
-        'supply' => ['HowToSupply','Text'],
-        'tool' => ['HowToTool','Text'],
+        'supply' => ['HowToSupply', 'Text'],
+        'tool' => ['HowToTool', 'Text'],
         'totalTime' => ['Duration']
     ];
 
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['afterMedia','beforeMedia','duringMedia','performTime','prepTime','supply','tool','totalTime'], 'validateJsonSchema'],
+            [['afterMedia', 'beforeMedia', 'duringMedia', 'performTime', 'prepTime', 'supply', 'tool', 'totalTime'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MusicComposition.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -190,7 +190,7 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'composer' => ['Organization','Person'],
+        'composer' => ['Organization', 'Person'],
         'firstPerformance' => ['Event'],
         'includedComposition' => ['MusicComposition'],
         'iswcCode' => ['Text'],
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['composer','firstPerformance','includedComposition','iswcCode','lyricist','lyrics','musicArrangement','musicCompositionForm','musicalKey','recordedAs'], 'validateJsonSchema'],
+            [['composer', 'firstPerformance', 'includedComposition', 'iswcCode', 'lyricist', 'lyrics', 'musicArrangement', 'musicCompositionForm', 'musicalKey', 'recordedAs'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Dataset.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -171,8 +171,8 @@  discard block
 block discarded – undo
         'distribution' => ['DataDownload'],
         'includedInDataCatalog' => ['DataCatalog'],
         'issn' => ['Text'],
-        'measurementTechnique' => ['Text','URL'],
-        'variableMeasured' => ['PropertyValue','Text']
+        'measurementTechnique' => ['Text', 'URL'],
+        'variableMeasured' => ['PropertyValue', 'Text']
     ];
 
     /**
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['distribution','includedInDataCatalog','issn','measurementTechnique','variableMeasured'], 'validateJsonSchema'],
+            [['distribution', 'includedInDataCatalog', 'issn', 'measurementTechnique', 'variableMeasured'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -133,9 +133,9 @@ discard block
		block discarded – undo
133	133	* @var array
134	134	*/
135	135	static protected $_schemaPropertyExpectedTypes = [
136		- 'awayTeam' => ['Person','SportsTeam'],
137		- 'competitor' => ['Person','SportsTeam'],
138		- 'homeTeam' => ['Person','SportsTeam']
	136	+ 'awayTeam' => ['Person', 'SportsTeam'],
	137	+ 'competitor' => ['Person', 'SportsTeam'],
	138	+ 'homeTeam' => ['Person', 'SportsTeam']
139	139	];
140	140
141	141	/**
		@@ -207,7 +207,7 @@ discard block
		block discarded – undo
207	207	{
208	208	$rules = parent::rules();
209	209	$rules = array_merge($rules, [
210		- [['awayTeam','competitor','homeTeam'], 'validateJsonSchema'],
	210	+ [['awayTeam', 'competitor', 'homeTeam'], 'validateJsonSchema'],
211	211	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
212	212	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
213	213	]);

		@@ -282,11 +282,11 @@ discard block
		block discarded – undo
282	282	* @var array
283	283	*/
284	284	static protected $_schemaPropertyExpectedTypes = [
285		- 'baseSalary' => ['MonetaryAmount','Number','PriceSpecification'],
	285	+ 'baseSalary' => ['MonetaryAmount', 'Number', 'PriceSpecification'],
286	286	'datePosted' => ['Date'],
287	287	'educationRequirements' => ['Text'],
288	288	'employmentType' => ['Text'],
289		- 'estimatedSalary' => ['MonetaryAmount','Number','PriceSpecification'],
	289	+ 'estimatedSalary' => ['MonetaryAmount', 'Number', 'PriceSpecification'],
290	290	'experienceRequirements' => ['Text'],
291	291	'hiringOrganization' => ['Organization'],
292	292	'incentiveCompensation' => ['Text'],
		@@ -390,7 +390,7 @@ discard block
		block discarded – undo
390	390	{
391	391	$rules = parent::rules();
392	392	$rules = array_merge($rules, [
393		- [['baseSalary','datePosted','educationRequirements','employmentType','estimatedSalary','experienceRequirements','hiringOrganization','incentiveCompensation','industry','jobBenefits','jobLocation','occupationalCategory','qualifications','responsibilities','salaryCurrency','skills','specialCommitments','title','validThrough','workHours'], 'validateJsonSchema'],
	393	+ [['baseSalary', 'datePosted', 'educationRequirements', 'employmentType', 'estimatedSalary', 'experienceRequirements', 'hiringOrganization', 'incentiveCompensation', 'industry', 'jobBenefits', 'jobLocation', 'occupationalCategory', 'qualifications', 'responsibilities', 'salaryCurrency', 'skills', 'specialCommitments', 'title', 'validThrough', 'workHours'], 'validateJsonSchema'],
394	394	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
395	395	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
396	396	]);

		@@ -118,7 +118,7 @@
		block discarded – undo
118	118	* @var array
119	119	*/
120	120	static protected $_schemaPropertyExpectedTypes = [
121		- 'feesAndCommissionsSpecification' => ['Text','URL']
	121	+ 'feesAndCommissionsSpecification' => ['Text', 'URL']
122	122	];
123	123
124	124	/**

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -202,7 +202,7 @@
		block discarded – undo
202	202	{
203	203	$rules = parent::rules();
204	204	$rules = array_merge($rules, [
205		- [['fromLocation','toLocation'], 'validateJsonSchema'],
	205	+ [['fromLocation', 'toLocation'], 'validateJsonSchema'],
206	206	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
207	207	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
208	208	]);

		@@ -187,8 +187,8 @@ discard block
		block discarded – undo
187	187	'duringMedia' => ['MediaObject'],
188	188	'performTime' => ['Duration'],
189	189	'prepTime' => ['Duration'],
190		- 'supply' => ['HowToSupply','Text'],
191		- 'tool' => ['HowToTool','Text'],
	190	+ 'supply' => ['HowToSupply', 'Text'],
	191	+ 'tool' => ['HowToTool', 'Text'],
192	192	'totalTime' => ['Duration']
193	193	];
194	194
		@@ -266,7 +266,7 @@ discard block
		block discarded – undo
266	266	{
267	267	$rules = parent::rules();
268	268	$rules = array_merge($rules, [
269		- [['afterMedia','beforeMedia','duringMedia','performTime','prepTime','supply','tool','totalTime'], 'validateJsonSchema'],
	269	+ [['afterMedia', 'beforeMedia', 'duringMedia', 'performTime', 'prepTime', 'supply', 'tool', 'totalTime'], 'validateJsonSchema'],
270	270	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
271	271	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
272	272	]);

		@@ -190,7 +190,7 @@ discard block
		block discarded – undo
190	190	* @var array
191	191	*/
192	192	static protected $_schemaPropertyExpectedTypes = [
193		- 'composer' => ['Organization','Person'],
	193	+ 'composer' => ['Organization', 'Person'],
194	194	'firstPerformance' => ['Event'],
195	195	'includedComposition' => ['MusicComposition'],
196	196	'iswcCode' => ['Text'],
		@@ -278,7 +278,7 @@ discard block
		block discarded – undo
278	278	{
279	279	$rules = parent::rules();
280	280	$rules = array_merge($rules, [
281		- [['composer','firstPerformance','includedComposition','iswcCode','lyricist','lyrics','musicArrangement','musicCompositionForm','musicalKey','recordedAs'], 'validateJsonSchema'],
	281	+ [['composer', 'firstPerformance', 'includedComposition', 'iswcCode', 'lyricist', 'lyrics', 'musicArrangement', 'musicCompositionForm', 'musicalKey', 'recordedAs'], 'validateJsonSchema'],
282	282	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
283	283	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
284	284	]);

		@@ -171,8 +171,8 @@ discard block
		block discarded – undo
171	171	'distribution' => ['DataDownload'],
172	172	'includedInDataCatalog' => ['DataCatalog'],
173	173	'issn' => ['Text'],
174		- 'measurementTechnique' => ['Text','URL'],
175		- 'variableMeasured' => ['PropertyValue','Text']
	174	+ 'measurementTechnique' => ['Text', 'URL'],
	175	+ 'variableMeasured' => ['PropertyValue', 'Text']
176	176	];
177	177
178	178	/**
		@@ -246,7 +246,7 @@ discard block
		block discarded – undo
246	246	{
247	247	$rules = parent::rules();
248	248	$rules = array_merge($rules, [
249		- [['distribution','includedInDataCatalog','issn','measurementTechnique','variableMeasured'], 'validateJsonSchema'],
	249	+ [['distribution', 'includedInDataCatalog', 'issn', 'measurementTechnique', 'variableMeasured'], 'validateJsonSchema'],
250	250	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
251	251	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
252	252	]);

nystudio107 / craft-seomatic

Pull Request — v3 (#249)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch