CraftQLSchemaHelper::getContainerArrays() - Code Metrics - Inspection of "Refactor CraftQL support" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 763cf7...df804f )

by Andrew

created 2019-05-09 22:55 UTC

CraftQLSchemaHelper::getContainerArrays() B

↳ Parent: Project

Complexity

Conditions	6
Paths	8

Size

Total Lines	71
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	40
nc	8
nop	3
dl	0
loc	71
rs	8.6577
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * SEOmatic plugin for Craft CMS 3.x
 *
 * @link      https://nystudio107.com/
 * @copyright Copyright (c) 2019 nystudio107
 * @license   https://nystudio107.com/license

 */

namespace nystudio107\seomatic\helpers;

use Craft;
use craft\base\Element;
use craft\elements\Entry;

use nystudio107\seomatic\helpers\Container as ContainerHelper;
use nystudio107\seomatic\models\MetaJsonLdContainer;
use nystudio107\seomatic\models\MetaLinkContainer;
use nystudio107\seomatic\models\MetaScriptContainer;
use nystudio107\seomatic\models\MetaTitleContainer;
use nystudio107\seomatic\models\MetaTagContainer;

use markhuot\CraftQL\Events\AlterSchemaFields;
filter:
    dependency_paths: ["lib/*"]

/**
 * @author    nystudio107

 * @package   Seomatic
 * @since     3.2.0

 */

class CraftQLSchemaHelper
{
    // Constants
    // =========================================================================

    const CACHE_KEY = 'seomatic_metacontroller_';

    // Public Methods
    // =========================================================================

    public static function handle(AlterSchemaFields $event)

    {
        // Create the root object
        $seomaticField = $event->schema->createObjectType('seomaticData');
        // Add metaTitleContainer
        $seomaticField->addStringField('metaTitleContainer')->resolve(function (Element $element) {
            // $root contains the data returned by the field below
            $result = ContainerHelper::getContainerArrays(
                [MetaTitleContainer::CONTAINER_TYPE],
                $element->uri,
                /** @scrutinizer ignore-type */ $element->uri,
                $element->siteId,
                false
            );

            return $result[MetaTitleContainer::CONTAINER_TYPE];
        });
        // Add metaTagContainer
        $seomaticField->addStringField('metaTagContainer')->resolve(function (Element $element) {
            // $root contains the data returned by the field below
            $result = ContainerHelper::getContainerArrays(
                [MetaTagContainer::CONTAINER_TYPE],
                $element->uri,
                /** @scrutinizer ignore-type */ $element->uri,
                $element->siteId,
                false
            );

            return $result[MetaTagContainer::CONTAINER_TYPE];
        });
        // Add metaLinkContainer
        $seomaticField->addStringField('metaLinkContainer')->resolve(function (Element $element) {
            // $root contains the data returned by the field below
            $result = ContainerHelper::getContainerArrays(
                [MetaLinkContainer::CONTAINER_TYPE],
                $element->uri,
                /** @scrutinizer ignore-type */ $element->uri,
                $element->siteId,
                false
            );

            return $result[MetaLinkContainer::CONTAINER_TYPE];
        });
        // Add metaScriptContainer
        $seomaticField->addStringField('metaScriptContainer')->resolve(function (Element $element) {
            // $root contains the data returned by the field below
            $result = ContainerHelper::getContainerArrays(
                [MetaScriptContainer::CONTAINER_TYPE],
                $element->uri,
                /** @scrutinizer ignore-type */ $element->uri,
                $element->siteId,
                false
            );
            Craft::dd($result);

            return $result[MetaScriptContainer::CONTAINER_TYPE];
        });
        // Add metaJsonLdContainer
        $seomaticField->addStringField('metaJsonLdContainer')->resolve(function (Element $element) {
            // $root contains the data returned by the field below
            $result = ContainerHelper::getContainerArrays(
                [MetaJsonLdContainer::CONTAINER_TYPE],
                $element->uri,
                /** @scrutinizer ignore-type */ $element->uri,
                $element->siteId,
                false
            );

            return $result[MetaJsonLdContainer::CONTAINER_TYPE];
        });

        $event->schema->addField('seomatic')
            ->arguments(function (\markhuot\CraftQL\Builders\Field $field) {
filter:
    dependency_paths: ["lib/*"]
                $field->addIntArgument('siteId');
                $field->addStringArgument('uri')->nonNull();
            })
            ->type($seomaticField)
            ->resolve(function ($root, $args, $context, $info) {
            ->resolve(function ($root, $args, $context, /** @scrutinizer ignore-unused */ $info) {
                // Return an entry that meets the passed in criteria.
                $criteria = Entry::find()
                    ->uri($args['uri']);
                if (!empty($args['siteId'])) {
                    $criteria->siteId($args['siteId']);
                }

                return $criteria->one();
            });
    }
}


nystudio107 / craft-seomatic

Push — develop ( 763cf7...df804f )

CraftQLSchemaHelper::getContainerArrays() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like