Inspection of "Container event" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#251)

by Timothy

created 2018-10-25 20:45 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -198,7 +198,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['childMaxAge','childMinAge'], 'validateJsonSchema'],
+            [['childMaxAge', 'childMinAge'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/TrainStation.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/DigitalDocument.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/Periodical.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -138,9 +138,9 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'endDate' => ['Date','DateTime'],
+        'endDate' => ['Date', 'DateTime'],
         'issn' => ['Text'],
-        'startDate' => ['Date','DateTime']
+        'startDate' => ['Date', 'DateTime']
     ];
 
     /**
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['endDate','issn','startDate'], 'validateJsonSchema'],
+            [['endDate', 'issn', 'startDate'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/PaymentStatusType.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -121,7 +121,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'supersededBy' => ['Class','Enumeration','Property']
+        'supersededBy' => ['Class', 'Enumeration', 'Property']
     ];
 
     /**

Please login to merge, or discard this patch.

src/models/jsonld/WatchAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/MenuSection.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -198,7 +198,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['hasMenuItem','hasMenuSection'], 'validateJsonSchema'],
+            [['hasMenuItem', 'hasMenuSection'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/MusicEvent.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -401,32 +401,32 @@  discard block
 block discarded – undo
         'about' => ['Thing'],
         'actor' => ['Person'],
         'aggregateRating' => ['AggregateRating'],
-        'attendee' => ['Organization','Person'],
+        'attendee' => ['Organization', 'Person'],
         'audience' => ['Audience'],
-        'composer' => ['Organization','Person'],
-        'contributor' => ['Organization','Person'],
+        'composer' => ['Organization', 'Person'],
+        'contributor' => ['Organization', 'Person'],
         'director' => ['Person'],
         'doorTime' => ['DateTime'],
         'duration' => ['Duration'],
-        'endDate' => ['Date','DateTime'],
+        'endDate' => ['Date', 'DateTime'],
         'eventStatus' => ['EventStatusType'],
-        'funder' => ['Organization','Person'],
-        'inLanguage' => ['Language','Text'],
+        'funder' => ['Organization', 'Person'],
+        'inLanguage' => ['Language', 'Text'],
         'isAccessibleForFree' => ['Boolean'],
-        'location' => ['Place','PostalAddress','Text'],
+        'location' => ['Place', 'PostalAddress', 'Text'],
         'maximumAttendeeCapacity' => ['Integer'],
         'offers' => ['Offer'],
-        'organizer' => ['Organization','Person'],
-        'performer' => ['Organization','Person'],
+        'organizer' => ['Organization', 'Person'],
+        'performer' => ['Organization', 'Person'],
         'previousStartDate' => ['Date'],
         'recordedIn' => ['CreativeWork'],
         'remainingAttendeeCapacity' => ['Integer'],
         'review' => ['Review'],
-        'sponsor' => ['Organization','Person'],
-        'startDate' => ['Date','DateTime'],
+        'sponsor' => ['Organization', 'Person'],
+        'startDate' => ['Date', 'DateTime'],
         'subEvent' => ['Event'],
         'superEvent' => ['Event'],
-        'translator' => ['Organization','Person'],
+        'translator' => ['Organization', 'Person'],
         'typicalAgeRange' => ['Text'],
         'workFeatured' => ['CreativeWork'],
         'workPerformed' => ['CreativeWork']
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
+            [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/HowToSupply.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -119,7 +119,7 @@
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'estimatedCost' => ['MonetaryAmount','Text']
+        'estimatedCost' => ['MonetaryAmount', 'Text']
     ];
 
     /**

Please login to merge, or discard this patch.

		@@ -138,9 +138,9 @@ discard block
		block discarded – undo
138	138	* @var array
139	139	*/
140	140	static protected $_schemaPropertyExpectedTypes = [
141		- 'endDate' => ['Date','DateTime'],
	141	+ 'endDate' => ['Date', 'DateTime'],
142	142	'issn' => ['Text'],
143		- 'startDate' => ['Date','DateTime']
	143	+ 'startDate' => ['Date', 'DateTime']
144	144	];
145	145
146	146	/**
		@@ -212,7 +212,7 @@ discard block
		block discarded – undo
212	212	{
213	213	$rules = parent::rules();
214	214	$rules = array_merge($rules, [
215		- [['endDate','issn','startDate'], 'validateJsonSchema'],
	215	+ [['endDate', 'issn', 'startDate'], 'validateJsonSchema'],
216	216	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
217	217	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
218	218	]);

		@@ -121,7 +121,7 @@
		block discarded – undo
121	121	* @var array
122	122	*/
123	123	static protected $_schemaPropertyExpectedTypes = [
124		- 'supersededBy' => ['Class','Enumeration','Property']
	124	+ 'supersededBy' => ['Class', 'Enumeration', 'Property']
125	125	];
126	126
127	127	/**

		@@ -401,32 +401,32 @@ discard block
		block discarded – undo
401	401	'about' => ['Thing'],
402	402	'actor' => ['Person'],
403	403	'aggregateRating' => ['AggregateRating'],
404		- 'attendee' => ['Organization','Person'],
	404	+ 'attendee' => ['Organization', 'Person'],
405	405	'audience' => ['Audience'],
406		- 'composer' => ['Organization','Person'],
407		- 'contributor' => ['Organization','Person'],
	406	+ 'composer' => ['Organization', 'Person'],
	407	+ 'contributor' => ['Organization', 'Person'],
408	408	'director' => ['Person'],
409	409	'doorTime' => ['DateTime'],
410	410	'duration' => ['Duration'],
411		- 'endDate' => ['Date','DateTime'],
	411	+ 'endDate' => ['Date', 'DateTime'],
412	412	'eventStatus' => ['EventStatusType'],
413		- 'funder' => ['Organization','Person'],
414		- 'inLanguage' => ['Language','Text'],
	413	+ 'funder' => ['Organization', 'Person'],
	414	+ 'inLanguage' => ['Language', 'Text'],
415	415	'isAccessibleForFree' => ['Boolean'],
416		- 'location' => ['Place','PostalAddress','Text'],
	416	+ 'location' => ['Place', 'PostalAddress', 'Text'],
417	417	'maximumAttendeeCapacity' => ['Integer'],
418	418	'offers' => ['Offer'],
419		- 'organizer' => ['Organization','Person'],
420		- 'performer' => ['Organization','Person'],
	419	+ 'organizer' => ['Organization', 'Person'],
	420	+ 'performer' => ['Organization', 'Person'],
421	421	'previousStartDate' => ['Date'],
422	422	'recordedIn' => ['CreativeWork'],
423	423	'remainingAttendeeCapacity' => ['Integer'],
424	424	'review' => ['Review'],
425		- 'sponsor' => ['Organization','Person'],
426		- 'startDate' => ['Date','DateTime'],
	425	+ 'sponsor' => ['Organization', 'Person'],
	426	+ 'startDate' => ['Date', 'DateTime'],
427	427	'subEvent' => ['Event'],
428	428	'superEvent' => ['Event'],
429		- 'translator' => ['Organization','Person'],
	429	+ 'translator' => ['Organization', 'Person'],
430	430	'typicalAgeRange' => ['Text'],
431	431	'workFeatured' => ['CreativeWork'],
432	432	'workPerformed' => ['CreativeWork']
		@@ -530,7 +530,7 @@ discard block
		block discarded – undo
530	530	{
531	531	$rules = parent::rules();
532	532	$rules = array_merge($rules, [
533		- [['about','actor','aggregateRating','attendee','audience','composer','contributor','director','doorTime','duration','endDate','eventStatus','funder','inLanguage','isAccessibleForFree','location','maximumAttendeeCapacity','offers','organizer','performer','previousStartDate','recordedIn','remainingAttendeeCapacity','review','sponsor','startDate','subEvent','superEvent','translator','typicalAgeRange','workFeatured','workPerformed'], 'validateJsonSchema'],
	533	+ [['about', 'actor', 'aggregateRating', 'attendee', 'audience', 'composer', 'contributor', 'director', 'doorTime', 'duration', 'endDate', 'eventStatus', 'funder', 'inLanguage', 'isAccessibleForFree', 'location', 'maximumAttendeeCapacity', 'offers', 'organizer', 'performer', 'previousStartDate', 'recordedIn', 'remainingAttendeeCapacity', 'review', 'sponsor', 'startDate', 'subEvent', 'superEvent', 'translator', 'typicalAgeRange', 'workFeatured', 'workPerformed'], 'validateJsonSchema'],
534	534	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
535	535	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
536	536	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -198,7 +198,7 @@
		block discarded – undo
198	198	{
199	199	$rules = parent::rules();
200	200	$rules = array_merge($rules, [
201		- [['childMaxAge','childMinAge'], 'validateJsonSchema'],
	201	+ [['childMaxAge', 'childMinAge'], 'validateJsonSchema'],
202	202	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
203	203	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
204	204	]);

		@@ -119,7 +119,7 @@
		block discarded – undo
119	119	* @var array
120	120	*/
121	121	static protected $_schemaPropertyExpectedTypes = [
122		- 'estimatedCost' => ['MonetaryAmount','Text']
	122	+ 'estimatedCost' => ['MonetaryAmount', 'Text']
123	123	];
124	124
125	125	/**

nystudio107 / craft-seomatic

Pull Request — develop (#251)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch