Inspection of "Container event" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#251)

by Timothy

created 2018-10-25 20:45 UTC

Status

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -142,10 +142,10 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'acquiredFrom' => ['Organization','Person'],
+        'acquiredFrom' => ['Organization', 'Person'],
         'ownedFrom' => ['DateTime'],
         'ownedThrough' => ['DateTime'],
-        'typeOfGood' => ['Product','Service']
+        'typeOfGood' => ['Product', 'Service']
     ];
 
     /**
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['acquiredFrom','ownedFrom','ownedThrough','typeOfGood'], 'validateJsonSchema'],
+            [['acquiredFrom', 'ownedFrom', 'ownedThrough', 'typeOfGood'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Dentist.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/HowTo.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -182,14 +182,14 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'estimatedCost' => ['MonetaryAmount','Text'],
+        'estimatedCost' => ['MonetaryAmount', 'Text'],
         'performTime' => ['Duration'],
         'prepTime' => ['Duration'],
-        'steps' => ['CreativeWork','ItemList','Text'],
-        'supply' => ['HowToSupply','Text'],
-        'tool' => ['HowToTool','Text'],
+        'steps' => ['CreativeWork', 'ItemList', 'Text'],
+        'supply' => ['HowToSupply', 'Text'],
+        'tool' => ['HowToTool', 'Text'],
         'totalTime' => ['Duration'],
-        'yield' => ['QuantitativeValue','Text']
+        'yield' => ['QuantitativeValue', 'Text']
     ];
 
     /**
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['estimatedCost','performTime','prepTime','steps','supply','tool','totalTime','yield'], 'validateJsonSchema'],
+            [['estimatedCost', 'performTime', 'prepTime', 'steps', 'supply', 'tool', 'totalTime', 'yield'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Brewery.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -147,8 +147,8 @@  discard block
 block discarded – undo
      * @var array
      */
     static protected $_schemaPropertyExpectedTypes = [
-        'acceptsReservations' => ['Boolean','Text','URL'],
-        'hasMenu' => ['Menu','Text','URL'],
+        'acceptsReservations' => ['Boolean', 'Text', 'URL'],
+        'hasMenu' => ['Menu', 'Text', 'URL'],
         'servesCuisine' => ['Text'],
         'starRating' => ['Rating']
     ];
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
+            [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/PlanAction.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/PresentationDigitalDocument.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

src/models/jsonld/TravelAgency.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -226,7 +226,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
+            [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/Car.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -205,7 +205,7 @@
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['acrissCode','roofLoad'], 'validateJsonSchema'],
+            [['acrissCode', 'roofLoad'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

src/models/jsonld/SendAction.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -164,8 +164,8 @@  discard block
 block discarded – undo
     // =========================================================================
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function init()
     {
         parent::init();
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
     }
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function rules()
     {
         $rules = parent::rules();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -131,7 +131,7 @@  discard block
 block discarded – undo
      */
     static protected $_schemaPropertyExpectedTypes = [
         'deliveryMethod' => ['DeliveryMethod'],
-        'recipient' => ['Audience','ContactPoint','Organization','Person']
+        'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
     ];
 
     /**
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
     {
         $rules = parent::rules();
         $rules = array_merge($rules, [
-            [['deliveryMethod','recipient'], 'validateJsonSchema'],
+            [['deliveryMethod', 'recipient'], 'validateJsonSchema'],
             [self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
             [self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
         ]);

Please login to merge, or discard this patch.

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -182,14 +182,14 @@ discard block
		block discarded – undo
182	182	* @var array
183	183	*/
184	184	static protected $_schemaPropertyExpectedTypes = [
185		- 'estimatedCost' => ['MonetaryAmount','Text'],
	185	+ 'estimatedCost' => ['MonetaryAmount', 'Text'],
186	186	'performTime' => ['Duration'],
187	187	'prepTime' => ['Duration'],
188		- 'steps' => ['CreativeWork','ItemList','Text'],
189		- 'supply' => ['HowToSupply','Text'],
190		- 'tool' => ['HowToTool','Text'],
	188	+ 'steps' => ['CreativeWork', 'ItemList', 'Text'],
	189	+ 'supply' => ['HowToSupply', 'Text'],
	190	+ 'tool' => ['HowToTool', 'Text'],
191	191	'totalTime' => ['Duration'],
192		- 'yield' => ['QuantitativeValue','Text']
	192	+ 'yield' => ['QuantitativeValue', 'Text']
193	193	];
194	194
195	195	/**
		@@ -266,7 +266,7 @@ discard block
		block discarded – undo
266	266	{
267	267	$rules = parent::rules();
268	268	$rules = array_merge($rules, [
269		- [['estimatedCost','performTime','prepTime','steps','supply','tool','totalTime','yield'], 'validateJsonSchema'],
	269	+ [['estimatedCost', 'performTime', 'prepTime', 'steps', 'supply', 'tool', 'totalTime', 'yield'], 'validateJsonSchema'],
270	270	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
271	271	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
272	272	]);

		@@ -226,7 +226,7 @@
		block discarded – undo
226	226	{
227	227	$rules = parent::rules();
228	228	$rules = array_merge($rules, [
229		- [['currenciesAccepted','openingHours','paymentAccepted','priceRange'], 'validateJsonSchema'],
	229	+ [['currenciesAccepted', 'openingHours', 'paymentAccepted', 'priceRange'], 'validateJsonSchema'],
230	230	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
231	231	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
232	232	]);

		@@ -205,7 +205,7 @@
		block discarded – undo
205	205	{
206	206	$rules = parent::rules();
207	207	$rules = array_merge($rules, [
208		- [['acrissCode','roofLoad'], 'validateJsonSchema'],
	208	+ [['acrissCode', 'roofLoad'], 'validateJsonSchema'],
209	209	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
210	210	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
211	211	]);

		@@ -164,8 +164,8 @@ discard block
		block discarded – undo
164	164	// =========================================================================
165	165
166	166	/**
167		- * @inheritdoc
168		- */
	167	+ * @inheritdoc
	168	+ */
169	169	public function init()
170	170	{
171	171	parent::init();
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	}
197	197
198	198	/**
199		- * @inheritdoc
200		- */
	199	+ * @inheritdoc
	200	+ */
201	201	public function rules()
202	202	{
203	203	$rules = parent::rules();

		@@ -142,10 +142,10 @@ discard block
		block discarded – undo
142	142	* @var array
143	143	*/
144	144	static protected $_schemaPropertyExpectedTypes = [
145		- 'acquiredFrom' => ['Organization','Person'],
	145	+ 'acquiredFrom' => ['Organization', 'Person'],
146	146	'ownedFrom' => ['DateTime'],
147	147	'ownedThrough' => ['DateTime'],
148		- 'typeOfGood' => ['Product','Service']
	148	+ 'typeOfGood' => ['Product', 'Service']
149	149	];
150	150
151	151	/**
		@@ -218,7 +218,7 @@ discard block
		block discarded – undo
218	218	{
219	219	$rules = parent::rules();
220	220	$rules = array_merge($rules, [
221		- [['acquiredFrom','ownedFrom','ownedThrough','typeOfGood'], 'validateJsonSchema'],
	221	+ [['acquiredFrom', 'ownedFrom', 'ownedThrough', 'typeOfGood'], 'validateJsonSchema'],
222	222	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
223	223	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
224	224	]);

		@@ -147,8 +147,8 @@ discard block
		block discarded – undo
147	147	* @var array
148	148	*/
149	149	static protected $_schemaPropertyExpectedTypes = [
150		- 'acceptsReservations' => ['Boolean','Text','URL'],
151		- 'hasMenu' => ['Menu','Text','URL'],
	150	+ 'acceptsReservations' => ['Boolean', 'Text', 'URL'],
	151	+ 'hasMenu' => ['Menu', 'Text', 'URL'],
152	152	'servesCuisine' => ['Text'],
153	153	'starRating' => ['Rating']
154	154	];
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	{
224	224	$rules = parent::rules();
225	225	$rules = array_merge($rules, [
226		- [['acceptsReservations','hasMenu','servesCuisine','starRating'], 'validateJsonSchema'],
	226	+ [['acceptsReservations', 'hasMenu', 'servesCuisine', 'starRating'], 'validateJsonSchema'],
227	227	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
228	228	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
229	229	]);

		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	*/
132	132	static protected $_schemaPropertyExpectedTypes = [
133	133	'deliveryMethod' => ['DeliveryMethod'],
134		- 'recipient' => ['Audience','ContactPoint','Organization','Person']
	134	+ 'recipient' => ['Audience', 'ContactPoint', 'Organization', 'Person']
135	135	];
136	136
137	137	/**
		@@ -202,7 +202,7 @@ discard block
		block discarded – undo
202	202	{
203	203	$rules = parent::rules();
204	204	$rules = array_merge($rules, [
205		- [['deliveryMethod','recipient'], 'validateJsonSchema'],
	205	+ [['deliveryMethod', 'recipient'], 'validateJsonSchema'],
206	206	[self::$_googleRequiredSchema, 'required', 'on' => ['google'], 'message' => 'This property is required by Google.'],
207	207	[self::$_googleRecommendedSchema, 'required', 'on' => ['google'], 'message' => 'This property is recommended by Google.']
208	208	]);

nystudio107 / craft-seomatic

Pull Request — develop (#251)

Status

Category

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch