Inspection of "Merge branch 'release/4.0.44' into v4" - nystudio107/craft-seomatic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v4 ( 7020b0...4ea8ea )

by Andrew

created 2024-03-15 03:27 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -51,16 +51,16 @@
 block discarded – undo
     public function includeMetaData($dependency)
     {
         Craft::beginProfile('MetaJsonLdContainer::includeMetaData', __METHOD__);
-        $uniqueKey = $this->handle . $dependency->tags[3] . '-v2';
+        $uniqueKey = $this->handle.$dependency->tags[3].'-v2';
         $cache = Craft::$app->getCache();
         if ($this->clearCache) {
             TagDependency::invalidate($cache, $dependency->tags[3]);
         }
         [$jsonLd, $attrs] = $cache->getOrSet(
-            self::CONTAINER_TYPE . $uniqueKey,
+            self::CONTAINER_TYPE.$uniqueKey,
             function() use ($uniqueKey) {
                 Craft::info(
-                    self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
+                    self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
                     __METHOD__
                 );
                 

Please login to merge, or discard this patch.

src/models/SitemapIndexTemplate.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -116,7 +116,7 @@  discard block
 block discarded – undo
      */
     public function getFilename(int $groupId): string
     {
-        return 'sitemaps-' . $groupId . '-sitemap.xml';
+        return 'sitemaps-'.$groupId.'-sitemap.xml';
     }
 
     /**
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
             ],
         ]);
 
-        return $cache->getOrSet(self::CACHE_KEY . $groupId . '.' . $siteId, function() use ($groupSiteIds, $siteId) {
+        return $cache->getOrSet(self::CACHE_KEY.$groupId.'.'.$siteId, function() use ($groupSiteIds, $siteId) {
             Craft::info(
                 'Sitemap index cache miss',
                 __METHOD__

Please login to merge, or discard this patch.

src/models/MetaTagContainer.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -49,16 +49,16 @@
 block discarded – undo
     public function includeMetaData($dependency)
     {
         Craft::beginProfile('MetaTagContainer::includeMetaData', __METHOD__);
-        $uniqueKey = $this->handle . $dependency->tags[3];
+        $uniqueKey = $this->handle.$dependency->tags[3];
         $cache = Craft::$app->getCache();
         if ($this->clearCache) {
             TagDependency::invalidate($cache, $dependency->tags[3]);
         }
         $tagData = $cache->getOrSet(
-            self::CONTAINER_TYPE . $uniqueKey,
+            self::CONTAINER_TYPE.$uniqueKey,
             function() use ($uniqueKey) {
                 Craft::info(
-                    self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
+                    self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
                     __METHOD__
                 );
                 $tagData = [];

Please login to merge, or discard this patch.

src/models/MetaTitleContainer.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -48,16 +48,16 @@
 block discarded – undo
     public function includeMetaData($dependency)
     {
         Craft::beginProfile('MetaTitleContainer::includeMetaData', __METHOD__);
-        $uniqueKey = $this->handle . $dependency->tags[3];
+        $uniqueKey = $this->handle.$dependency->tags[3];
         $cache = Craft::$app->getCache();
         if ($this->clearCache) {
             TagDependency::invalidate($cache, $dependency->tags[3]);
         }
         $tagData = $cache->getOrSet(
-            self::CONTAINER_TYPE . $uniqueKey,
+            self::CONTAINER_TYPE.$uniqueKey,
             function() use ($uniqueKey) {
                 Craft::info(
-                    self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
+                    self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
                     __METHOD__
                 );
                 $tagData = '';

Please login to merge, or discard this patch.

src/models/MetaScriptContainer.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -55,16 +55,16 @@  discard block
 block discarded – undo
     public function includeMetaData($dependency)
     {
         Craft::beginProfile('MetaScriptContainer::includeMetaData', __METHOD__);
-        $uniqueKey = $this->handle . $dependency->tags[3] . $this->dataLayerHash();
+        $uniqueKey = $this->handle.$dependency->tags[3].$this->dataLayerHash();
         $cache = Craft::$app->getCache();
         if ($this->clearCache) {
             TagDependency::invalidate($cache, $dependency->tags[3]);
         }
         $tagData = $cache->getOrSet(
-            self::CONTAINER_TYPE . $uniqueKey,
+            self::CONTAINER_TYPE.$uniqueKey,
             function() use ($uniqueKey) {
                 Craft::info(
-                    self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
+                    self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
                     __METHOD__
                 );
                 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
                     'jQuery(window).load()',
                 ];
                 $position = $positionNames[$config['position'] - 1] ?? 'unknown';
-                $html .= "<!-- Position: {$position} -->" . PHP_EOL;
+                $html .= "<!-- Position: {$position} -->".PHP_EOL;
             }
             if ($bodyJs || !$params['renderScriptTags']) {
                 $html .= $config['js'];

Please login to merge, or discard this patch.

src/models/MetaLinkContainer.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -49,16 +49,16 @@
 block discarded – undo
     public function includeMetaData($dependency)
     {
         Craft::beginProfile('MetaLinkContainer::includeMetaData', __METHOD__);
-        $uniqueKey = $this->handle . $dependency->tags[3];
+        $uniqueKey = $this->handle.$dependency->tags[3];
         $cache = Craft::$app->getCache();
         if ($this->clearCache) {
             TagDependency::invalidate($cache, $dependency->tags[3]);
         }
         $tagData = $cache->getOrSet(
-            self::CONTAINER_TYPE . $uniqueKey,
+            self::CONTAINER_TYPE.$uniqueKey,
             function() use ($uniqueKey) {
                 Craft::info(
-                    self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
+                    self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
                     __METHOD__
                 );
                 $tagData = [];

Please login to merge, or discard this patch.

src/seomatic-config/campaignmeta/TagContainer.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -19,44 +19,44 @@
 block discarded – undo
  */
 
 return [
-    MetaTagContainer::CONTAINER_TYPE . TagService::GENERAL_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::GENERAL_HANDLE => [
         'name' => 'General',
         'description' => 'General Meta Tags',
         'handle' => TagService::GENERAL_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::FACEBOOK_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::FACEBOOK_HANDLE => [
         'name' => 'Facebook',
         'description' => 'Facebook OpenGraph Meta Tags',
         'handle' => TagService::FACEBOOK_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::TWITTER_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::TWITTER_HANDLE => [
         'name' => 'Twitter',
         'description' => 'Twitter Card Meta Tags',
         'handle' => TagService::TWITTER_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::MISC_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::MISC_HANDLE => [
         'name' => 'Miscellaneous',
         'description' => 'Miscellaneous Meta Tags',
         'handle' => TagService::MISC_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],

Please login to merge, or discard this patch.

src/seomatic-config/fieldmeta/TagContainer.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -19,44 +19,44 @@
 block discarded – undo
  */
 
 return [
-    MetaTagContainer::CONTAINER_TYPE . TagService::GENERAL_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::GENERAL_HANDLE => [
         'name' => 'General',
         'description' => 'General Meta Tags',
         'handle' => TagService::GENERAL_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::FACEBOOK_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::FACEBOOK_HANDLE => [
         'name' => 'Facebook',
         'description' => 'Facebook OpenGraph Meta Tags',
         'handle' => TagService::FACEBOOK_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::TWITTER_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::TWITTER_HANDLE => [
         'name' => 'Twitter',
         'description' => 'Twitter Card Meta Tags',
         'handle' => TagService::TWITTER_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::MISC_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::MISC_HANDLE => [
         'name' => 'Miscellaneous',
         'description' => 'Miscellaneous Meta Tags',
         'handle' => TagService::MISC_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],

Please login to merge, or discard this patch.

src/seomatic-config/productmeta/TagContainer.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -19,44 +19,44 @@
 block discarded – undo
  */
 
 return [
-    MetaTagContainer::CONTAINER_TYPE . TagService::GENERAL_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::GENERAL_HANDLE => [
         'name' => 'General',
         'description' => 'General Meta Tags',
         'handle' => TagService::GENERAL_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::FACEBOOK_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::FACEBOOK_HANDLE => [
         'name' => 'Facebook',
         'description' => 'Facebook OpenGraph Meta Tags',
         'handle' => TagService::FACEBOOK_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::TWITTER_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::TWITTER_HANDLE => [
         'name' => 'Twitter',
         'description' => 'Twitter Card Meta Tags',
         'handle' => TagService::TWITTER_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],
         'data' => [
         ],
     ],
-    MetaTagContainer::CONTAINER_TYPE . TagService::MISC_HANDLE => [
+    MetaTagContainer::CONTAINER_TYPE.TagService::MISC_HANDLE => [
         'name' => 'Miscellaneous',
         'description' => 'Miscellaneous Meta Tags',
         'handle' => TagService::MISC_HANDLE,
-        'class' => (string)MetaTagContainer::class,
+        'class' => (string) MetaTagContainer::class,
         'include' => true,
         'dependencies' => [
         ],

Please login to merge, or discard this patch.

		@@ -51,16 +51,16 @@
		block discarded – undo
51	51	public function includeMetaData($dependency)
52	52	{
53	53	Craft::beginProfile('MetaJsonLdContainer::includeMetaData', __METHOD__);
54		- $uniqueKey = $this->handle . $dependency->tags[3] . '-v2';
	54	+ $uniqueKey = $this->handle.$dependency->tags[3].'-v2';
55	55	$cache = Craft::$app->getCache();
56	56	if ($this->clearCache) {
57	57	TagDependency::invalidate($cache, $dependency->tags[3]);
58	58	}
59	59	[$jsonLd, $attrs] = $cache->getOrSet(
60		- self::CONTAINER_TYPE . $uniqueKey,
	60	+ self::CONTAINER_TYPE.$uniqueKey,
61	61	function() use ($uniqueKey) {
62	62	Craft::info(
63		- self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
	63	+ self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
64	64	__METHOD__
65	65	);
66	66

		@@ -116,7 +116,7 @@ discard block
		block discarded – undo
116	116	*/
117	117	public function getFilename(int $groupId): string
118	118	{
119		- return 'sitemaps-' . $groupId . '-sitemap.xml';
	119	+ return 'sitemaps-'.$groupId.'-sitemap.xml';
120	120	}
121	121
122	122	/**
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	],
150	150	]);
151	151
152		- return $cache->getOrSet(self::CACHE_KEY . $groupId . '.' . $siteId, function() use ($groupSiteIds, $siteId) {
	152	+ return $cache->getOrSet(self::CACHE_KEY.$groupId.'.'.$siteId, function() use ($groupSiteIds, $siteId) {
153	153	Craft::info(
154	154	'Sitemap index cache miss',
155	155	__METHOD__

		@@ -49,16 +49,16 @@
		block discarded – undo
49	49	public function includeMetaData($dependency)
50	50	{
51	51	Craft::beginProfile('MetaTagContainer::includeMetaData', __METHOD__);
52		- $uniqueKey = $this->handle . $dependency->tags[3];
	52	+ $uniqueKey = $this->handle.$dependency->tags[3];
53	53	$cache = Craft::$app->getCache();
54	54	if ($this->clearCache) {
55	55	TagDependency::invalidate($cache, $dependency->tags[3]);
56	56	}
57	57	$tagData = $cache->getOrSet(
58		- self::CONTAINER_TYPE . $uniqueKey,
	58	+ self::CONTAINER_TYPE.$uniqueKey,
59	59	function() use ($uniqueKey) {
60	60	Craft::info(
61		- self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
	61	+ self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
62	62	__METHOD__
63	63	);
64	64	$tagData = [];

		@@ -55,16 +55,16 @@ discard block
		block discarded – undo
55	55	public function includeMetaData($dependency)
56	56	{
57	57	Craft::beginProfile('MetaScriptContainer::includeMetaData', __METHOD__);
58		- $uniqueKey = $this->handle . $dependency->tags[3] . $this->dataLayerHash();
	58	+ $uniqueKey = $this->handle.$dependency->tags[3].$this->dataLayerHash();
59	59	$cache = Craft::$app->getCache();
60	60	if ($this->clearCache) {
61	61	TagDependency::invalidate($cache, $dependency->tags[3]);
62	62	}
63	63	$tagData = $cache->getOrSet(
64		- self::CONTAINER_TYPE . $uniqueKey,
	64	+ self::CONTAINER_TYPE.$uniqueKey,
65	65	function() use ($uniqueKey) {
66	66	Craft::info(
67		- self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
	67	+ self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
68	68	__METHOD__
69	69	);
70	70
		@@ -140,7 +140,7 @@ discard block
		block discarded – undo
140	140	'jQuery(window).load()',
141	141	];
142	142	$position = $positionNames[$config['position'] - 1] ?? 'unknown';
143		- $html .= "<!-- Position: {$position} -->" . PHP_EOL;
	143	+ $html .= "<!-- Position: {$position} -->".PHP_EOL;
144	144	}
145	145	if ($bodyJs \|\| !$params['renderScriptTags']) {
146	146	$html .= $config['js'];

		@@ -49,16 +49,16 @@
		block discarded – undo
49	49	public function includeMetaData($dependency)
50	50	{
51	51	Craft::beginProfile('MetaLinkContainer::includeMetaData', __METHOD__);
52		- $uniqueKey = $this->handle . $dependency->tags[3];
	52	+ $uniqueKey = $this->handle.$dependency->tags[3];
53	53	$cache = Craft::$app->getCache();
54	54	if ($this->clearCache) {
55	55	TagDependency::invalidate($cache, $dependency->tags[3]);
56	56	}
57	57	$tagData = $cache->getOrSet(
58		- self::CONTAINER_TYPE . $uniqueKey,
	58	+ self::CONTAINER_TYPE.$uniqueKey,
59	59	function() use ($uniqueKey) {
60	60	Craft::info(
61		- self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
	61	+ self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
62	62	__METHOD__
63	63	);
64	64	$tagData = [];

		@@ -48,16 +48,16 @@
		block discarded – undo
48	48	public function includeMetaData($dependency)
49	49	{
50	50	Craft::beginProfile('MetaTitleContainer::includeMetaData', __METHOD__);
51		- $uniqueKey = $this->handle . $dependency->tags[3];
	51	+ $uniqueKey = $this->handle.$dependency->tags[3];
52	52	$cache = Craft::$app->getCache();
53	53	if ($this->clearCache) {
54	54	TagDependency::invalidate($cache, $dependency->tags[3]);
55	55	}
56	56	$tagData = $cache->getOrSet(
57		- self::CONTAINER_TYPE . $uniqueKey,
	57	+ self::CONTAINER_TYPE.$uniqueKey,
58	58	function() use ($uniqueKey) {
59	59	Craft::info(
60		- self::CONTAINER_TYPE . ' cache miss: ' . $uniqueKey,
	60	+ self::CONTAINER_TYPE.' cache miss: '.$uniqueKey,
61	61	__METHOD__
62	62	);
63	63	$tagData = '';

		@@ -19,44 +19,44 @@
		block discarded – undo
19	19	*/
20	20
21	21	return [
22		- MetaTagContainer::CONTAINER_TYPE . TagService::GENERAL_HANDLE => [
	22	+ MetaTagContainer::CONTAINER_TYPE.TagService::GENERAL_HANDLE => [
23	23	'name' => 'General',
24	24	'description' => 'General Meta Tags',
25	25	'handle' => TagService::GENERAL_HANDLE,
26		- 'class' => (string)MetaTagContainer::class,
	26	+ 'class' => (string) MetaTagContainer::class,
27	27	'include' => true,
28	28	'dependencies' => [
29	29	],
30	30	'data' => [
31	31	],
32	32	],
33		- MetaTagContainer::CONTAINER_TYPE . TagService::FACEBOOK_HANDLE => [
	33	+ MetaTagContainer::CONTAINER_TYPE.TagService::FACEBOOK_HANDLE => [
34	34	'name' => 'Facebook',
35	35	'description' => 'Facebook OpenGraph Meta Tags',
36	36	'handle' => TagService::FACEBOOK_HANDLE,
37		- 'class' => (string)MetaTagContainer::class,
	37	+ 'class' => (string) MetaTagContainer::class,
38	38	'include' => true,
39	39	'dependencies' => [
40	40	],
41	41	'data' => [
42	42	],
43	43	],
44		- MetaTagContainer::CONTAINER_TYPE . TagService::TWITTER_HANDLE => [
	44	+ MetaTagContainer::CONTAINER_TYPE.TagService::TWITTER_HANDLE => [
45	45	'name' => 'Twitter',
46	46	'description' => 'Twitter Card Meta Tags',
47	47	'handle' => TagService::TWITTER_HANDLE,
48		- 'class' => (string)MetaTagContainer::class,
	48	+ 'class' => (string) MetaTagContainer::class,
49	49	'include' => true,
50	50	'dependencies' => [
51	51	],
52	52	'data' => [
53	53	],
54	54	],
55		- MetaTagContainer::CONTAINER_TYPE . TagService::MISC_HANDLE => [
	55	+ MetaTagContainer::CONTAINER_TYPE.TagService::MISC_HANDLE => [
56	56	'name' => 'Miscellaneous',
57	57	'description' => 'Miscellaneous Meta Tags',
58	58	'handle' => TagService::MISC_HANDLE,
59		- 'class' => (string)MetaTagContainer::class,
	59	+ 'class' => (string) MetaTagContainer::class,
60	60	'include' => true,
61	61	'dependencies' => [
62	62	],

nystudio107 / craft-seomatic

Push — v4 ( 7020b0...4ea8ea )

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch