Issues (1783)

src/controllers/ApiController.php (27 issues)

1
<?php
2
/**
3
 * Retour plugin for Craft CMS
4
 *
5
 * Retour allows you to intelligently redirect legacy URLs, so that you don't
6
 * lose SEO value when rebuilding & restructuring a website
7
 *
8
 * @link      https://nystudio107.com/
0 ignored issues
show
The tag in position 1 should be the @copyright tag
Loading history...
9
 * @copyright Copyright (c) 2018 nystudio107
0 ignored issues
show
@copyright tag must contain a year and the name of the copyright holder
Loading history...
10
 */
0 ignored issues
show
PHP version not specified
Loading history...
Missing @category tag in file comment
Loading history...
Missing @package tag in file comment
Loading history...
Missing @author tag in file comment
Loading history...
Missing @license tag in file comment
Loading history...
11
12
namespace nystudio107\retour\controllers;
13
14
use craft\web\Controller;
15
use nystudio107\retour\Retour;
16
use yii\web\Response;
17
18
/**
0 ignored issues
show
Missing short description in doc comment
Loading history...
19
 * @author    nystudio107
0 ignored issues
show
The tag in position 1 should be the @package tag
Loading history...
Content of the @author tag must be in the form "Display Name <[email protected]>"
Loading history...
Tag value for @author tag indented incorrectly; expected 2 spaces but found 4
Loading history...
20
 * @package   Retour
0 ignored issues
show
Tag value for @package tag indented incorrectly; expected 1 spaces but found 3
Loading history...
21
 * @since     3.1.39
0 ignored issues
show
The tag in position 3 should be the @author tag
Loading history...
Tag value for @since tag indented incorrectly; expected 3 spaces but found 5
Loading history...
22
 */
0 ignored issues
show
Missing @category tag in class comment
Loading history...
Missing @license tag in class comment
Loading history...
Missing @link tag in class comment
Loading history...
23
class ApiController extends Controller
24
{
25
    // Constants
26
    // =========================================================================
27
28
    // Protected Properties
29
    // =========================================================================
30
31
    /**
0 ignored issues
show
Missing short description in doc comment
Loading history...
32
     * @inheritdoc
33
     */
34
    protected array|bool|int $allowAnonymous = [
35
        'get-redirects',
36
    ];
37
38
    // Public Methods
39
    // =========================================================================
40
41
    /**
0 ignored issues
show
Parameter $action should have a doc-comment as per coding-style.
Loading history...
Missing short description in doc comment
Loading history...
42
     * @inheritDoc
43
     */
0 ignored issues
show
Missing @return tag in function comment
Loading history...
44
    public function beforeAction($action): bool
45
    {
46
        if (!Retour::$settings->enableApiEndpoint) {
47
            $this->allowAnonymous = false;
48
        }
49
50
        return parent::beforeAction($action);
51
    }
52
53
    /**
0 ignored issues
show
Missing short description in doc comment
Loading history...
54
     * @param null $siteId
0 ignored issues
show
Documentation Bug introduced by
Are you sure the doc-type for parameter $siteId is correct as it would always require null to be passed?
Loading history...
Missing parameter comment
Loading history...
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
55
     * @return Response
0 ignored issues
show
Tag @return cannot be grouped with parameter tags in a doc comment
Loading history...
56
     */
57
    public function actionGetRedirects($siteId = null): Response
58
    {
59
        $redirects = Retour::$plugin->redirects->getAllStaticRedirects(null, $siteId);
0 ignored issues
show
The method getAllStaticRedirects() does not exist on null. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

59
        /** @scrutinizer ignore-call */ 
60
        $redirects = Retour::$plugin->redirects->getAllStaticRedirects(null, $siteId);

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
60
61
        return $this->asJson($redirects);
62
    }
63
}
64