nystudio107\retour\controllers\TablesController::actionDashboard()

Complexity

Conditions	10
Paths	39

Size

Total Lines	70
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes	7
Bugs	0	Features	1

<?php
    public function actionDashboard(
        string $sort = 'hitCount|desc',
        int $page = 1,
        int $per_page = 20,
        $filter = '',
        $siteId = 0,
        $handled = 'all'
    ): Response {
        PermissionHelper::controllerPermissionCheck('retour:dashboard');
        $data = [];
        $sortField = 'hitCount';
        $sortType = 'DESC';
        // Figure out the sorting type
        if ($sort !== '') {
            if (strpos($sort, '|') === false) {
                $sortField = $sort;
            } else {
                list($sortField, $sortType) = explode('|', $sort);
            }
        }
        $sortType = strtoupper($sortType);
        $sortType = self::SORT_MAP[$sortType] ?? self::SORT_MAP['DESC'];
        // Validate untrusted data
        if (!in_array($sortField, self::ALLOWED_STATS_SORT_FIELDS, true)) {
            throw new BadRequestHttpException(Craft::t('retour', 'Invalid sort field specified.'));
        }
        // Query the db table
        $offset = ($page - 1) * $per_page;
        $query = (new Query())
            ->from(['{{%retour_stats}}'])
            ->offset($offset)
            ->limit($per_page)
            ->orderBy([$sortField => $sortType])
            ->filterWhere(['like', 'redirectSrcUrl', $filter])
            ->orFilterWhere(['like', 'referrerUrl', $filter])

Space after closing parenthesis of function call prohibited

            ;
        if ((int)$siteId !== 0) {
            $query->andWhere(['siteId' => $siteId]);
        }
        if ($handled !== 'all') {
            $query->andWhere(['handledByRetour' => self::HANDLED_MAP[$handled]]);
        }
        $stats = $query->all();
        if ($stats) {

The expression $stats of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            // Add in the `addLink` field
            foreach ($stats as &$stat) {
                $stat['addLink'] = '';
                if (!$stat['handledByRetour']) {
                    $encodedUrl = urlencode('/'.ltrim($stat['redirectSrcUrl'], '/'));
                    $stat['addLink'] = UrlHelper::cpUrl('retour/add-redirect', [

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'defaultUrl' => $encodedUrl
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                }
            }
            // Format the data for the API
            $data['data'] = $stats;
            $count = $query->count();
            $data['links']['pagination'] = [
                'total' => $count,
                'per_page' => $per_page,
                'current_page' => $page,
                'last_page' => ceil($count / $per_page),
                'next_page_url' => null,
                'prev_page_url' => null,
                'from' => $offset + 1,
                'to' => $offset + ($count > $per_page ? $per_page : $count),
            ];
        }

        return $this->asJson($data);
    }